RE: [PATCH v2 03/11] OMAP2430: DMA: HWMOD: Add hwmod data structures

["G, Manjunath Kondaiah" <manjugk@ti.com>]

> -----Original Message-----
> From: Mika Westerberg [mailto:mika.westerberg@gmail.com] On 
> Behalf Of Mika Westerberg
> Sent: Tuesday, August 24, 2010 5:01 PM
> To: G, Manjunath Kondaiah
> Cc: linux-omap@vger.kernel.org; Cousson, Benoit; Kevin 
> Hilman; Shilimkar, Santosh
> Subject: Re: [PATCH v2 03/11] OMAP2430: DMA: HWMOD: Add hwmod 
> data structures
> 
> Hi,
> 
> On Tue, Aug 24, 2010 at 04:34:18PM +0530, Manjunatha GK wrote:
> > This patch adds OMAP2430 DMA hwmod structures.
> > 
> > Signed-off-by: Manjunatha GK <manjugk@ti.com>
> > Cc: Benoit Cousson <b-cousson@ti.com>
> > Cc: Kevin Hilman <khilman@deeprootsystems.com>
> > Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > ---
> >  arch/arm/mach-omap2/omap_hwmod_2430_data.c |   85 
> ++++++++++++++++++++++++++++
> >  1 files changed, 85 insertions(+), 0 deletions(-)
> > 
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_2430_data.c 
> b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
> > index 4526628..3d79a52 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_2430_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_2430_data.c
> > @@ -33,6 +33,7 @@ static struct omap_hwmod omap2430_mpu_hwmod;
> >  static struct omap_hwmod omap2430_iva_hwmod;
> >  static struct omap_hwmod omap2430_l3_main_hwmod;
> >  static struct omap_hwmod omap2430_l4_core_hwmod;
> > +static struct omap_hwmod omap2430_dma_system_hwmod;
> >  
> >  /* L3 -> L4_CORE interface */
> >  static struct omap_hwmod_ocp_if omap2430_l3_main__l4_core = {
> > @@ -165,12 +166,96 @@ static struct omap_hwmod 
> omap2430_iva_hwmod = {
> >  	.omap_chip	= OMAP_CHIP_INIT(CHIP_IS_OMAP2430)
> >  };
> >  
> > +/* dma_system */
> > +static struct omap_hwmod_class_sysconfig omap2430_dma_sysc = {
> > +	.rev_offs	= 0x0000,
> > +	.sysc_offs	= 0x002c,
> > +	.syss_offs	= 0x0028,
> > +	.sysc_flags	= (SYSC_HAS_SIDLEMODE | SYSC_HAS_SOFTRESET |
> > +			   SYSC_HAS_MIDLEMODE | SYSC_HAS_CLOCKACTIVITY |
> > +			   SYSC_HAS_EMUFREE | SYSC_HAS_AUTOIDLE),
> > +	.idlemodes	= (SIDLE_FORCE | SIDLE_NO | SIDLE_SMART |
> > +			   MSTANDBY_FORCE | MSTANDBY_NO | 
> MSTANDBY_SMART),
> > +	.sysc_fields	= &omap_hwmod_sysc_type1,
> > +};
> > +
> > +static struct omap_hwmod_class omap2430_dma_hwmod_class = {
> > +	.name = "dma",
> > +	.sysc = &omap2430_dma_sysc,
> > +};
> > +
> > +/* dma attributes */
> > +static struct omap_dma_dev_attr dma_dev_attr = {
> > +	.dev_caps  = DMA_LINKED_LCH | GLOBAL_PRIORITY |
> > +				IS_CSSA_32 | IS_CDSA_32 | IS_RW_PRIORIY,
>                                                           
> ^^^^^^^^^^^^^
> 
> Should this be IS_RW_PRIORITY? Same typo seems to be also in 
> other patches which
> add hwmod structures.

Thanks for identifying this typo. I will take care of it.

-Manjunath