From mboxrd@z Thu Jan 1 00:00:00 1970 From: "De Lara Guarch, Pablo" Subject: Re: [PATCH 03/16] crypto/cpt/base: add hardware initialization API for CPT Date: Tue, 19 Jun 2018 13:56:49 +0000 Message-ID: References: <1528476325-15585-1-git-send-email-anoob.joseph@caviumnetworks.com> <1528476325-15585-4-git-send-email-anoob.joseph@caviumnetworks.com> <20180614031336.GC16602@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: Akhil Goyal , Thomas Monjalon , Nithin Dabilpuram , Ankur Dwivedi , Murthy NSSR , Narayana Prasad , "Ragothaman Jayaraman" , Srisivasubramanian Srinivasan , "dev@dpdk.org" To: Jerin Jacob , Anoob Joseph Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id 3A3294C96 for ; Tue, 19 Jun 2018 15:56:54 +0200 (CEST) In-Reply-To: <20180614031336.GC16602@jerin> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Jerin Jacob [mailto:jerin.jacob@caviumnetworks.com] > Sent: Thursday, June 14, 2018 4:14 AM > To: Anoob Joseph > Cc: Akhil Goyal ; De Lara Guarch, Pablo > ; Thomas Monjalon > ; Nithin Dabilpuram ; > Ankur Dwivedi ; Murthy NSSR > ; Narayana Prasad > ; Ragothaman Jayaraman > ; Srisivasubramanian Srinivasan > ; dev@dpdk.org > Subject: Re: [PATCH 03/16] crypto/cpt/base: add hardware initialization A= PI for > CPT >=20 > -----Original Message----- > > Date: Fri, 8 Jun 2018 22:15:12 +0530 > > From: Anoob Joseph > > To: Akhil Goyal , Pablo de Lara > > , Thomas Monjalon > > > > Cc: Nithin Dabilpuram , Ankur Dwivedi > > , Jerin Jacob > > , Murthy NSSR > > , Narayana Prasad > > , Ragothaman Jayaraman > > , Srisivasubramanian Srinivasan > > , dev@dpdk.org > > Subject: [PATCH 03/16] crypto/cpt/base: add hardware initialization > > API for CPT > > X-Mailer: git-send-email 2.7.4 > > > > From: Nithin Dabilpuram > > > > Adds hardware device initialization specific api for Cavium CPT device. > > > > Signed-off-by: Ankur Dwivedi > > Signed-off-by: Murthy NSSR > > Signed-off-by: Nithin Dabilpuram > > Signed-off-by: Ragothaman Jayaraman > > > Signed-off-by: Srisivasubramanian Srinivasan > > > > --- > > drivers/crypto/cpt/base/cpt8xxx_device.c | 200 ++++++++++++++++ > > drivers/crypto/cpt/base/cpt8xxx_device.h | 85 +++++++ > > drivers/crypto/cpt/base/cpt_debug.h | 231 +++++++++++++++++++ > > drivers/crypto/cpt/base/cpt_device.c | 383 > +++++++++++++++++++++++++++++++ > > drivers/crypto/cpt/base/cpt_device.h | 162 +++++++++++++ > > drivers/crypto/cpt/base/cpt_vf_mbox.c | 176 ++++++++++++++ > > drivers/crypto/cpt/base/cpt_vf_mbox.h | 60 +++++ > > 7 files changed, 1297 insertions(+) > > create mode 100644 drivers/crypto/cpt/base/cpt8xxx_device.c > > create mode 100644 drivers/crypto/cpt/base/cpt8xxx_device.h > > create mode 100644 drivers/crypto/cpt/base/cpt_debug.h > > create mode 100644 drivers/crypto/cpt/base/cpt_device.c > > create mode 100644 drivers/crypto/cpt/base/cpt_device.h > > create mode 100644 drivers/crypto/cpt/base/cpt_vf_mbox.c > > create mode 100644 drivers/crypto/cpt/base/cpt_vf_mbox.h > > > > +#include > > +#include "cpt_request_mgr.h" > > +#include List the external to DPDK includes first, then internal to DPDK and then in= ternal to this PMD, separating these three blocks with a blank line. > > + > > +#ifdef CPT_DEBUG >=20 > Remove CPT_DEBUG. No harming in compiling these definitions either case. > It will avoid the chance of build breakage. >=20 ... > > +int cptvf_deinit_device(struct cpt_vf *dev) { > > + struct cpt_vf *cptvf =3D (struct cpt_vf *)dev; > > + > > + /* Do misc work one last time */ > > + cptvf_poll_misc(cptvf); > > + > > + /* TODO anything else ?? */ >=20 > Remove unclear TODOs >=20 > > + > > + return 0; > > +} > > + > > +int cptvf_init_device(struct cpt_vf *cptvf, Return type should be in the line above the function name, as per DPDK coding style guidelines. > > + void *pdev, > > + void *reg_base, > > + char *name, > > + uint32_t flags) > > +{ > > + (void) flags; >=20 >=20 > RTE_SET_USED Actually, why don't you just remove the parameter? Thanks, Pablo