From: "Van Haaren, Harry" <harry.van.haaren@intel.com>
To: "Rao, Nikhil" <nikhil.rao@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] service: fix parameter type
Date: Mon, 21 Jan 2019 11:43:59 +0000 [thread overview]
Message-ID: <E923DB57A917B54B9182A2E928D00FA6757C579E@IRSMSX102.ger.corp.intel.com> (raw)
In-Reply-To: <1547906489-71240-1-git-send-email-nikhil.rao@intel.com>
> -----Original Message-----
> From: Rao, Nikhil
> Sent: Saturday, January 19, 2019 2:01 PM
> To: Van Haaren, Harry <harry.van.haaren@intel.com>
> Cc: dev@dpdk.org; Rao, Nikhil <nikhil.rao@intel.com>
> Subject: [PATCH] service: fix parameter type
>
> The type of value parameter to rte_service_attr_get
> should be uint64_t *, since the attributes
> are of type uint64_t.
>
> Fixes: 4d55194d76a4 ("service: add attribute get function")
>
> Reviewed-by: Gage Eads <gage.eads@intel.com>
> Signed-off-by: Nikhil Rao <nikhil.rao@intel.com>
Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
> ---
> lib/librte_eal/common/include/rte_service.h | 2 +-
> lib/librte_eal/common/rte_service.c | 2 +-
> test/test/test_service_cores.c | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> For 19.02, I assume this will require the ABI change announcement. I will
> post it once this patch is acked.
Correct - this breaks API and ABI, so certainly will need an announce.
Thanks for the fixup, -Harry
next prev parent reply other threads:[~2019-01-21 11:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 14:01 [PATCH] service: fix parameter type Nikhil Rao
2019-01-21 11:43 ` Van Haaren, Harry [this message]
2019-02-08 15:01 ` Ferruh Yigit
2019-02-14 9:56 ` [PATCH v2] " Nikhil Rao
2019-02-15 10:29 ` [PATCH v3] " Nikhil Rao
2019-02-18 20:27 ` Rami Rosen
2019-03-27 9:52 ` Thomas Monjalon
2019-03-28 6:29 ` [PATCH v4] " Nikhil Rao
2019-03-28 20:10 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E923DB57A917B54B9182A2E928D00FA6757C579E@IRSMSX102.ger.corp.intel.com \
--to=harry.van.haaren@intel.com \
--cc=dev@dpdk.org \
--cc=nikhil.rao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.