All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
To: Mark Brown <broonie@kernel.org>,
	Support Opensource <Support.Opensource@diasemi.com>,
	Liam Girdwood <lgirdwood@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: RE: [PATCH v3] ASoC: da7219: Fix change notifications for tone generator frequency
Date: Wed, 20 Apr 2022 15:14:16 +0000	[thread overview]
Message-ID: <GV1PR10MB6124C4725691FF2CC0A5981A80F59@GV1PR10MB6124.EURPRD10.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <20220420133437.569229-1-broonie@kernel.org>

On 20 April 2022 14:35, Mark Brown wrote:

> The tone generator frequency control just returns 0 on successful write,
> not a boolean value indicating if there was a change or not.  Compare
> what was written with the value that was there previously so that
> notifications are generated appropriately when the value changes.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>

  reply	other threads:[~2022-04-20 15:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20 13:34 [PATCH v3] ASoC: da7219: Fix change notifications for tone generator frequency Mark Brown
2022-04-20 15:14 ` Adam Thomson [this message]
2022-04-20 22:55 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV1PR10MB6124C4725691FF2CC0A5981A80F59@GV1PR10MB6124.EURPRD10.PROD.OUTLOOK.COM \
    --to=adam.thomson.opensource@diasemi.com \
    --cc=Support.Opensource@diasemi.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.