From: Ophir Munk <ophirmu@mellanox.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>,
Thomas Monjalon <thomas@monjalon.net>,
Pascal Mazon <pascal.mazon@6wind.com>,
"Mordechay Haimovsky" <motih@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Shahaf Shuler <shahafs@mellanox.com>,
"Olga Shern" <olgas@mellanox.com>
Subject: Re: [PATCH] net/tap: remove queue specific offload support
Date: Wed, 18 Apr 2018 09:40:57 +0000 [thread overview]
Message-ID: <HE1PR0501MB23147AC7B77F2ABF1E3D9C23D1B60@HE1PR0501MB2314.eurprd05.prod.outlook.com> (raw)
In-Reply-To: <33d0cd29-855e-58dd-683d-e540a7978515@intel.com>
Hi Ferruh,
Sorry for the delayed response.
I would like to verify the correctness of this patch by running several internal tests.
Is a reply by Monday OK with you?
Regards,
Ophir
> -----Original Message-----
> From: Ferruh Yigit [mailto:ferruh.yigit@intel.com]
> Sent: Wednesday, April 18, 2018 11:59 AM
> To: Thomas Monjalon <thomas@monjalon.net>; Pascal Mazon
> <pascal.mazon@6wind.com>; Mordechay Haimovsky
> <motih@mellanox.com>; Ophir Munk <ophirmu@mellanox.com>
> Cc: dev@dpdk.org; Shahaf Shuler <shahafs@mellanox.com>; Olga Shern
> <olgas@mellanox.com>
> Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload
> support
>
> On 4/12/2018 5:23 PM, Ferruh Yigit wrote:
> > On 4/5/2018 6:49 PM, Thomas Monjalon wrote:
> >> Pascal, Moti, Ophir,
> >> please comment.
> >
> > Hi Moti,
> >
> > Any comment? This has been asked many times now.
>
> Hi Moti, Ophir,
>
> You have not responded why queue specific offload added in other thread.
> And you are not responding to this patch...
>
> Hi Pascal,
>
> If you also have no objection, this patch is going in.
>
> Thanks,
> ferruh
>
>
> >
> >>
> >> 22/03/2018 19:28, Ferruh Yigit:
> >>> It is not clear if tap PMD supports queue specific offloads,
> >>> removing the related code.
> >>>
> >>> Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API")
> >>> Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API")
> >>> Cc: motih@mellanox.com
> >>>
> >>> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> >>
> >>
> >>
> >
next prev parent reply other threads:[~2018-04-18 9:40 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-22 18:28 [PATCH] net/tap: remove queue specific offload support Ferruh Yigit
2018-04-05 17:49 ` Thomas Monjalon
2018-04-12 16:23 ` Ferruh Yigit
2018-04-18 8:59 ` Ferruh Yigit
2018-04-18 9:40 ` Ophir Munk [this message]
2018-04-18 10:55 ` Ferruh Yigit
2018-04-22 16:04 ` Ophir Munk
2018-04-23 8:39 ` Ophir Munk
2018-04-23 9:17 ` Ophir Munk
2018-04-23 10:13 ` Ferruh Yigit
2018-04-23 11:32 ` Ophir Munk
2018-04-24 17:57 ` Ferruh Yigit
2018-04-23 9:38 ` [PATCH v2] " Ferruh Yigit
2018-04-24 17:54 ` [PATCH v3] " Ferruh Yigit
2018-04-25 9:18 ` Ophir Munk
2018-04-25 9:48 ` Ferruh Yigit
2018-04-25 12:00 ` Ophir Munk
2018-04-25 12:20 ` Ophir Munk
2018-04-25 16:17 ` Ophir Munk
2018-04-25 17:18 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=HE1PR0501MB23147AC7B77F2ABF1E3D9C23D1B60@HE1PR0501MB2314.eurprd05.prod.outlook.com \
--to=ophirmu@mellanox.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=motih@mellanox.com \
--cc=olgas@mellanox.com \
--cc=pascal.mazon@6wind.com \
--cc=shahafs@mellanox.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.