From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA8F5C433E0 for ; Tue, 23 Jun 2020 02:31:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C5467206C1 for ; Tue, 23 Jun 2020 02:31:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=microsoft.com header.i=@microsoft.com header.b="gBXJQfrZ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731414AbgFWCbe (ORCPT ); Mon, 22 Jun 2020 22:31:34 -0400 Received: from mail-eopbgr1310117.outbound.protection.outlook.com ([40.107.131.117]:48304 "EHLO APC01-SG2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1730456AbgFWCbe (ORCPT ); Mon, 22 Jun 2020 22:31:34 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RImAIeglGNT9g4V+9whaZVyptf27TlX9aTXZUinhEyEXykh+4rft5rMe0L9i3jQyhJMzmQNI2haDbzJTq8o1isq1b5T6HgddRgH8uFrZlFpUk1MuTNAsFEpKovOqaQ5+IWRj/Z48WcL+ELJ8JDAevGm1km8PTvz3XJ2lpFf0HDCl3xRAKzOLQRwv/WAZS4H89IsMcTwE1LG7wMb6qCKlG75itJGOTO2hzdLQSnjLICxNh0lCxPI1u+5BmI3By6jN1TU1jinDFzQL/jTP/kmxb5JzB41hX6Hq2YoTRyKgDP6fbms/aM/Mi+YMip0cWV3we5s1J98vBbOerNno5ijKMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gqkGtlE34Ptsn7f3+oeF0XDtYU1eppsl+F+ijpjUslg=; b=ExUUQYbigidw189RG7n2QeA8qZumGMyniLp8Yl3/UrGtL54Xfo1sKVsMKNV5MYDXy6Sa0It6oUdwQP3fygsrpcCxGhlE0kHhxGmZda9pN79QrhrLUNXU1sTKnOpdlHmATCV6001TwNpUjWLk/TjdwLU8IcHTijS0mnwq9jj+T4usRdR/ZI/Ee5za49OhNcyzKAeTgaF8fCk03w7J+G9DuynHCVVwyMfQ0AiRERMhgRxwTCl3rB9Dpxr0ApHnS6Qaxgt4M018QdUIMWE9seHGvkRpPdr5az17GKM71NdJw6JGcg6vgmWTrHfP7q2tORLzYTB8pIECmpxWB5Os1XFrGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gqkGtlE34Ptsn7f3+oeF0XDtYU1eppsl+F+ijpjUslg=; b=gBXJQfrZIdCxkciS98xjn+coN/Nvnyav+79XFj5VnYc0Pggny8KkCYp/v9+l9NNmRQ8+XUMtXPdqXhvRv8vQX/QtoDKj4k2TwsK8VSVGpQhcGQP2HEAUnsXQLEwiyBsbyoaIjWuMqQRZEuwQKXXiFtuja0vb41ovawj2FpvAAnI= Received: from HK0P153MB0322.APCP153.PROD.OUTLOOK.COM (2603:1096:203:b5::19) by HK0P153MB0148.APCP153.PROD.OUTLOOK.COM (2603:1096:203:1a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.4; Tue, 23 Jun 2020 02:31:21 +0000 Received: from HK0P153MB0322.APCP153.PROD.OUTLOOK.COM ([fe80::e567:3a32:6574:8983]) by HK0P153MB0322.APCP153.PROD.OUTLOOK.COM ([fe80::e567:3a32:6574:8983%7]) with mapi id 15.20.3153.005; Tue, 23 Jun 2020 02:31:21 +0000 From: Dexuan Cui To: Deepak Rawat , "linux-hyperv@vger.kernel.org" , "dri-devel@lists.freedesktop.org" CC: David Airlie , Daniel Vetter , Maarten Lankhorst , Maxime Ripard , KY Srinivasan , Haiyang Zhang , Stephen Hemminger , Wei Liu , Wei Hu , Jork Loeser , Michael Kelley Subject: RE: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device Thread-Topic: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device Thread-Index: AQHWSIVPTyd7nwDoi0OeDECzal8UNajldhsQ Date: Tue, 23 Jun 2020 02:31:20 +0000 Message-ID: References: <20200622110623.113546-1-drawat.floss@gmail.com> <20200622110623.113546-2-drawat.floss@gmail.com> In-Reply-To: <20200622110623.113546-2-drawat.floss@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-06-23T02:31:19Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=8c46a189-3137-43db-8b00-88ba04b4d7cd; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [2601:600:a280:7f70:ddf9:ea7a:43e2:c8ff] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 390c5fd0-0021-44f0-f2fc-08d8171d8438 x-ms-traffictypediagnostic: HK0P153MB0148: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6DJC6W8hNMjU5hblhODxwQhEMn3qZTACr2FUDb/w5KqXABKxV//Nl0l2zZkOWiTkIEzfpe2E7AHIym7j/5GFT/PT/wf1OWsUDZW0oPnA4365/k+fDDnBbcM5WPT86f+d50FjeFa1RStkSCyc4wf1C6ogqInsj/fJ3iGcP2ghGyczEEfZRGeCMZF2/gT0dJzoVRofydzrwQrz1LVqY+DOtLidKPlIgFnF2fX8VWoyKbz2ryGWXaBlOlSz4Kc/M1NknsMetzdaTy9H0vCa9lt3PgVPCdGTXc4ZJArY87t8xQFqPCqhnee+8QPqpR90lXyBS9vkNHEkrUaFVl18EAkZWg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:HK0P153MB0322.APCP153.PROD.OUTLOOK.COM;PTR:;CAT:NONE;SFTY:;SFS:(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(107886003)(82950400001)(8676002)(86362001)(186003)(5660300002)(33656002)(82960400001)(4744005)(8990500004)(71200400001)(66946007)(76116006)(6506007)(66446008)(64756008)(7696005)(4326008)(66476007)(66556008)(2906002)(10290500003)(316002)(110136005)(9686003)(55016002)(52536014)(54906003)(478600001)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata: LwPflNAd4HKx+Wepkg3tzPrWiIM5+ps5l327WJvKxA9DL1+Y6/yt11/b9gs2ViL9s3Ra4TwJKNkT+dQVDhwjhzCw1p30QXszkN/JrhROofiib2cZZUoC+OdQuMttW4nz9VqCEh+YSoz1kI8+DqObYvCDhb2GfVJumcefe0A6tSkX2ImoHbnkByDZY1p1V/PTJwEof47LcDVngzD7zZmuf7/jfjaQu1sEy9bb26AAee6k5t1pJVih7KFPBA8j7WRHTN7o8nG2gCFvPwrgOktCk6LOScRjrhwuEGW7uPuHrOUoWj34VuXdVEhATHQkfbH+04/P1W0w1+H1EYlV6lfHW8SYmHazhA8gcHdntTJWMckbRqgewfXU+jQotq754U5PE7PCfsmKNEk8MIIVz485Z/nDwCJsp8xfmChzIchiq1taHQR22MlWoUHr+Sn3hlJg+IyxrPFbal2rWgXyll2nadqA6P21yrbJZSyQVuvuA7+9zt96TpNO14mYcb8EXi6H9uqqNJwSXATmJ3dNwsFhIBBje13A3633rKpXJJnkIHHAO9PgYdTtKgdofo9HH72s Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0P153MB0322.APCP153.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 390c5fd0-0021-44f0-f2fc-08d8171d8438 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 02:31:20.8502 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aGvCoqKR9HpeoBAB8n18/v+tNcdT4zmuXb5Imp1KEVurfsOlpP8WkhH6UshOyYF2APqS2DRJ6qXc9mLV2WhAPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0P153MB0148 Sender: linux-hyperv-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org > From: linux-hyperv-owner@vger.kernel.org > On Behalf Of Deepak Rawat > Sent: Monday, June 22, 2020 4:06 AM >=20 > DRM driver for hyperv synthetic video device, based on hyperv_fb > framebuffer driver. Also added config option "DRM_HYPERV" to enabled > this driver. Hi Deepak, I had a quick look and overall the patch as v1 looks good to me.=20 Some quick comments: 1. hyperv_vmbus_probe() assumes the existence of the PCI device, which is not true in a Hyper-V Generation-2 VM. 2. It looks some other functionality in the hyperv_fb driver has not been implemented in this new driver either, e.g. the handling of the SYNTHVID_FEATURE_CHANGE msg. Thanks, -- Dexuan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 279F4C433DF for ; Tue, 23 Jun 2020 07:49:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DAEE22073E for ; Tue, 23 Jun 2020 07:49:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=microsoft.com header.i=@microsoft.com header.b="gBXJQfrZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DAEE22073E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=microsoft.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6252C6E962; Tue, 23 Jun 2020 07:48:59 +0000 (UTC) Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-eopbgr1310135.outbound.protection.outlook.com [40.107.131.135]) by gabe.freedesktop.org (Postfix) with ESMTPS id D74216E214 for ; Tue, 23 Jun 2020 02:31:30 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RImAIeglGNT9g4V+9whaZVyptf27TlX9aTXZUinhEyEXykh+4rft5rMe0L9i3jQyhJMzmQNI2haDbzJTq8o1isq1b5T6HgddRgH8uFrZlFpUk1MuTNAsFEpKovOqaQ5+IWRj/Z48WcL+ELJ8JDAevGm1km8PTvz3XJ2lpFf0HDCl3xRAKzOLQRwv/WAZS4H89IsMcTwE1LG7wMb6qCKlG75itJGOTO2hzdLQSnjLICxNh0lCxPI1u+5BmI3By6jN1TU1jinDFzQL/jTP/kmxb5JzB41hX6Hq2YoTRyKgDP6fbms/aM/Mi+YMip0cWV3we5s1J98vBbOerNno5ijKMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gqkGtlE34Ptsn7f3+oeF0XDtYU1eppsl+F+ijpjUslg=; b=ExUUQYbigidw189RG7n2QeA8qZumGMyniLp8Yl3/UrGtL54Xfo1sKVsMKNV5MYDXy6Sa0It6oUdwQP3fygsrpcCxGhlE0kHhxGmZda9pN79QrhrLUNXU1sTKnOpdlHmATCV6001TwNpUjWLk/TjdwLU8IcHTijS0mnwq9jj+T4usRdR/ZI/Ee5za49OhNcyzKAeTgaF8fCk03w7J+G9DuynHCVVwyMfQ0AiRERMhgRxwTCl3rB9Dpxr0ApHnS6Qaxgt4M018QdUIMWE9seHGvkRpPdr5az17GKM71NdJw6JGcg6vgmWTrHfP7q2tORLzYTB8pIECmpxWB5Os1XFrGw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=microsoft.com; dmarc=pass action=none header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gqkGtlE34Ptsn7f3+oeF0XDtYU1eppsl+F+ijpjUslg=; b=gBXJQfrZIdCxkciS98xjn+coN/Nvnyav+79XFj5VnYc0Pggny8KkCYp/v9+l9NNmRQ8+XUMtXPdqXhvRv8vQX/QtoDKj4k2TwsK8VSVGpQhcGQP2HEAUnsXQLEwiyBsbyoaIjWuMqQRZEuwQKXXiFtuja0vb41ovawj2FpvAAnI= Received: from HK0P153MB0322.APCP153.PROD.OUTLOOK.COM (2603:1096:203:b5::19) by HK0P153MB0148.APCP153.PROD.OUTLOOK.COM (2603:1096:203:1a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3153.4; Tue, 23 Jun 2020 02:31:21 +0000 Received: from HK0P153MB0322.APCP153.PROD.OUTLOOK.COM ([fe80::e567:3a32:6574:8983]) by HK0P153MB0322.APCP153.PROD.OUTLOOK.COM ([fe80::e567:3a32:6574:8983%7]) with mapi id 15.20.3153.005; Tue, 23 Jun 2020 02:31:21 +0000 From: Dexuan Cui To: Deepak Rawat , "linux-hyperv@vger.kernel.org" , "dri-devel@lists.freedesktop.org" Subject: RE: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device Thread-Topic: [RFC PATCH 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device Thread-Index: AQHWSIVPTyd7nwDoi0OeDECzal8UNajldhsQ Date: Tue, 23 Jun 2020 02:31:20 +0000 Message-ID: References: <20200622110623.113546-1-drawat.floss@gmail.com> <20200622110623.113546-2-drawat.floss@gmail.com> In-Reply-To: <20200622110623.113546-2-drawat.floss@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-06-23T02:31:19Z; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=8c46a189-3137-43db-8b00-88ba04b4d7cd; MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0 authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=microsoft.com; x-originating-ip: [2601:600:a280:7f70:ddf9:ea7a:43e2:c8ff] x-ms-publictraffictype: Email x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 390c5fd0-0021-44f0-f2fc-08d8171d8438 x-ms-traffictypediagnostic: HK0P153MB0148: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7219; x-forefront-prvs: 04433051BF x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 6DJC6W8hNMjU5hblhODxwQhEMn3qZTACr2FUDb/w5KqXABKxV//Nl0l2zZkOWiTkIEzfpe2E7AHIym7j/5GFT/PT/wf1OWsUDZW0oPnA4365/k+fDDnBbcM5WPT86f+d50FjeFa1RStkSCyc4wf1C6ogqInsj/fJ3iGcP2ghGyczEEfZRGeCMZF2/gT0dJzoVRofydzrwQrz1LVqY+DOtLidKPlIgFnF2fX8VWoyKbz2ryGWXaBlOlSz4Kc/M1NknsMetzdaTy9H0vCa9lt3PgVPCdGTXc4ZJArY87t8xQFqPCqhnee+8QPqpR90lXyBS9vkNHEkrUaFVl18EAkZWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:HK0P153MB0322.APCP153.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFTY:; SFS:(4636009)(366004)(39860400002)(396003)(376002)(346002)(136003)(107886003)(82950400001)(8676002)(86362001)(186003)(5660300002)(33656002)(82960400001)(4744005)(8990500004)(71200400001)(66946007)(76116006)(6506007)(66446008)(64756008)(7696005)(4326008)(66476007)(66556008)(2906002)(10290500003)(316002)(110136005)(9686003)(55016002)(52536014)(54906003)(478600001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: LwPflNAd4HKx+Wepkg3tzPrWiIM5+ps5l327WJvKxA9DL1+Y6/yt11/b9gs2ViL9s3Ra4TwJKNkT+dQVDhwjhzCw1p30QXszkN/JrhROofiib2cZZUoC+OdQuMttW4nz9VqCEh+YSoz1kI8+DqObYvCDhb2GfVJumcefe0A6tSkX2ImoHbnkByDZY1p1V/PTJwEof47LcDVngzD7zZmuf7/jfjaQu1sEy9bb26AAee6k5t1pJVih7KFPBA8j7WRHTN7o8nG2gCFvPwrgOktCk6LOScRjrhwuEGW7uPuHrOUoWj34VuXdVEhATHQkfbH+04/P1W0w1+H1EYlV6lfHW8SYmHazhA8gcHdntTJWMckbRqgewfXU+jQotq754U5PE7PCfsmKNEk8MIIVz485Z/nDwCJsp8xfmChzIchiq1taHQR22MlWoUHr+Sn3hlJg+IyxrPFbal2rWgXyll2nadqA6P21yrbJZSyQVuvuA7+9zt96TpNO14mYcb8EXi6H9uqqNJwSXATmJ3dNwsFhIBBje13A3633rKpXJJnkIHHAO9PgYdTtKgdofo9HH72s MIME-Version: 1.0 X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: HK0P153MB0322.APCP153.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-Network-Message-Id: 390c5fd0-0021-44f0-f2fc-08d8171d8438 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Jun 2020 02:31:20.8502 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: aGvCoqKR9HpeoBAB8n18/v+tNcdT4zmuXb5Imp1KEVurfsOlpP8WkhH6UshOyYF2APqS2DRJ6qXc9mLV2WhAPQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: HK0P153MB0148 X-Mailman-Approved-At: Tue, 23 Jun 2020 07:48:47 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wei Liu , Stephen Hemminger , David Airlie , Haiyang Zhang , Michael Kelley , Jork Loeser , Wei Hu , KY Srinivasan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" > From: linux-hyperv-owner@vger.kernel.org > On Behalf Of Deepak Rawat > Sent: Monday, June 22, 2020 4:06 AM > > DRM driver for hyperv synthetic video device, based on hyperv_fb > framebuffer driver. Also added config option "DRM_HYPERV" to enabled > this driver. Hi Deepak, I had a quick look and overall the patch as v1 looks good to me. Some quick comments: 1. hyperv_vmbus_probe() assumes the existence of the PCI device, which is not true in a Hyper-V Generation-2 VM. 2. It looks some other functionality in the hyperv_fb driver has not been implemented in this new driver either, e.g. the handling of the SYNTHVID_FEATURE_CHANGE msg. Thanks, -- Dexuan _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel