All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qiuhao Li <Qiuhao.Li@outlook.com>
To: alxndr@bu.edu, qemu-devel@nongnu.org
Cc: thuth@redhat.com, Qiuhao Li <Qiuhao.Li@outlook.com>,
	darren.kenny@oracle.com, bsd@redhat.com, stefanha@redhat.com,
	pbonzini@redhat.com
Subject: [PATCH v4 7/7] fuzz: heuristic split write based on past IOs
Date: Tue, 29 Dec 2020 12:40:44 +0800	[thread overview]
Message-ID: <ME3P282MB174588DE27F32E918F71DA1BFCD80@ME3P282MB1745.AUSP282.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <ME3P282MB17456B93AE422008F433C50DFCD80@ME3P282MB1745.AUSP282.PROD.OUTLOOK.COM>

If previous write commands write the same length of data with the same step,
we view it as a hint.

Signed-off-by: Qiuhao Li <Qiuhao.Li@outlook.com>
---
 scripts/oss-fuzz/minimize_qtest_trace.py | 56 ++++++++++++++++++++++++
 1 file changed, 56 insertions(+)

diff --git a/scripts/oss-fuzz/minimize_qtest_trace.py b/scripts/oss-fuzz/minimize_qtest_trace.py
index a681984076..6cbf2b0419 100755
--- a/scripts/oss-fuzz/minimize_qtest_trace.py
+++ b/scripts/oss-fuzz/minimize_qtest_trace.py
@@ -85,6 +85,43 @@ def check_if_trace_crashes(trace, path):
     return False
 
 
+# If previous write commands write the same length of data at the same
+# interval, we view it as a hint.
+def split_write_hint(newtrace, i):
+    HINT_LEN = 3 # > 2
+    if i <=(HINT_LEN-1):
+        return None
+
+    #find previous continuous write traces
+    k = 0
+    l = i-1
+    writes = []
+    while (k != HINT_LEN and l >= 0):
+        if newtrace[l].startswith("write "):
+            writes.append(newtrace[l])
+            k += 1
+            l -= 1
+        elif newtrace[l] == "":
+            l -= 1
+        else:
+            return None
+    if k != HINT_LEN:
+        return None
+
+    length = int(writes[0].split()[2], 16)
+    for j in range(1, HINT_LEN):
+        if length != int(writes[j].split()[2], 16):
+            return None
+
+    step = int(writes[0].split()[1], 16) - int(writes[1].split()[1], 16)
+    for j in range(1, HINT_LEN-1):
+        if step != int(writes[j].split()[1], 16) - \
+            int(writes[j+1].split()[1], 16):
+            return None
+
+    return (int(writes[0].split()[1], 16)+step, length)
+
+
 def remove_minimizer(newtrace, outpath):
     remove_step = 1
     i = 0
@@ -148,6 +185,25 @@ def remove_minimizer(newtrace, outpath):
             length = int(newtrace[i].split()[2], 16)
             data = newtrace[i].split()[3][2:]
             if length > 1:
+
+                # Can we get a hint from previous writes?
+                hint = split_write_hint(newtrace, i)
+                if hint is not None:
+                    hint_addr = hint[0]
+                    hint_len = hint[1]
+                    if hint_addr >= addr and hint_addr+hint_len <= addr+length:
+                        newtrace[i] = "write {addr} {size} 0x{data}\n".format(
+                            addr=hex(hint_addr),
+                            size=hex(hint_len),
+                            data=data[(hint_addr-addr)*2:\
+                                (hint_addr-addr)*2+hint_len*2])
+                        if check_if_trace_crashes(newtrace, outpath):
+                            # next round
+                            i += 1
+                            continue
+                        newtrace[i] = prior[0]
+
+                # Try splitting it using a binary approach
                 leftlength = int(length/2)
                 rightlength = length - leftlength
                 newtrace.insert(i+1, "")
-- 
2.25.1



  parent reply	other threads:[~2020-12-29  4:43 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29  4:39 [PATCH v4 0/7] fuzz: improve crash case minimization Qiuhao Li
2020-12-29  4:40 ` [PATCH v4 1/7] fuzz: accelerate non-crash detection Qiuhao Li
2021-01-07  3:42   ` Alexander Bulekov
2021-01-07  4:18   ` Alexander Bulekov
2021-01-08  2:47     ` Qiuhao Li
2021-01-10 13:10     ` Qiuhao Li
2021-01-10 16:00       ` Alexander Bulekov
2021-01-11  2:19         ` Qiuhao Li
2020-12-29  4:40 ` [PATCH v4 2/7] fuzz: double the IOs to remove for every loop Qiuhao Li
2021-01-07  4:19   ` Alexander Bulekov
2020-12-29  4:40 ` [PATCH v4 3/7] fuzz: split write operand using binary approach Qiuhao Li
2021-01-07  4:28   ` Alexander Bulekov
2020-12-29  4:40 ` [PATCH v4 4/7] fuzz: loop the remove minimizer and refactoring Qiuhao Li
2021-01-07  4:53   ` Alexander Bulekov
2021-01-08  2:49     ` Qiuhao Li
2020-12-29  4:40 ` [PATCH v4 5/7] fuzz: set bits in operand of write/out to zero Qiuhao Li
2021-01-07  5:08   ` Alexander Bulekov
2020-12-29  4:40 ` [PATCH v4 6/7] fuzz: add minimization options Qiuhao Li
2021-01-07  5:54   ` Alexander Bulekov
2020-12-29  4:40 ` Qiuhao Li [this message]
2021-01-08  4:30   ` [PATCH v4 7/7] fuzz: heuristic split write based on past IOs Alexander Bulekov
2021-01-05  8:00 ` Ping: [PATCH v4 0/7] fuzz: improve crash case minimization Qiuhao Li
2021-01-08  4:32 ` Alexander Bulekov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ME3P282MB174588DE27F32E918F71DA1BFCD80@ME3P282MB1745.AUSP282.PROD.OUTLOOK.COM \
    --to=qiuhao.li@outlook.com \
    --cc=alxndr@bu.edu \
    --cc=bsd@redhat.com \
    --cc=darren.kenny@oracle.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.