From: Rahul Tanwar <rtanwar@maxlinear.com>
To: Arnd Bergmann <arnd@kernel.org>, Pavel Machek <pavel@ucw.cz>
Cc: Dan Murphy <dmurphy@ti.com>,
"linux-leds@vger.kernel.org" <linux-leds@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Cheol Yong Kim <ckim@maxlinear.com>,
Qiming Wu <qwu@maxlinear.com>
Subject: Re: [PATCH] leds: lgm: fix gpiolib dependency
Date: Tue, 16 Mar 2021 08:56:53 +0000 [thread overview]
Message-ID: <MN2PR19MB3693DDA96346488BF0A422D3B16B9@MN2PR19MB3693.namprd19.prod.outlook.com> (raw)
In-Reply-To: MN2PR19MB36933AFDC4531D0F7A984608B16C9@MN2PR19MB3693.namprd19.prod.outlook.com
On 15/3/2021 5:44 pm, Rahul Tanwar wrote:
> From: Arnd Bergmann<arnd@kernel.org>
> To: Pavel Machek<pavel@ucw.cz>,
> Amireddy Mallikarjuna reddy
> <mallikarjunax.reddy@linux.intel.com>
> Cc: Arnd Bergmann<arnd@arndb.de>, Dan Murphy<dmurphy@ti.com>,
> linux-leds@vger.kernel.org,linux-kernel@vger.kernel.org
> Subject:[PATCH] leds: lgm: fix gpiolib dependency <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#r>
> Date: Mon, 8 Mar 2021 16:30:46 +0100
> Message-ID:<20210308153052.2353885-1-arnd@kernel.org> (raw <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/raw>)
>
> From: Arnd Bergmann<arnd@arndb.de>
>
> Without gpiolib, the driver fails to build:
>
> drivers/leds/blink/leds-lgm-sso.c:123:19: error: field has incomplete type 'struct gpio_chip'
> struct gpio_chip chip;
> ^
> include/linux/gpio.h:107:8: note: forward declaration of 'struct gpio_chip'
> struct gpio_chip;
> ^
> drivers/leds/blink/leds-lgm-sso.c:263:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
> gpiod_set_value(led->gpiod, val);
> ^
> drivers/leds/blink/leds-lgm-sso.c:263:3: note: did you mean 'gpio_set_value'?
> include/linux/gpio.h:168:20: note: 'gpio_set_value' declared here
> static inline void gpio_set_value(unsigned gpio, int value)
> ^
> drivers/leds/blink/leds-lgm-sso.c:345:3: error: implicit declaration of function 'gpiod_set_value' [-Werror,-Wimplicit-function-declaration]
> gpiod_set_value(led->gpiod, 1);
> ^
>
> Add the dependency in Kconfig.
>
> Fixes: c3987cd2bca3 ("leds: lgm: Add LED controller driver for LGM SoC")
> Signed-off-by: Arnd Bergmann<arnd@arndb.de>
> ---
> drivers/leds/blink/Kconfig <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#Z30drivers:leds:blink:Kconfig> | 1 +
> 1 file changed, 1 insertion(+)
>
> diff
> <https://lore.kernel.org/lkml/20210308153052.2353885-1-arnd@kernel.org/#iZ30drivers:leds:blink:Kconfig>
> --git a/drivers/leds/blink/Kconfig b/drivers/leds/blink/Kconfig index
> 265b53476a80..6dedc58c47b3 100644 --- a/drivers/leds/blink/Kconfig +++
> b/drivers/leds/blink/Kconfig @@ -9,6 +9,7 @@ if LEDS_BLINK
> config LEDS_BLINK_LGM
> tristate "LED support for Intel LGM SoC series"
> + depends on GPIOLIB depends on LEDS_CLASS
> depends on MFD_SYSCON
> depends on OF
> --
> 2.29.2
>
Acked-by: Rahul Tanwar <rtanwar@maxlinear.com>
next prev parent reply other threads:[~2021-03-16 8:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <MN2PR19MB36933AFDC4531D0F7A984608B16C9@MN2PR19MB3693.namprd19.prod.outlook.com>
[not found] ` <MN2PR19MB3693FBBD3E6DB8A916260D69B16C9@MN2PR19MB3693.namprd19.prod.outlook.com>
2021-03-15 11:12 ` [PATCH] leds: lgm: fix gpiolib dependency Pavel Machek
2021-03-16 8:49 ` TEST EMAIL - PLEASE IGNORE Rahul Tanwar
2021-03-16 8:56 ` Rahul Tanwar [this message]
2021-03-08 15:30 [PATCH] leds: lgm: fix gpiolib dependency Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN2PR19MB3693DDA96346488BF0A422D3B16B9@MN2PR19MB3693.namprd19.prod.outlook.com \
--to=rtanwar@maxlinear.com \
--cc=arnd@kernel.org \
--cc=ckim@maxlinear.com \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=qwu@maxlinear.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.