Hi Jones,

> "Lee Jones" <lee.jones@linaro.org>
> 2019/05/07 ÏÂÎç 08:58
>
> To
>
> "Marek Vasut" <marek.vasut@gmail.com>,
>
> cc
>
> "Rob Herring" <robh@kernel.org>, "Mason Yang"
> <masonccyang@mxic.com.tw>, broonie@kernel.org, linux-
> kernel@vger.kernel.org, linux-spi@vger.kernel.org,
> bbrezillon@kernel.org, linux-renesas-soc@vger.kernel.org, "Geert
> Uytterhoeven" <geert+renesas@glider.be>,
> sergei.shtylyov@cogentembedded.com, mark.rutland@arm.com,
> devicetree@vger.kernel.org, juliensu@mxic.com.tw, "Simon Horman"
> <horms@verge.net.au>, zhengxunli@mxic.com.tw
>
> Subject
>
> Re: [PATCH v12 3/3] dt-bindings: mfd: Document Renesas R-Car Gen3
> RPC-IF MFD bindings
>
> On Wed, 24 Apr 2019, Marek Vasut wrote:
>
> > On 4/24/19 11:23 PM, Rob Herring wrote:
> > > On Wed, Apr 24, 2019 at 03:55:36PM +0800, Mason Yang wrote:
> > >> Document the bindings used by the Renesas R-Car Gen3 RPC-IF MFD.
> > >>
> > >> Signed-off-by: Mason Yang <masonccyang@mxic.com.tw>
> > >> ---
> > >>  .../devicetree/bindings/mfd/mfd-renesas-rpc.txt    | 40 ++++++
> ++++++++++++++++
> > >>  1 file changed, 40 insertions(+)
> > >>  create mode 100644 Documentation/devicetree/bindings/mfd/mfd-
> renesas-rpc.txt
> > >>
> > >> diff --git a/Documentation/devicetree/bindings/mfd/mfd-renesas-
> rpc.txt b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt
> > >> new file mode 100644
> > >> index 0000000..668b822
> > >> --- /dev/null
> > >> +++ b/Documentation/devicetree/bindings/mfd/mfd-renesas-rpc.txt
> > >> @@ -0,0 +1,40 @@
> > >> +Renesas R-Car Gen3 RPC-IF MFD Device Tree Bindings
> > >> +--------------------------------------------------
> > >
> > > Looks like a SPI flash controller from the example. What makes it an
> > > MFD?
> >
> > It supports both SPI NOR and HyperFlash (CFI-compliant flash with
> > different bus interface).
>
> Looks like you're registering one OR the other.
>
> Why don't you just do this from DT?
>
> No reason for this to be an MFD IMHO.


okay, I will patch it back to SPI mode only.

Hi Mark,
I will rebase onto previous patches as bellow:

On 2/12/19 3:22 PM, Mark Brown wrote:
> The patch
>
>    spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver
>
> has been applied to the spi tree at
>
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git
>
> All being well this means that it will be integrated into the linux-next
> tree (usually sometime in the next 24 hours) and sent to Linus during
> the next merge window (or sooner if it is a bug fix), however if
> problems are discovered then the patch may be dropped or reverted.  
>
> You may get further e-mails resulting from automated or manual testing
> and review of the tree, please engage with people reporting problems and
> send followup patches addressing any issues that are reported if needed.
>
> If any updates are required or you are submitting further changes they
> should be sent as incremental updates against current git, existing
> patches will not be replaced.
>
> Please add any relevant lists and maintainers to the CCs when replying
> to this mail.

How did that happen when there were still comments and open topics ?

--
Best regards,
Marek Vasut


Hi Marek,
Agreed it ? or have other opinion ?


>
> --
> Lee Jones [ÀîÇí˹]
> Linaro Services Technical Lead
> Linaro.org ©¦ Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog

thanks & best regards,
Mason

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================