From: Wolfgang Wallner <wolfgang.wallner@br-automation.com>
To: u-boot@lists.denx.de
Subject: Antwort: [PATCH v2 25/39] acpi: Put table-setup code in its own function
Date: Wed, 11 Mar 2020 15:33:15 +0100 [thread overview]
Message-ID: <OF16A124A8.0B20308C-ONC1258528.004C5669-C1258528.004FF2DD@br-automation.com> (raw)
In-Reply-To: <20200308214442.v2.25.I34e9fcd28119cc2fcb87ad8679efb582a4c611df@changeid>
Hi Simon,
-----"Simon Glass" <sjg@chromium.org> schrieb: -----
>
> We always write three basic tables to ACPI at the start. Move this into
> its own function, along with acpi_fill_header(), so we can write a test
> for this code.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> ---
>
> Changes in v2: None
>
> arch/x86/lib/acpi_table.c | 77 +----------------------------------
> include/acpi_table.h | 10 +++++
> lib/acpi/acpi_table.c | 86 ++++++++++++++++++++++++++++++++++++++-
> test/dm/acpi.c | 55 ++++++++++++++++++++++++-
> 4 files changed, 148 insertions(+), 80 deletions(-)
>
> diff --git a/arch/x86/lib/acpi_table.c b/arch/x86/lib/acpi_table.c
> index 9168119547..83b92e2a4c 100644
> --- a/arch/x86/lib/acpi_table.c
> +++ b/arch/x86/lib/acpi_table.c
> @@ -31,58 +31,6 @@ extern const unsigned char AmlCode[];
> /* ACPI RSDP address to be used in boot parameters */
> static ulong acpi_rsdp_addr;
>
> -static void acpi_write_rsdp(struct acpi_rsdp *rsdp, struct acpi_rsdt *rsdt,
> - struct acpi_xsdt *xsdt)
> -{
> - memset(rsdp, 0, sizeof(struct acpi_rsdp));
> -
> - memcpy(rsdp->signature, RSDP_SIG, 8);
> - memcpy(rsdp->oem_id, OEM_ID, 6);
> -
> - rsdp->length = sizeof(struct acpi_rsdp);
> - rsdp->rsdt_address = (u32)rsdt;
> -
> - rsdp->xsdt_address = (u64)(u32)xsdt;
> - rsdp->revision = ACPI_RSDP_REV_ACPI_2_0;
> -
> - /* Calculate checksums */
> - rsdp->checksum = table_compute_checksum((void *)rsdp, 20);
> - rsdp->ext_checksum = table_compute_checksum((void *)rsdp,
> - sizeof(struct acpi_rsdp));
> -}
> -
> -static void acpi_write_rsdt(struct acpi_rsdt *rsdt)
> -{
> - struct acpi_table_header *header = &(rsdt->header);
> -
> - /* Fill out header fields */
> - acpi_fill_header(header, "RSDT");
> - header->length = sizeof(struct acpi_rsdt);
> - header->revision = 1;
> -
> - /* Entries are filled in later, we come with an empty set */
> -
> - /* Fix checksum */
> - header->checksum = table_compute_checksum((void *)rsdt,
> - sizeof(struct acpi_rsdt));
> -}
> -
> -static void acpi_write_xsdt(struct acpi_xsdt *xsdt)
> -{
> - struct acpi_table_header *header = &(xsdt->header);
> -
> - /* Fill out header fields */
> - acpi_fill_header(header, "XSDT");
> - header->length = sizeof(struct acpi_xsdt);
> - header->revision = 1;
> -
> - /* Entries are filled in later, we come with an empty set */
> -
> - /* Fix checksum */
> - header->checksum = table_compute_checksum((void *)xsdt,
> - sizeof(struct acpi_xsdt));
> -}
> -
> static void acpi_create_facs(struct acpi_facs *facs)
> {
> memset((void *)facs, 0, sizeof(struct acpi_facs));
> @@ -402,7 +350,6 @@ static void acpi_create_spcr(struct acpi_spcr *spcr)
> ulong write_acpi_tables(ulong start_addr)
> {
> struct acpi_ctx sctx, *ctx = &sctx;
> - struct acpi_xsdt *xsdt;
> struct acpi_facs *facs;
> struct acpi_table_header *dsdt;
> struct acpi_fadt *fadt;
> @@ -415,32 +362,10 @@ ulong write_acpi_tables(ulong start_addr)
> int i;
>
> start = map_sysmem(start_addr, 0);
> - ctx->current = start;
> -
> - /* Align ACPI tables to 16 byte */
> - acpi_align(ctx);
>
> debug("ACPI: Writing ACPI tables at %lx\n", start_addr);
>
> - /* We need at least an RSDP and an RSDT Table */
> - ctx->rsdp = ctx->current;
> - acpi_inc_align(ctx, sizeof(struct acpi_rsdp));
> - ctx->rsdt = ctx->current;
> - acpi_inc_align(ctx, sizeof(struct acpi_rsdt));
> - xsdt = ctx->current;
> - acpi_inc_align(ctx, sizeof(struct acpi_xsdt));
> - /*
> - * Per ACPI spec, the FACS table address must be aligned to a 64 byte
> - * boundary (Windows checks this, but Linux does not).
> - */
> - acpi_align_large(ctx);
> -
> - /* clear all table memory */
> - memset((void *)start, 0, ctx->current - start);
> -
> - acpi_write_rsdp(ctx->rsdp, ctx->rsdt, xsdt);
> - acpi_write_rsdt(ctx->rsdt);
> - acpi_write_xsdt(xsdt);
> + acpi_setup_base_tables(ctx, start);
>
> debug("ACPI: * FACS\n");
> facs = ctx->current;
> diff --git a/include/acpi_table.h b/include/acpi_table.h
> index 2131484880..f500f0d3fe 100644
> --- a/include/acpi_table.h
> +++ b/include/acpi_table.h
> @@ -564,6 +564,16 @@ void acpi_inc_align(struct acpi_ctx *ctx, uint amount);
> */
> int acpi_add_table(struct acpi_ctx *ctx, void *table);
>
> +/**
> + * acpi_setup_base_tables() - Set up context along with RSDP, RSDT and XDST
typo: XSDT
> + *
> + * Set up the context with the given start position. Some basic tables are
> + * always needed, so set them up as well.
> + *
> + * @ctx: Context to set up
> + */
> +void acpi_setup_base_tables(struct acpi_ctx *ctx, void *start);
> +
> #endif /* !__ACPI__*/
>
> #include <asm/acpi_table.h>
> diff --git a/lib/acpi/acpi_table.c b/lib/acpi/acpi_table.c
> index 00e80ac39a..9f452a65ce 100644
> --- a/lib/acpi/acpi_table.c
> +++ b/lib/acpi/acpi_table.c
> @@ -157,7 +157,7 @@ int acpi_add_table(struct acpi_ctx *ctx, void *table)
>
> /* Re-calculate checksum */
> rsdt->header.checksum = 0;
> - rsdt->header.checksum = table_compute_checksum((u8 *)rsdt,
> + rsdt->header.checksum = table_compute_checksum(rsdt,
> rsdt->header.length);
>
> /*
> @@ -175,8 +175,90 @@ int acpi_add_table(struct acpi_ctx *ctx, void *table)
> /* Re-calculate checksum */
> xsdt->header.checksum = 0;
> xsdt->header.checksum =
> - table_compute_checksum((u8 *)xsdt, xsdt->header.length);
> + table_compute_checksum(xsdt, xsdt->header.length);
> }
>
> return 0;
> }
> +
> +static void acpi_write_rsdp(struct acpi_rsdp *rsdp, struct acpi_rsdt *rsdt,
> + struct acpi_xsdt *xsdt)
> +{
> + memset(rsdp, 0, sizeof(struct acpi_rsdp));
> +
> + memcpy(rsdp->signature, RSDP_SIG, 8);
> + memcpy(rsdp->oem_id, OEM_ID, 6);
> +
> + rsdp->length = sizeof(struct acpi_rsdp);
> + rsdp->rsdt_address = map_to_sysmem(rsdt);
> +
> + rsdp->xsdt_address = map_to_sysmem(xsdt);
> + rsdp->revision = ACPI_RSDP_REV_ACPI_2_0;
> +
> + /* Calculate checksums */
> + rsdp->checksum = table_compute_checksum(rsdp, 20);
> + rsdp->ext_checksum = table_compute_checksum(rsdp,
> + sizeof(struct acpi_rsdp));
> +}
> +
> +static void acpi_write_rsdt(struct acpi_rsdt *rsdt)
> +{
> + struct acpi_table_header *header = &rsdt->header;
> +
> + /* Fill out header fields */
> + acpi_fill_header(header, "RSDT");
> + header->length = sizeof(struct acpi_rsdt);
> + header->revision = 1;
> +
> + /* Entries are filled in later, we come with an empty set */
> +
> + /* Fix checksum */
> + header->checksum = table_compute_checksum(rsdt,
> + sizeof(struct acpi_rsdt));
> +}
> +
> +static void acpi_write_xsdt(struct acpi_xsdt *xsdt)
> +{
> + struct acpi_table_header *header = &xsdt->header;
> +
> + /* Fill out header fields */
> + acpi_fill_header(header, "XSDT");
> + header->length = sizeof(struct acpi_xsdt);
> + header->revision = 1;
> +
> + /* Entries are filled in later, we come with an empty set */
> +
> + /* Fix checksum */
> + header->checksum = table_compute_checksum(xsdt,
> + sizeof(struct acpi_xsdt));
> +}
> +
> +void acpi_setup_base_tables(struct acpi_ctx *ctx, void *start)
> +{
> + struct acpi_xsdt *xsdt;
> +
> + ctx->current = start;
> +
> + /* Align ACPI tables to 16 byte */
> + acpi_align(ctx);
> +
> + /* We need at least an RSDP and an RSDT Table */
> + ctx->rsdp = ctx->current;
> + acpi_inc_align(ctx, sizeof(struct acpi_rsdp));
> + ctx->rsdt = ctx->current;
> + acpi_inc_align(ctx, sizeof(struct acpi_rsdt));
> + xsdt = ctx->current;
> + acpi_inc_align(ctx, sizeof(struct acpi_xsdt));
> + /*
> + * Per ACPI spec, the FACS table address must be aligned to a 64 byte
> + * boundary (Windows checks this, but Linux does not).
> + */
> + acpi_align_large(ctx);
Having this call inside of acpi_setup_base_tables() creates the requirement
that the FACS is set up directly after the base tables. With the current
code this is satisfied, but it might be overlooked by future refactoring.
Maybe move this call out directly in front of the setup of FACS?
> +
> + /* clear all table memory */
> + memset((void *)start, '\0', ctx->current - start);
> +
> + acpi_write_rsdp(ctx->rsdp, ctx->rsdt, xsdt);
> + acpi_write_rsdt(ctx->rsdt);
> + acpi_write_xsdt(xsdt);
> +}
> diff --git a/test/dm/acpi.c b/test/dm/acpi.c
> index a2a57a29a6..bb66c7229c 100644
> --- a/test/dm/acpi.c
> +++ b/test/dm/acpi.c
> @@ -9,6 +9,9 @@
> #include <common.h>
> #include <acpi_table.h>
> #include <dm.h>
> +#include <malloc.h>
> +#include <mapmem.h>
> +#include <tables_csum.h>
> #include <version.h>
> #include <dm/acpi.h>
> #include <dm/test.h>
> @@ -138,9 +141,9 @@ static int dm_test_acpi_write_tables(struct unit_test_state *uts)
> buf = malloc(BUF_SIZE);
> ut_assertnonnull(buf);
>
> - ctx.current = buf;
> + acpi_setup_base_tables(&ctx, buf);
> + dmar = ctx.current;
> ut_assertok(acpi_write_dev_tables(&ctx));
> - dmar = buf;
>
> /*
> * We should have two dmar tables, one for each "denx,u-boot-acpi-test"
> @@ -153,6 +156,11 @@ static int dm_test_acpi_write_tables(struct unit_test_state *uts)
> ut_asserteq(DMAR_INTR_REMAP, dmar[1].flags);
> ut_asserteq(32 - 1, dmar[1].host_address_width);
>
> + /* Check that the pointers were added correctly */
> + ut_asserteq(map_to_sysmem(dmar), ctx.rsdt->entry[0]);
> + ut_asserteq(map_to_sysmem(dmar + 1), ctx.rsdt->entry[1]);
> + ut_asserteq(0, ctx.rsdt->entry[2]);
> +
> return 0;
> }
> DM_TEST(dm_test_acpi_write_tables, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
> @@ -184,3 +192,46 @@ static int dm_test_acpi_basic(struct unit_test_state *uts)
> return 0;
> }
> DM_TEST(dm_test_acpi_basic, DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
> +
> +/* Test acpi_setup_base_tables */
> +static int dm_test_acpi_setup_base_tables(struct unit_test_state *uts)
> +{
> + struct acpi_rsdp *rsdp;
> + struct acpi_rsdt *rsdt;
> + struct acpi_xsdt *xsdt;
> + struct acpi_ctx ctx;
> + void *buf, *end;
> +
> + /* Use an unaligned address deliberately */
> + buf = memalign(64, BUF_SIZE);
Maybe I'm missing something, but as far as I understand it, the comment
contradicts the code (aligning to 64 bytes makes it an aligned address,
doesn't it?).
> + ut_assertnonnull(buf);
> + acpi_setup_base_tables(&ctx, buf + 4);
> +
> + rsdp = buf + 16;
> + ut_asserteq_ptr(rsdp, ctx.rsdp);
> + ut_assertok(memcmp(RSDP_SIG, rsdp->signature, sizeof(rsdp->signature)));
> + ut_asserteq(sizeof(*rsdp), rsdp->length);
> + ut_assertok(table_compute_checksum(rsdp, 20));
> + ut_assertok(table_compute_checksum(rsdp, sizeof(*rsdp)));
> +
> + rsdt = PTR_ALIGN((void *)rsdp + sizeof(*rsdp), 16);
> + ut_asserteq_ptr(rsdt, ctx.rsdt);
> + ut_assertok(memcmp("RSDT", rsdt->header.signature, ACPI_NAME_LEN));
> + ut_asserteq(sizeof(*rsdt), rsdt->header.length);
> + ut_assertok(table_compute_checksum(rsdt, sizeof(*rsdt)));
> +
> + xsdt = PTR_ALIGN((void *)rsdt + sizeof(*rsdt), 16);
> + ut_assertok(memcmp("XSDT", xsdt->header.signature, ACPI_NAME_LEN));
> + ut_asserteq(sizeof(*xsdt), xsdt->header.length);
> + ut_assertok(table_compute_checksum(xsdt, sizeof(*xsdt)));
> +
> + end = PTR_ALIGN((void *)xsdt + sizeof(*xsdt), 64);
> + ut_asserteq_ptr(end, ctx.current);
> +
> + ut_asserteq(map_to_sysmem(rsdt), rsdp->rsdt_address);
> + ut_asserteq(map_to_sysmem(xsdt), rsdp->xsdt_address);
> +
> + return 0;
> +}
> +DM_TEST(dm_test_acpi_setup_base_tables,
> + DM_TESTF_SCAN_PDATA | DM_TESTF_SCAN_FDT);
> --
> 2.25.1.481.gfbce0eb801-goog
regards, Wolfgang
next prev parent reply other threads:[~2020-03-11 14:33 UTC|newest]
Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 3:44 [PATCH v2 00/39] dm: Add programmatic generation of ACPI tables (part A) Simon Glass
2020-03-09 3:44 ` [PATCH v2 01/39] cpu: Support querying the address width Simon Glass
2020-03-09 3:44 ` [PATCH v2 02/39] spi: Add SPI mode enums Simon Glass
2020-03-09 7:41 ` Andy Shevchenko
2020-03-09 3:44 ` [PATCH v2 03/39] tpm: cr50: Release locality on exit Simon Glass
2020-03-09 3:44 ` [PATCH v2 04/39] tpm: cr50: Add a comment for cr50_priv Simon Glass
2020-03-09 3:44 ` [PATCH v2 05/39] tpm: cr50: Use the correct GPIO binding Simon Glass
2020-03-09 3:44 ` [PATCH v2 06/39] tpm: Don't cleanup unless an error happens Simon Glass
2020-03-09 3:44 ` [PATCH v2 07/39] dm: pci: Allow disabling auto-config for a device Simon Glass
2020-03-09 7:43 ` Andy Shevchenko
2020-03-09 3:44 ` [PATCH v2 08/39] x86: Correct wording of coreboot source code Simon Glass
2020-03-09 7:44 ` Andy Shevchenko
2020-03-10 23:22 ` Simon Glass
2020-03-09 3:44 ` [PATCH v2 09/39] x86: apl: Move p2sb ofdata reading to the correct method Simon Glass
2020-03-10 14:39 ` Andy Shevchenko
2020-03-11 12:17 ` Simon Glass
2020-03-11 13:06 ` Andy Shevchenko
2020-03-09 3:44 ` [PATCH v2 10/39] pci: Adjust dm_pci_read_bar32() to return errors correctly Simon Glass
2020-03-09 3:44 ` [PATCH v2 11/39] x86: apl: Add Global NVS table header Simon Glass
2020-03-09 3:44 ` [PATCH v2 12/39] dm: core: Add basic ACPI support Simon Glass
2020-03-10 14:46 ` Andy Shevchenko
2020-03-11 12:17 ` Simon Glass
2020-03-09 3:44 ` [PATCH v2 13/39] acpi: Add a binding for ACPI settings in the device tree Simon Glass
2020-03-10 14:50 ` Andy Shevchenko
2020-03-12 3:22 ` Simon Glass
2020-03-09 3:44 ` [PATCH v2 14/39] acpi: Add a simple sandbox test Simon Glass
2020-03-09 3:44 ` [PATCH v2 15/39] x86: Move acpi_table header to main include/ directory Simon Glass
2020-03-09 3:44 ` [PATCH v2 16/39] acpi: Add an __ACPI__ preprocessor symbol Simon Glass
2020-03-09 3:44 ` [PATCH v2 17/39] acpi: Add a central location for table version numbers Simon Glass
2020-03-09 3:44 ` [PATCH v2 18/39] acpi: Add support for DMAR Simon Glass
2020-03-09 3:44 ` [PATCH v2 19/39] acpi: Move acpi_fill_header() to generic code Simon Glass
2020-03-09 3:44 ` [PATCH v2 20/39] acpi: Add a method to write tables for a device Simon Glass
2020-03-09 3:44 ` [PATCH v2 21/39] acpi: Convert part of acpi_table to use acpi_ctx Simon Glass
2020-03-09 3:44 ` [PATCH v2 22/39] x86: Allow devices to write ACPI tables Simon Glass
2020-03-09 3:44 ` [PATCH v2 23/39] acpi: Drop code for missing XSDT from acpi_write_rsdp() Simon Glass
2020-03-09 3:44 ` [PATCH v2 24/39] acpi: Move acpi_add_table() to generic code Simon Glass
2020-03-09 3:44 ` [PATCH v2 25/39] acpi: Put table-setup code in its own function Simon Glass
2020-03-09 3:44 ` [PATCH v2 26/39] acpi: Move the xsdt pointer to acpi_ctx Simon Glass
2020-03-09 3:44 ` [PATCH v2 27/39] acpi: Add an acpi command Simon Glass
2020-03-09 3:44 ` [PATCH v2 28/39] acpi: Add some tables required by the generation code Simon Glass
2020-03-09 3:44 ` [PATCH v2 29/39] acpi: Add generation code for devices Simon Glass
2020-03-09 3:44 ` [PATCH v2 30/39] acpi: Add functions to generate ACPI code Simon Glass
2020-03-09 3:44 ` [PATCH v2 31/39] gpio: Add a method to convert a GPIO to ACPI Simon Glass
2020-03-09 3:44 ` [PATCH v2 32/39] irq: Add a method to convert an interrupt " Simon Glass
2020-03-18 16:17 ` Antwort: " Wolfgang Wallner
2020-03-18 16:20 ` Wolfgang Wallner
2020-03-19 16:18 ` Simon Glass
2020-03-09 3:44 ` [PATCH v2 33/39] acpi: Add support for SSDT generation Simon Glass
2020-03-18 16:48 ` Antwort: " Wolfgang Wallner
2020-03-19 7:39 ` Wolfgang Wallner
2020-03-09 3:44 ` [PATCH v2 34/39] x86: acpi: Move MADT up a bit Simon Glass
2020-03-09 3:44 ` [PATCH v2 35/39] acpi: Record the items added to SSDT Simon Glass
2020-03-09 3:45 ` [PATCH v2 36/39] acpi: Support ordering SSDT data by device Simon Glass
2020-03-09 3:45 ` [PATCH v2 37/39] x86: Allow devices to write an SSDT Simon Glass
2020-03-09 3:45 ` [PATCH v2 38/39] acpi: Add support for DSDT generation Simon Glass
2020-03-09 3:45 ` [PATCH v2 39/39] x86: Allow devices to write to DSDT Simon Glass
2020-03-09 7:38 ` Antwort: [PATCH v2 02/39] spi: Add SPI mode enums Wolfgang Wallner
2020-03-09 7:38 ` Antwort: [PATCH v2 08/39] x86: Correct wording of coreboot source code Wolfgang Wallner
2020-03-09 7:38 ` Antwort: [PATCH v2 10/39] pci: Adjust dm_pci_read_bar32() to return errors correctly Wolfgang Wallner
2020-03-09 7:38 ` Antwort: [PATCH v2 11/39] x86: apl: Add Global NVS table header Wolfgang Wallner
2020-03-09 9:07 ` Antwort: [PATCH v2 12/39] dm: core: Add basic ACPI support Wolfgang Wallner
2020-03-10 9:15 ` Antwort: [PATCH v2 13/39] acpi: Add a binding for ACPI settings in the device tree Wolfgang Wallner
2020-03-12 3:24 ` Simon Glass
2020-03-12 12:44 ` Antwort: " Wolfgang Wallner
2020-03-13 0:36 ` Simon Glass
2020-03-10 9:16 ` Antwort: [PATCH v2 15/39] x86: Move acpi_table header to main include/ directory Wolfgang Wallner
2020-03-10 9:17 ` Antwort: [PATCH v2 16/39] acpi: Add an __ACPI__ preprocessor symbol Wolfgang Wallner
2020-03-10 9:26 ` Antwort: [PATCH v2 17/39] acpi: Add a central location for table version numbers Wolfgang Wallner
2020-03-12 3:22 ` Simon Glass
2020-03-10 12:32 ` Antwort: [PATCH v2 18/39] acpi: Add support for DMAR Wolfgang Wallner
2020-03-10 12:33 ` Antwort: [PATCH v2 19/39] acpi: Move acpi_fill_header() to generic code Wolfgang Wallner
2020-03-10 12:53 ` Antwort: [PATCH v2 14/39] acpi: Add a simple sandbox test Wolfgang Wallner
2020-03-11 9:04 ` Antwort: [PATCH v2 19/39] acpi: Move acpi_fill_header() to generic code Wolfgang Wallner
2020-03-11 11:36 ` Antwort: [PATCH v2 20/39] acpi: Add a method to write tables for a device Wolfgang Wallner
2020-03-11 11:37 ` Antwort: [PATCH v2 22/39] x86: Allow devices to write ACPI tables Wolfgang Wallner
2020-03-11 12:58 ` Antwort: [PATCH v2 21/39] acpi: Convert part of acpi_table to use acpi_ctx Wolfgang Wallner
2020-03-12 3:23 ` Simon Glass
2020-03-12 13:03 ` Antwort: " Wolfgang Wallner
2020-03-11 13:43 ` Antwort: [PATCH v2 24/39] acpi: Move acpi_add_table() to generic code Wolfgang Wallner
2020-03-11 14:33 ` Wolfgang Wallner [this message]
2020-03-11 14:34 ` Antwort: [PATCH v2 23/39] acpi: Drop code for missing XSDT from acpi_write_rsdp() Wolfgang Wallner
2020-03-11 14:57 ` Antwort: [PATCH v2 26/39] acpi: Move the xsdt pointer to acpi_ctx Wolfgang Wallner
2020-03-12 14:30 ` Antwort: [PATCH v2 27/39] acpi: Add an acpi command Wolfgang Wallner
2020-03-13 9:55 ` Antwort: [PATCH v2 30/39] acpi: Add functions to generate ACPI code Wolfgang Wallner
2020-03-14 20:34 ` Simon Glass
2020-03-13 11:16 ` Antwort: [PATCH v2 31/39] gpio: Add a method to convert a GPIO to ACPI Wolfgang Wallner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=OF16A124A8.0B20308C-ONC1258528.004C5669-C1258528.004FF2DD@br-automation.com \
--to=wolfgang.wallner@br-automation.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.