From: Linus Torvalds <torvalds@linux-foundation.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Don Zickus <dzickus@gmail.com>, Git Mailing List <git@vger.kernel.org>
Subject: Re: Fix "git log -z" behaviour
Date: Sat, 10 Feb 2007 09:09:44 -0800 (PST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702100902250.8424@woody.linux-foundation.org> (raw)
In-Reply-To: <7vlkj6mk0q.fsf@assigned-by-dhcp.cox.net>
On Sat, 10 Feb 2007, Junio C Hamano wrote:
>
> ... well, it just occured to me that it might make sense not to
> let this new "use NUL as inter-commit separator for grep -z"
> semantics hijack existing -z option, but introduce another
> option, say, -Z.
I don't think I disagree, but I do suspect it's not worth it.
Yes, we really do have two "line_termination" characters: the one between
commits, and the one we use within raw diffs. However, I don't think the
*combination* ever makes sense any more (*), so using the same flag
doesn't seem to really be a problem.
And the -z "line_termination" already got hijacked a long time ago for
inter-commit messages too, so while adding a "-Z" would perhaps avoid a
certain ambiguity, it would actually potentially break stuff that just did
git-rev-list -z --pretty .. | ...
which is actually _more_ likely than the "multiple commit messages _and_
raw outpu _and_ '-z'" combination.
So I would suggest leaving it as-is, especially since I don't think
anybody has actually even noticed (ie nobody probably used that
combination), and the new semantics in many ways are both more useful and
more logical.
Linus
(*) It may well have made sense a year and a half ago, I don't think it
makes much sense any more.
next prev parent reply other threads:[~2007-02-10 17:09 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-07 16:41 git log filtering Don Zickus
2007-02-07 16:55 ` Jakub Narebski
2007-02-07 17:01 ` Uwe Kleine-König
2007-02-07 17:12 ` Johannes Schindelin
2007-02-07 17:12 ` Linus Torvalds
2007-02-07 17:25 ` Johannes Schindelin
[not found] ` <7v64ad7l12.fsf@assigned-by-dhcp.cox.net>
2007-02-07 21:03 ` Linus Torvalds
2007-02-07 21:09 ` Junio C Hamano
2007-02-07 21:53 ` Linus Torvalds
2007-02-08 6:16 ` Jeff King
2007-02-08 18:06 ` Johannes Schindelin
2007-02-08 22:33 ` Jeff King
2007-02-09 0:18 ` Johannes Schindelin
2007-02-09 0:23 ` Shawn O. Pearce
2007-02-09 0:45 ` Johannes Schindelin
2007-02-09 10:15 ` Sergey Vlasov
2007-02-09 1:59 ` Jeff King
2007-02-09 13:13 ` Johannes Schindelin
2007-02-09 13:22 ` Jeff King
2007-02-09 15:02 ` Johannes Schindelin
2007-03-07 17:37 ` pcre performance, was " Johannes Schindelin
2007-03-07 18:03 ` Paolo Bonzini
2007-02-08 1:59 ` Horst H. von Brand
2007-02-07 18:16 ` Linus Torvalds
2007-02-07 19:49 ` Fix "git log -z" behaviour Linus Torvalds
2007-02-07 19:55 ` Junio C Hamano
2007-02-07 22:53 ` Don Zickus
2007-02-07 23:05 ` Linus Torvalds
2007-02-08 22:34 ` Junio C Hamano
2007-02-10 7:32 ` Junio C Hamano
2007-02-10 9:36 ` Junio C Hamano
2007-02-10 17:09 ` Linus Torvalds [this message]
2007-02-07 18:19 ` git log filtering Don Zickus
2007-02-07 18:27 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702100902250.8424@woody.linux-foundation.org \
--to=torvalds@linux-foundation.org \
--cc=dzickus@gmail.com \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.