From: Nicolas Pitre <nico@cam.org>
To: Junio C Hamano <junkio@cox.net>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Marco Costalba <mcostalba@gmail.com>,
GIT list <git@vger.kernel.org>
Subject: Re: 'git status' is not read-only fs friendly
Date: Sat, 10 Feb 2007 12:03:52 -0500 (EST) [thread overview]
Message-ID: <Pine.LNX.4.64.0702101154130.1757@xanadu.home> (raw)
In-Reply-To: <7vmz3mj6yo.fsf@assigned-by-dhcp.cox.net>
On Sat, 10 Feb 2007, Junio C Hamano wrote:
> Nicolas Pitre <nico@cam.org> writes:
>
> > On Sat, 10 Feb 2007, Junio C Hamano wrote:
> >
> >> Nicolas Pitre <nico@cam.org> writes:
> >> ...
> >> > Because git-status itself is conceptually a read-only operation, and
> >> > having it barf on a read-only file system is justifiably a bug.
> >>
> >> I do not 100% agree that it is conceptually a read-only operation.
> >
> > It is. It's the technical issue that makes it not so.
>
> I do not think so. It is a workflow issue that user indicates
> the cache cleanliness information does not matter anymore.
You're making assumption about work flows and using that to justify
command implementation flaws. This is not exactly "user friendly".
> Is it wrong for "git-status" to be losing the cache cleanliness
> information? The intended audience of that program is those who
> are about to make a commit in the repository, as they are asking
> "what would I be committing?" Up to that point, they may have
> cared about the reminder they get from "git diff" that they
> edited a file and then ended up reverting the whole edit they
> did to that file (I find that empty diff from "git diff" often
> very useful, although I felt "Huh?" when I was new to git).
> But when they ask "git status", they care more about the real
> change, and at that point (since they feel they may be ready to
> make a commit -- and that is the whole point of running
> "git-status") they do want to lose the cache cleanliness
> information.
I don't dispute that. But git-status should certainly not be restricted
_only_ to that usage pattern.
> So "git-status" to be read-write application to
> discard the cache-cleanliness information is probably a good
> thing.
It is... when the file system lets you write. Like I said this is a
technically good thing to do.
But a command that is called "status" should provide a "status" even if
the file system is read-only nevertheless. The index updating business
that is done behind the scene is and should be an opportunistic
optimization, but it should not prevent status reporting.
It is pretty expected that a "commit" command would fail if the file
system is ro, but not a "status" command. And this is true
irrespectively of whatever workflow you might be most likely to use the
"status" command for.
Nicolas
next prev parent reply other threads:[~2007-02-10 17:03 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 19:25 'git status' is not read-only fs friendly Marco Costalba
2007-02-09 19:56 ` Linus Torvalds
2007-02-09 20:19 ` Marco Costalba
2007-02-09 20:27 ` Junio C Hamano
2007-02-09 20:22 ` Junio C Hamano
2007-02-09 20:29 ` Morten Welinder
2007-02-09 23:27 ` Theodore Tso
2007-02-09 20:35 ` Marco Costalba
2007-02-09 20:59 ` Linus Torvalds
2007-02-10 0:12 ` Junio C Hamano
2007-02-10 0:16 ` Junio C Hamano
2007-02-10 2:51 ` [PATCH 1/2] run_diff_{files,index}(): update calling convention Junio C Hamano
2007-02-10 8:02 ` Marco Costalba
2007-02-10 8:20 ` Junio C Hamano
2007-02-10 8:29 ` Marco Costalba
2007-02-10 8:46 ` Marco Costalba
2007-02-10 10:40 ` Junio C Hamano
2007-02-10 11:25 ` Marco Costalba
2007-02-10 15:13 ` Junio C Hamano
2007-02-10 15:51 ` Marco Costalba
2007-02-10 2:51 ` [PATCH 2/2] git-runstatus --refresh Junio C Hamano
2007-02-10 14:19 ` 'git status' is not read-only fs friendly Johannes Schindelin
2007-02-10 14:31 ` Marco Costalba
2007-02-10 14:41 ` Johannes Schindelin
2007-02-10 14:48 ` Marco Costalba
2007-02-10 14:51 ` Marco Costalba
2007-02-10 16:25 ` Junio C Hamano
2007-02-10 20:36 ` Johannes Schindelin
2007-02-11 21:57 ` Junio C Hamano
2007-02-11 22:09 ` Johannes Schindelin
2007-02-11 22:28 ` Johannes Schindelin
2007-02-11 22:30 ` Junio C Hamano
2007-02-11 23:24 ` Johannes Schindelin
2007-02-10 14:59 ` Johannes Schindelin
2007-02-10 15:45 ` Marco Costalba
2007-02-10 15:54 ` Nicolas Pitre
2007-02-10 16:27 ` Junio C Hamano
2007-02-10 16:40 ` Nicolas Pitre
2007-02-10 16:46 ` Junio C Hamano
2007-02-10 17:03 ` Nicolas Pitre [this message]
2007-02-10 18:00 ` Junio C Hamano
2007-02-10 18:43 ` Theodore Tso
2007-02-10 18:53 ` Nicolas Pitre
2007-02-10 18:56 ` Theodore Tso
2007-02-10 19:08 ` Marco Costalba
2007-02-10 17:37 ` Linus Torvalds
2007-02-10 18:51 ` Nicolas Pitre
2007-02-11 6:33 ` Junio C Hamano
2007-02-11 7:23 ` Shawn O. Pearce
2007-02-10 20:40 ` Johannes Schindelin
2007-02-10 16:25 ` Junio C Hamano
2007-02-10 16:35 ` Marco Costalba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.64.0702101154130.1757@xanadu.home \
--to=nico@cam.org \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=junkio@cox.net \
--cc=mcostalba@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.