All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Kumar, M Chetan" <m.chetan.kumar@intel.com>
To: Jakub Kicinski <kuba@kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"edumazet@google.com" <edumazet@google.com>,
	"pabeni@redhat.com" <pabeni@redhat.com>,
	linuxwwan <linuxwwan@intel.com>,
	"loic.poulain@linaro.org" <loic.poulain@linaro.org>,
	"ryazanov.s.a@gmail.com" <ryazanov.s.a@gmail.com>,
	"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Subject: RE: [PATCH net-next] net: wwan: iosm: remove pointless null check
Date: Thu, 19 May 2022 07:12:47 +0000	[thread overview]
Message-ID: <SJ0PR11MB50087702603728A3BB01D33AD7D09@SJ0PR11MB5008.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20220519004342.2109832-1-kuba@kernel.org>

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Thursday, May 19, 2022 6:14 AM
> To: davem@davemloft.net
> Cc: netdev@vger.kernel.org; edumazet@google.com; pabeni@redhat.com;
> Jakub Kicinski <kuba@kernel.org>; Kumar, M Chetan
> <m.chetan.kumar@intel.com>; linuxwwan <linuxwwan@intel.com>;
> loic.poulain@linaro.org; ryazanov.s.a@gmail.com;
> johannes@sipsolutions.net
> Subject: [PATCH net-next] net: wwan: iosm: remove pointless null check
> 
> GCC 12 warns:
> 
> drivers/net/wwan/iosm/iosm_ipc_protocol_ops.c: In function
> ‘ipc_protocol_dl_td_process’:
> drivers/net/wwan/iosm/iosm_ipc_protocol_ops.c:406:13: warning: the
> comparison will always evaluate as ‘true’ for the address of ‘cb’ will never be
> NULL [-Waddress]
>   406 |         if (!IPC_CB(skb)) {
>       |             ^
> 
> Indeed the check seems entirely pointless. Hopefully the other validation
> checks will catch if the cb is bad, but it can't be NULL.

Reviewed-by: M Chetan Kumar <m.chetan.kumar@intel.com>

  reply	other threads:[~2022-05-19  7:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19  0:43 [PATCH net-next] net: wwan: iosm: remove pointless null check Jakub Kicinski
2022-05-19  7:12 ` Kumar, M Chetan [this message]
2022-05-20  1:50 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=SJ0PR11MB50087702603728A3BB01D33AD7D09@SJ0PR11MB5008.namprd11.prod.outlook.com \
    --to=m.chetan.kumar@intel.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=johannes@sipsolutions.net \
    --cc=kuba@kernel.org \
    --cc=linuxwwan@intel.com \
    --cc=loic.poulain@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=ryazanov.s.a@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.