From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752781AbdLUKdm (ORCPT ); Thu, 21 Dec 2017 05:33:42 -0500 Received: from relmlor2.renesas.com ([210.160.252.172]:45374 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752404AbdLUKdg (ORCPT ); Thu, 21 Dec 2017 05:33:36 -0500 X-IronPort-AV: E=Sophos;i="5.45,435,1508770800"; d="scan'208";a="267114992" From: Yoshihiro Shimoda To: Ulf Hansson , Kishon Vijay Abraham I , "linux-kernel@vger.kernel.org" CC: "Rafael J . Wysocki" , "linux-pm@vger.kernel.org" , Geert Uytterhoeven , "linux-renesas-soc@vger.kernel.org" Subject: RE: [PATCH v2 2/3] phy: core: Drop unused runtime PM APIs Thread-Topic: [PATCH v2 2/3] phy: core: Drop unused runtime PM APIs Thread-Index: AQHTeZwrYKRZEpp4TkO0mjsK5D3qCqNNmFeg Date: Thu, 21 Dec 2017 10:33:31 +0000 Message-ID: References: <1513778960-10073-1-git-send-email-ulf.hansson@linaro.org> <1513778960-10073-3-git-send-email-ulf.hansson@linaro.org> In-Reply-To: <1513778960-10073-3-git-send-email-ulf.hansson@linaro.org> Accept-Language: ja-JP, en-US Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=yoshihiro.shimoda.uh@renesas.com; x-originating-ip: [211.11.155.139] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;TY1PR06MB0989;20:9JoQP0qj85Pu8c2ksclewA6r9yPIptKLpkTB/Fy9prZEV3waium98swOzjCDgAQxIPSWneXiVEIjSqrgxMk+HwvpjTfSIrq0IETWPSQj032dKCP3Kh3ON0FCxzI+7Vpx95Gu8691XYRT2HumLWeRAfElaFdB5M2l3IoLgyk9dyc= x-ms-exchange-antispam-srfa-diagnostics: SSOS; x-ms-office365-filtering-ht: Tenant x-ms-office365-filtering-correlation-id: 9f7454c7-87df-4d13-4984-08d5485e482e x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(48565401081)(5600026)(4604075)(3008031)(4534020)(4602075)(4627115)(201703031133081)(201702281549075)(2017052603307)(7153060);SRVR:TY1PR06MB0989; x-ms-traffictypediagnostic: TY1PR06MB0989: x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040470)(2401047)(8121501046)(5005006)(3231023)(93006095)(93001095)(10201501046)(3002001)(6055026)(6041268)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(20161123564045)(20161123562045)(6072148)(201708071742011);SRVR:TY1PR06MB0989;BCL:0;PCL:0;RULEID:(100000803101)(100110400095);SRVR:TY1PR06MB0989; x-forefront-prvs: 0528942FD8 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(979002)(39860400002)(376002)(346002)(366004)(39380400002)(396003)(189003)(13464003)(199004)(54906003)(316002)(81156014)(97736004)(2501003)(2906002)(3660700001)(8676002)(76176011)(2900100001)(3280700002)(6436002)(8936002)(55016002)(6506007)(7696005)(81166006)(9686003)(68736007)(110136005)(229853002)(99286004)(25786009)(2950100002)(86362001)(7736002)(77096006)(53936002)(5660300001)(305945005)(74316002)(6246003)(66066001)(478600001)(3846002)(6116002)(33656002)(4326008)(106356001)(105586002)(14454004)(102836004)(969003)(989001)(999001)(1009001)(1019001);DIR:OUT;SFP:1102;SCL:1;SRVR:TY1PR06MB0989;H:TY1PR06MB0992.apcprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9f7454c7-87df-4d13-4984-08d5485e482e X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2017 10:33:31.5880 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: TY1PR06MB0989 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id vBLAXkri010376 Hi Ulf-san, > -----Original Message----- > From: Ulf Hansson, Sent: Wednesday, December 20, 2017 11:09 PM > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index b4298a1..050b620 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include After I applied this patch, some ata and gpu drivers causes build error [1]. So, we should fix the drivers at first... Best regards, Yoshihiro Shimoda --- [1] drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_resume': drivers/ata/ahci_qoriq.c:318:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration] pm_runtime_disable(dev); ^ drivers/ata/ahci_qoriq.c:319:2: error: implicit declaration of function 'pm_runtime_set_active' [-Werror=implicit-function-declaration] pm_runtime_set_active(dev); ^ drivers/ata/ahci_qoriq.c:320:2: error: implicit declaration of function 'pm_runtime_enable' [-Werror=implicit-function-declaration] pm_runtime_enable(dev); ^ drivers/ata/ahci.c: In function 'ahci_init_one': drivers/ata/ahci.c:1761:2: error: implicit declaration of function 'pm_runtime_put_noidle' [-Werror=implicit-function-declaration] pm_runtime_put_noidle(&pdev->dev); ^ drivers/ata/ahci.c: In function 'ahci_remove_one': drivers/ata/ahci.c:1767:2: error: implicit declaration of function 'pm_runtime_get_noresume' [-Werror=implicit-function-declaration] pm_runtime_get_noresume(&pdev->dev); ^ drivers/ata/libahci.c: In function 'ahci_rpm_get_port': drivers/ata/libahci.c:239:9: error: implicit declaration of function 'pm_runtime_get_sync' [-Werror=implicit-function-declaration] return pm_runtime_get_sync(ap->dev); ^ drivers/ata/libahci.c: In function 'ahci_rpm_put_port': drivers/ata/libahci.c:251:2: error: implicit declaration of function 'pm_runtime_put' [-Werror=implicit-function-declaration] pm_runtime_put(ap->dev); ^ drivers/ata/ahci_ceva.c: In function 'ceva_ahci_resume': drivers/ata/ahci_ceva.c:326:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration] pm_runtime_disable(dev); ^ drivers/ata/ahci_ceva.c:327:2: error: implicit declaration of function 'pm_runtime_set_active' [-Werror=implicit-function-declaration] pm_runtime_set_active(dev); ^ drivers/ata/ahci_ceva.c:328:2: error: implicit declaration of function 'pm_runtime_enable' [-Werror=implicit-function-declaration] pm_runtime_enable(dev); ^ cc1: some warnings being treated as errors make[2]: *** [drivers/ata/ahci_qoriq.o] Error 1 make[2]: *** Waiting for unfinished jobs.... cc1: some warnings being treated as errors make[2]: *** [drivers/ata/ahci_ceva.o] Error 1 cc1: some warnings being treated as errors make[2]: *** [drivers/ata/ahci.o] Error 1 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function 'analogix_dp_get_modes': drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:949:3: error: implicit declaration of function 'pm_runtime_get_sync' [-Werror=implicit-function-declaration] pm_runtime_get_sync(dp->dev); ^ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:951:3: error: implicit declaration of function 'pm_runtime_put' [-Werror=implicit-function-declaration] pm_runtime_put(dp->dev); ^ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function 'analogix_dp_bridge_disable': drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1120:2: error: implicit declaration of function 'pm_runtime_put_sync' [-Werror=implicit-function-declaration] pm_runtime_put_sync(dp->dev); ^ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function 'analogix_dp_bind': drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1387:2: error: implicit declaration of function 'pm_runtime_enable' [-Werror=implicit-function-declaration] pm_runtime_enable(dev); ^ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1431:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration] pm_runtime_disable(dev); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_enable': drivers/gpu/drm/exynos/exynos_drm_dsi.c:1385:2: error: implicit declaration of function 'pm_runtime_get_sync' [-Werror=implicit-function-declaration] pm_runtime_get_sync(dsi->dev); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c:1392:3: error: implicit declaration of function 'pm_runtime_put_sync' [-Werror=implicit-function-declaration] pm_runtime_put_sync(dsi->dev); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_probe': drivers/gpu/drm/exynos/exynos_drm_dsi.c:1797:2: error: implicit declaration of function 'pm_runtime_enable' [-Werror=implicit-function-declaration] pm_runtime_enable(dev); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_remove': drivers/gpu/drm/exynos/exynos_drm_dsi.c:1808:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration] pm_runtime_disable(&pdev->dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_clk_enable': drivers/gpu/drm/rockchip/cdn-dp-core.c:111:8: error: implicit declaration of function 'pm_runtime_get_sync' [-Werror=implicit-function-declaration] ret = pm_runtime_get_sync(dp->dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c:137:2: error: implicit declaration of function 'pm_runtime_put' [-Werror=implicit-function-declaration] pm_runtime_put(dp->dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_clk_disable': drivers/gpu/drm/rockchip/cdn-dp-core.c:148:2: error: implicit declaration of function 'pm_runtime_put_sync' [-Werror=implicit-function-declaration] pm_runtime_put_sync(dp->dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_bind': drivers/gpu/drm/rockchip/cdn-dp-core.c:1094:2: error: implicit declaration of function 'pm_runtime_enable' [-Werror=implicit-function-declaration] pm_runtime_enable(dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_unbind': drivers/gpu/drm/rockchip/cdn-dp-core.c:1118:2: error: implicit declaration of function 'pm_runtime_disable' [-Werror=implicit-function-declaration] pm_runtime_disable(dev); ^ cc1: some warnings being treated as errors make[2]: *** [drivers/ata/libahci.o] Error 1 make[1]: *** [drivers/ata] Error 2 make[1]: *** Waiting for unfinished jobs.... cc1: some warnings being treated as errors make[5]: *** [drivers/gpu/drm/bridge/analogix/analogix_dp_core.o] Error 1 make[4]: *** [drivers/gpu/drm/bridge/analogix] Error 2 make[3]: *** [drivers/gpu/drm/bridge] Error 2 make[3]: *** Waiting for unfinished jobs.... cc1: some warnings being treated as errors make[4]: *** [drivers/gpu/drm/exynos/exynos_drm_dsi.o] Error 1 make[3]: *** [drivers/gpu/drm/exynos] Error 2 cc1: some warnings being treated as errors make[4]: *** [drivers/gpu/drm/rockchip/cdn-dp-core.o] Error 1 make[3]: *** [drivers/gpu/drm/rockchip] Error 2 make[2]: *** [drivers/gpu/drm] Error 2 make[1]: *** [drivers/gpu] Error 2 make: *** [drivers] Error 2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from relmlor2.renesas.com ([210.160.252.172]:45374 "EHLO relmlie1.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752404AbdLUKdg (ORCPT ); Thu, 21 Dec 2017 05:33:36 -0500 From: Yoshihiro Shimoda To: Ulf Hansson , Kishon Vijay Abraham I , "linux-kernel@vger.kernel.org" CC: "Rafael J . Wysocki" , "linux-pm@vger.kernel.org" , Geert Uytterhoeven , "linux-renesas-soc@vger.kernel.org" Subject: RE: [PATCH v2 2/3] phy: core: Drop unused runtime PM APIs Date: Thu, 21 Dec 2017 10:33:31 +0000 Message-ID: References: <1513778960-10073-1-git-send-email-ulf.hansson@linaro.org> <1513778960-10073-3-git-send-email-ulf.hansson@linaro.org> In-Reply-To: <1513778960-10073-3-git-send-email-ulf.hansson@linaro.org> Content-Language: ja-JP Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Ulf-san, > -----Original Message----- > From: Ulf Hansson, Sent: Wednesday, December 20, 2017 11:09 PM > diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > index b4298a1..050b620 100644 > --- a/include/linux/phy/phy.h > +++ b/include/linux/phy/phy.h > @@ -17,7 +17,6 @@ > #include > #include > #include > -#include After I applied this patch, some ata and gpu drivers causes build error [1]= . So, we should fix the drivers at first... Best regards, Yoshihiro Shimoda --- [1] drivers/ata/ahci_qoriq.c: In function 'ahci_qoriq_resume': drivers/ata/ahci_qoriq.c:318:2: error: implicit declaration of function 'pm= _runtime_disable' [-Werror=3Dimplicit-function-declaration] pm_runtime_disable(dev); ^ drivers/ata/ahci_qoriq.c:319:2: error: implicit declaration of function 'pm= _runtime_set_active' [-Werror=3Dimplicit-function-declaration] pm_runtime_set_active(dev); ^ drivers/ata/ahci_qoriq.c:320:2: error: implicit declaration of function 'pm= _runtime_enable' [-Werror=3Dimplicit-function-declaration] pm_runtime_enable(dev); ^ drivers/ata/ahci.c: In function 'ahci_init_one': drivers/ata/ahci.c:1761:2: error: implicit declaration of function 'pm_runt= ime_put_noidle' [-Werror=3Dimplicit-function-declaration] pm_runtime_put_noidle(&pdev->dev); ^ drivers/ata/ahci.c: In function 'ahci_remove_one': drivers/ata/ahci.c:1767:2: error: implicit declaration of function 'pm_runt= ime_get_noresume' [-Werror=3Dimplicit-function-declaration] pm_runtime_get_noresume(&pdev->dev); ^ drivers/ata/libahci.c: In function 'ahci_rpm_get_port': drivers/ata/libahci.c:239:9: error: implicit declaration of function 'pm_ru= ntime_get_sync' [-Werror=3Dimplicit-function-declaration] return pm_runtime_get_sync(ap->dev); ^ drivers/ata/libahci.c: In function 'ahci_rpm_put_port': drivers/ata/libahci.c:251:2: error: implicit declaration of function 'pm_ru= ntime_put' [-Werror=3Dimplicit-function-declaration] pm_runtime_put(ap->dev); ^ drivers/ata/ahci_ceva.c: In function 'ceva_ahci_resume': drivers/ata/ahci_ceva.c:326:2: error: implicit declaration of function 'pm_= runtime_disable' [-Werror=3Dimplicit-function-declaration] pm_runtime_disable(dev); ^ drivers/ata/ahci_ceva.c:327:2: error: implicit declaration of function 'pm_= runtime_set_active' [-Werror=3Dimplicit-function-declaration] pm_runtime_set_active(dev); ^ drivers/ata/ahci_ceva.c:328:2: error: implicit declaration of function 'pm_= runtime_enable' [-Werror=3Dimplicit-function-declaration] pm_runtime_enable(dev); ^ cc1: some warnings being treated as errors make[2]: *** [drivers/ata/ahci_qoriq.o] Error 1 make[2]: *** Waiting for unfinished jobs.... cc1: some warnings being treated as errors make[2]: *** [drivers/ata/ahci_ceva.o] Error 1 cc1: some warnings being treated as errors make[2]: *** [drivers/ata/ahci.o] Error 1 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function 'analogix_d= p_get_modes': drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:949:3: error: implicit d= eclaration of function 'pm_runtime_get_sync' [-Werror=3Dimplicit-function-d= eclaration] pm_runtime_get_sync(dp->dev); ^ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:951:3: error: implicit d= eclaration of function 'pm_runtime_put' [-Werror=3Dimplicit-function-declar= ation] pm_runtime_put(dp->dev); ^ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function 'analogix_d= p_bridge_disable': drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1120:2: error: implicit = declaration of function 'pm_runtime_put_sync' [-Werror=3Dimplicit-function-= declaration] pm_runtime_put_sync(dp->dev); ^ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c: In function 'analogix_d= p_bind': drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1387:2: error: implicit = declaration of function 'pm_runtime_enable' [-Werror=3Dimplicit-function-de= claration] pm_runtime_enable(dev); ^ drivers/gpu/drm/bridge/analogix/analogix_dp_core.c:1431:2: error: implicit = declaration of function 'pm_runtime_disable' [-Werror=3Dimplicit-function-d= eclaration] pm_runtime_disable(dev); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_enable': drivers/gpu/drm/exynos/exynos_drm_dsi.c:1385:2: error: implicit declaration= of function 'pm_runtime_get_sync' [-Werror=3Dimplicit-function-declaration= ] pm_runtime_get_sync(dsi->dev); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c:1392:3: error: implicit declaration= of function 'pm_runtime_put_sync' [-Werror=3Dimplicit-function-declaration= ] pm_runtime_put_sync(dsi->dev); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_probe': drivers/gpu/drm/exynos/exynos_drm_dsi.c:1797:2: error: implicit declaration= of function 'pm_runtime_enable' [-Werror=3Dimplicit-function-declaration] pm_runtime_enable(dev); ^ drivers/gpu/drm/exynos/exynos_drm_dsi.c: In function 'exynos_dsi_remove': drivers/gpu/drm/exynos/exynos_drm_dsi.c:1808:2: error: implicit declaration= of function 'pm_runtime_disable' [-Werror=3Dimplicit-function-declaration] pm_runtime_disable(&pdev->dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_clk_enable': drivers/gpu/drm/rockchip/cdn-dp-core.c:111:8: error: implicit declaration o= f function 'pm_runtime_get_sync' [-Werror=3Dimplicit-function-declaration] ret =3D pm_runtime_get_sync(dp->dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c:137:2: error: implicit declaration o= f function 'pm_runtime_put' [-Werror=3Dimplicit-function-declaration] pm_runtime_put(dp->dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_clk_disable': drivers/gpu/drm/rockchip/cdn-dp-core.c:148:2: error: implicit declaration o= f function 'pm_runtime_put_sync' [-Werror=3Dimplicit-function-declaration] pm_runtime_put_sync(dp->dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_bind': drivers/gpu/drm/rockchip/cdn-dp-core.c:1094:2: error: implicit declaration = of function 'pm_runtime_enable' [-Werror=3Dimplicit-function-declaration] pm_runtime_enable(dev); ^ drivers/gpu/drm/rockchip/cdn-dp-core.c: In function 'cdn_dp_unbind': drivers/gpu/drm/rockchip/cdn-dp-core.c:1118:2: error: implicit declaration = of function 'pm_runtime_disable' [-Werror=3Dimplicit-function-declaration] pm_runtime_disable(dev); ^ cc1: some warnings being treated as errors make[2]: *** [drivers/ata/libahci.o] Error 1 make[1]: *** [drivers/ata] Error 2 make[1]: *** Waiting for unfinished jobs.... cc1: some warnings being treated as errors make[5]: *** [drivers/gpu/drm/bridge/analogix/analogix_dp_core.o] Error 1 make[4]: *** [drivers/gpu/drm/bridge/analogix] Error 2 make[3]: *** [drivers/gpu/drm/bridge] Error 2 make[3]: *** Waiting for unfinished jobs.... cc1: some warnings being treated as errors make[4]: *** [drivers/gpu/drm/exynos/exynos_drm_dsi.o] Error 1 make[3]: *** [drivers/gpu/drm/exynos] Error 2 cc1: some warnings being treated as errors make[4]: *** [drivers/gpu/drm/rockchip/cdn-dp-core.o] Error 1 make[3]: *** [drivers/gpu/drm/rockchip] Error 2 make[2]: *** [drivers/gpu/drm] Error 2 make[1]: *** [drivers/gpu] Error 2 make: *** [drivers] Error 2