All of lore.kernel.org
 help / color / mirror / Atom feed
From: daniel.sangorrin@toshiba.co.jp (daniel.sangorrin at toshiba.co.jp)
To: cip-dev@lists.cip-project.org
Subject: [cip-dev] [cip-kernel-sec 1/3] remotes: check that remotes exist
Date: Thu, 20 Jun 2019 05:54:25 +0000	[thread overview]
Message-ID: <TY2PR01MB3323C21364ABEEB897992805D0E40@TY2PR01MB3323.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <1560870435.21054.38.camel@codethink.co.uk>

Hello Ben,

> -----Original Message-----
> From: Ben Hutchings <ben.hutchings@codethink.co.uk>
> Sent: Wednesday, June 19, 2019 12:07 AM
> To: sangorrin daniel(????? ???? ????????) <daniel.sangorrin@toshiba.co.jp>
> Cc: cip-dev at lists.cip-project.org
> Subject: Re: [cip-kernel-sec 1/3] remotes: check that remotes exist
> 
> 
> 
> > -----Original Message-----
> > From: Ben Hutchings <ben.hutchings@codethink.co.uk>
> > Sent: Wednesday, June 19, 2019 12:07 AM
> > To: sangorrin daniel(????? ???? ????????) <daniel.sangorrin@toshiba.co.jp>
> > Cc: cip-dev at lists.cip-project.org
> > Subject: Re: [cip-kernel-sec 1/3] remotes: check that remotes exist
> >
> > This mostly looks fine, except:
> >
> > On Tue, 2019-06-18 at 11:40 +0900, Daniel Sangorrin wrote:
> > [...]
> > > --- /dev/null
> > > +++ b/scripts/prepare_remotes.py
> > [...]
> > > +def main(git_repo, remotes, debug=False):
> > > +????kernel_sec.branch.check_git_repo(git_repo, remotes, create=True)
> >
> > The debug flag doesn't have any effect...
> >
> > [...]
> > > +????parser.add_argument('--debug',
> > > +????????????????????????dest='debug', action='store_true',
> > > +????????????????????????help='enable debugging output')
> > [...]
> >
> > ...so neither does the --debug option.
> >
> > I think you can remove them both.

Thanks.
I have sent you a 2nd version of the 3 patch series.

Kind regards,
Daniel


> >
> > Ben.
> >
> > --
> > Ben Hutchings, Software Developer                ?        Codethink Ltd
> > https://www.codethink.co.uk/                 Dale House, 35 Dale Street
> >                                      Manchester, M1 2HF, United Kingdom

  reply	other threads:[~2019-06-20  5:54 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-18  2:40 [cip-dev] patches to check remotes Daniel Sangorrin
2019-06-18  2:40 ` [cip-dev] [cip-kernel-sec 1/3] remotes: check that remotes exist Daniel Sangorrin
2019-06-18 15:07   ` Ben Hutchings
2019-06-20  5:54     ` daniel.sangorrin at toshiba.co.jp [this message]
2019-06-18  2:40 ` [cip-dev] [cip-kernel-sec 2/3] branch: fix remotes mapping Daniel Sangorrin
2019-06-18 15:08   ` Ben Hutchings
2019-06-18  2:40 ` [cip-dev] [cip-kernel-sec 3/3] help:remote_name: use colon instead of equal Daniel Sangorrin
2019-06-18 15:08   ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=TY2PR01MB3323C21364ABEEB897992805D0E40@TY2PR01MB3323.jpnprd01.prod.outlook.com \
    --to=daniel.sangorrin@toshiba.co.jp \
    --cc=cip-dev@lists.cip-project.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.