RE: [PATCH 04/14] mmc: renesas_sdhi: Add support for R-Car H3e-2G and M3e-2G

From: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
To: Wolfram Sang <wsa@kernel.org>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>
Subject: RE: [PATCH 04/14] mmc: renesas_sdhi: Add support for R-Car H3e-2G and M3e-2G
Date: Fri, 25 Jun 2021 04:54:42 +0000	[thread overview]
Message-ID: <TY2PR01MB3692FA26EABD00FA4DD0F13AD8069@TY2PR01MB3692.jpnprd01.prod.outlook.com> (raw)
In-Reply-To: <YNSijAdvaNzHNnkF@shikoro>

Hi Wolfram-san,

> From: Wolfram Sang, Sent: Friday, June 25, 2021 12:20 AM
> 
> > > I don't fully understand how the refactoring should look like? Is it
> > > moving 'struct renesas_sdhi_quirks' to renesas_sdhi_internal_dmac.c and
> > > merge it there with renesas_sdhi_of_data? Is it really better to copy
> > > this struct per SoC? Most of the data is the same.
> >
> > I also have the same concern. But, I guess we can refactor
> > the renesas_sdhi_of_data like below to avoid increasing data size:
> >
> > struct renesas_sdhi_of_data_with_quirks {
> > 	const struct renesas_sdhi_of_data *of_data;
> > 	const struct renesas_sdhi_quirks *quirks;
> > };
> >
> > And then, we can keep of_rcar_gen3_compatible and
> > we can add each SoC's renesas_sdhi_of_data_with_quirks
> > and set it to the .data.
> 
> That sounds like a reasonable approach to me. This would also allow us
> to merge the quirks from sdhi_core with the quirks from
> sdhi_internal_dmac.

Thank you for your reply! So, I'll try to make such a patch.

Best regards,
Yoshihiro Shimoda