[U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode setting for latest iMX platforms

[Ashish Kumar <ashish.kumar@nxp.com>]

> -----Original Message-----
> From: Stefan Roese <sr@denx.de>
> Sent: Thursday, September 12, 2019 6:06 PM
> To: Ashish Kumar <ashish.kumar@nxp.com>; Schrempf Frieder
> <frieder.schrempf@kontron.de>; Ye Li <ye.li@nxp.com>;
> jagan at amarulasolutions.com
> Cc: Fabio Estevam <fabio.estevam@nxp.com>; u-boot at lists.denx.de; dl-
> uboot-imx <uboot-imx@nxp.com>
> Subject: Re: [U-Boot] [EXT] Re: [PATCH 1/6] spi: fsl_qspi: Fix DDR mode
> setting for latest iMX platforms
> 
> Caution: EXT Email
> 
> Hi Ashish,
> 
> On 12.09.19 07:03, Ashish Kumar wrote:
> 
> <snip>
> 
> >>>>>>> Please suggest way forward. How to correct this issue?
> >>>>>
> >>>>> The first thigh would be to make sure the Linux driver works for
> >>>>> all platforms and then do the porting to U-Boot. I will be out of
> >>>>> office for
> >>>>> 10 days. After that I can try to work on this, but I need support
> >>>>> and testing for other platforms. I only have i.MX6UL/ULL.
> >>>>
> >>>> Hi Frieder,
> >>>>
> >>>> I have found some break though after porting to 2019.10 and few
> >> modification in driver code, I will update in a weeks' time. Please
> >> do not invest time on this.
> >>>> If I need some help I will update.
> >>>
> >>> Thanks for your work. Do you already have some news? Can you share
> >>> your results?
> >>
> >> I'm most likely currently running in similar issues on tests with the
> >> i.MX6ULL EVK. QSPI does not work reliably. So before digging deeper
> >> into the QSPI driver, I wanted to check on the status of any updates
> >> in the driver. Is there anything available that I could use for testing
> already?
> > Hi Stefan,  Frieder,
> >
> > The spi-mem version is still under debug, I could make it working for
> > ls1088rdb, ls1046rdb, but it is failing for ls1012ardb and ls2088ardb
> > and untested for i.mx and other Layerscape silicon/boards . It is
> > derived from work done by Frieder earlier.
> > This version can be found here:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.com%2Ferashish007%2Fu-boot-spi-mem%2Ftree%2Fspi-mem-
> port&amp;data=0
> >
> 2%7C01%7Cashish.kumar%40nxp.com%7C2697e09d52b94dc737ce08d737cd3
> 34c%7C6
> >
> 86ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637039226779815773&amp
> ;sdata
> >
> =NqcR9VBELvvXhcCay850Fj%2BEZuOjkJzf15IXdBR4l2A%3D&amp;reserved=0
> 
> Many thanks. I did some tests with this version and it seems to work fine in
> general on the i.MX6ULL EVK. My first tests show that reading and writing
> has no issues. So this is very promising. The only thing I noticed is, that when
> using SPI for environment via CONFIG_ENV_IS_IN_SPI_FLASH, the board
> hangs upon bootup while trying to read the env. Since you already added
> some debug print's to the env code, I suspect that you also did run into this
> problem.
> 
> I'll try to help with this driver version. At least I can debug this env issue and
> can always do some test on my mx6ull platform for you once you have any
> updates here. Just let me know.
Hi Stefan, 

Yes, I was also debugging the same, what confuses me is that it works on
Ls1046, ls1088, but fails  on ls2088, ls1012.

Regards
Ashish 

> 
> > There is completely working version of fsl_qspi.c based on old xfer
> > method, which was not accepted  in upstream, considering it is
> > recommended to migrate to spi-mem frame. This version is located here:
> > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgith
> > ub.com%2Ferashish007%2Fu-boot-spi-
> mem%2Ftree%2Fxfer_wrking&amp;data=02
> >
> %7C01%7Cashish.kumar%40nxp.com%7C2697e09d52b94dc737ce08d737cd33
> 4c%7C68
> >
> 6ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637039226779815773&amp;
> sdata=
> > qpksEv36Zjb6jXKsnWN5iVtAoG9UEQFMIi4uu1OgiJ8%3D&amp;reserved=0
> 
> This one does not work for me on the i.MX6ULL EVK. "sf read" command
> returns almost immediately and the data is not read as it seems. I did not dig
> into this deeper though.
> 
> Thanks,
> Stefan