All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Kuninori Morimoto <kuninori.morimoto.gx@gmail.com>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Subject: Re: [PATCH 0/4] i2c: rcar: handle Gen2 and Gen3 V3U quirks better
Date: Sun, 27 Dec 2020 15:20:44 +0100	[thread overview]
Message-ID: <X+iYPBDTX9e663ee@wyvern> (raw)
In-Reply-To: <20201223172154.34462-1-wsa+renesas@sang-engineering.com>

Hi Wolfram,

Thanks for your series.

On 2020-12-23 18:21:50 +0100, Wolfram Sang wrote:
> The new V3U SoC needs handling of spurious interrupts which is handled
> in patch #4. However, this extra check is bad for Gen2 and earlier SoCs,
> so we need seperate interrupts now. While working on this, further
> improvements to avoid the HW race condition on Gen2 and earlier have
> been found, see patches 1-3.
> 
> My measurements have shown that patches 1+2 really improve the
> situation. Before, I could see doubled messages after adding 2us of
> delay to the interrupt handler. After, they only started to appear after
> 7us. I can't say much about the spurious interrupts on V3U. The BSP team
> experienced them, I did not so far.
> 
> Let me know what you think...

I like it, for the whole series

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> 
> 
> Wolfram Sang (4):
>   i2c: rcar: faster irq code to minimize HW race condition
>   i2c: rcar: optimize cacheline to minimize HW race condition
>   i2c: rcar: make sure irq is not threaded on Gen2 and earlier
>   i2c: rcar: protect against supurious interrupts on V3U
> 
>  drivers/i2c/busses/i2c-rcar.c | 66 +++++++++++++++++++++++++----------
>  1 file changed, 48 insertions(+), 18 deletions(-)
> 
> -- 
> 2.28.0
> 

-- 
Regards,
Niklas Söderlund

      parent reply	other threads:[~2020-12-27 14:21 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-23 17:21 [PATCH 0/4] i2c: rcar: handle Gen2 and Gen3 V3U quirks better Wolfram Sang
2020-12-23 17:21 ` [PATCH 1/4] i2c: rcar: faster irq code to minimize HW race condition Wolfram Sang
2021-01-05 15:35   ` Wolfram Sang
2020-12-23 17:21 ` [PATCH 2/4] i2c: rcar: optimize cacheline " Wolfram Sang
2020-12-28 12:52   ` Geert Uytterhoeven
2020-12-28 12:55     ` Wolfram Sang
2021-01-05 15:35   ` Wolfram Sang
2020-12-23 17:21 ` [PATCH 3/4] i2c: rcar: make sure irq is not threaded on Gen2 and earlier Wolfram Sang
2021-01-05 15:35   ` Wolfram Sang
2020-12-23 17:21 ` [PATCH 4/4] i2c: rcar: protect against supurious interrupts on V3U Wolfram Sang
2020-12-28 13:37   ` Geert Uytterhoeven
2020-12-28 14:46     ` Wolfram Sang
2021-01-05 15:35   ` Wolfram Sang
2020-12-27 14:20 ` Niklas Söderlund [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X+iYPBDTX9e663ee@wyvern \
    --to=niklas.soderlund@ragnatech.se \
    --cc=kuninori.morimoto.gx@gmail.com \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.