From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AAD4C433E9 for ; Mon, 28 Dec 2020 15:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2EB38223E8 for ; Mon, 28 Dec 2020 15:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440672AbgL1PKC (ORCPT ); Mon, 28 Dec 2020 10:10:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2440286AbgL1PJt (ORCPT ); Mon, 28 Dec 2020 10:09:49 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27D0FC061794; Mon, 28 Dec 2020 07:09:09 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8969B99; Mon, 28 Dec 2020 16:09:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1609168146; bh=BNY31dBvBUFP1U6FYYy/epeGZDj+VnkZejf+O7DTcTg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AeTK3VEeFqHGfSMYp5yReXu7Z2I2AXq8NNODSZ/vyaYQuW3ayiHwVZNftw7VXbLwH Ddwl2UBdv7TSZbt1IWa6uapGJA3RDGGdlqzcrjNTuNvN0yCLO4f+NH75xuVdmOb9pn D8InRDdvY7x1JvoHJo1dgJUcqzWpg//8gQ3gdIG0= Date: Mon, 28 Dec 2020 17:08:56 +0200 From: Laurent Pinchart To: Xin Ji Cc: Rob Herring , David Airlie , Nicolas Boichat , Hsin-Yi Wang , Daniel Vetter , Sam Ravnborg , Laurent Pinchart , Maxime Ripard , Mark Brown , Ricardo =?utf-8?Q?Ca=C3=B1uelo?= , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Sheng Pan , linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Xin Ji, Thank you for the patch. On Fri, Dec 25, 2020 at 07:01:09PM +0800, Xin Ji wrote: > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add > swing setting for adjusting DP tx PHY swing > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 60585a4..34a7faf 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -34,6 +34,14 @@ properties: > description: used for reset chip control, RESET_N pin B7. > maxItems: 1 > > + anx,swing-setting: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: an array of swing register setting for DP tx PHY Register values in DT are frowned upon. > + anx,mipi-dpi-in: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: indicate the MIPI rx signal type is DPI or DSI This sounds similar to the bus-type property defined in Documentation/devicetree/bindings/media/video-interfaces.txt (which is getting converted to YAML, Rob has posted a patch series, I expect it to land in v5.13). I think it would make sense to extend bus-type to support DSI, and use that property. > + > ports: > type: object > > @@ -72,6 +80,17 @@ examples: > reg = <0x58>; > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; > + anx,swing-setting = <0x00 0x14>, <0x01 0x54>, > + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, > + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, > + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>, > + <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, > + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, > + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, > + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, > + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, > + <0x26 0x40>, <0x27 0x60>; > + anx,mipi-dpi-in = <0>; > > ports { > #address-cells = <1>; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB263C433DB for ; Mon, 28 Dec 2020 15:09:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2F776223E8 for ; Mon, 28 Dec 2020 15:09:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2F776223E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6405B89304; Mon, 28 Dec 2020 15:09:12 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 15B9389304 for ; Mon, 28 Dec 2020 15:09:11 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 8969B99; Mon, 28 Dec 2020 16:09:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1609168146; bh=BNY31dBvBUFP1U6FYYy/epeGZDj+VnkZejf+O7DTcTg=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=AeTK3VEeFqHGfSMYp5yReXu7Z2I2AXq8NNODSZ/vyaYQuW3ayiHwVZNftw7VXbLwH Ddwl2UBdv7TSZbt1IWa6uapGJA3RDGGdlqzcrjNTuNvN0yCLO4f+NH75xuVdmOb9pn D8InRDdvY7x1JvoHJo1dgJUcqzWpg//8gQ3gdIG0= Date: Mon, 28 Dec 2020 17:08:56 +0200 From: Laurent Pinchart To: Xin Ji Subject: Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Laurent Pinchart , devicetree@vger.kernel.org, David Airlie , Ricardo =?utf-8?Q?Ca=C3=B1uelo?= , Mark Brown , linux-kernel@vger.kernel.org, Rob Herring , dri-devel@lists.freedesktop.org, Hsin-Yi Wang , Sam Ravnborg , Sheng Pan Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Xin Ji, Thank you for the patch. On Fri, Dec 25, 2020 at 07:01:09PM +0800, Xin Ji wrote: > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add > swing setting for adjusting DP tx PHY swing > > Signed-off-by: Xin Ji > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 60585a4..34a7faf 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -34,6 +34,14 @@ properties: > description: used for reset chip control, RESET_N pin B7. > maxItems: 1 > > + anx,swing-setting: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: an array of swing register setting for DP tx PHY Register values in DT are frowned upon. > + anx,mipi-dpi-in: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: indicate the MIPI rx signal type is DPI or DSI This sounds similar to the bus-type property defined in Documentation/devicetree/bindings/media/video-interfaces.txt (which is getting converted to YAML, Rob has posted a patch series, I expect it to land in v5.13). I think it would make sense to extend bus-type to support DSI, and use that property. > + > ports: > type: object > > @@ -72,6 +80,17 @@ examples: > reg = <0x58>; > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; > + anx,swing-setting = <0x00 0x14>, <0x01 0x54>, > + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, > + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, > + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>, > + <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, > + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, > + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, > + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, > + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, > + <0x26 0x40>, <0x27 0x60>; > + anx,mipi-dpi-in = <0>; > > ports { > #address-cells = <1>; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel