From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5DD71C433FE for ; Sat, 5 Dec 2020 08:26:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2517E22D2A for ; Sat, 5 Dec 2020 08:26:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727100AbgLEIYt (ORCPT ); Sat, 5 Dec 2020 03:24:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:50702 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727967AbgLEIXu (ORCPT ); Sat, 5 Dec 2020 03:23:50 -0500 Date: Sat, 5 Dec 2020 09:23:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607156590; bh=jj96Kcw+xXfcVwQbBF31tiFa7EGTlH/VyMukbQ2TMaY=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=1dgDBKOGb79bfGHXuCQiXheR07tYnIPb0e4AS0b2kZF/DSEG3AOBsA8UKFuo3zHlc O3Z7WKHWpck70ASSHP4Uys0NxuH5OxeixsYJ9L6xEZ4ODrakyraVcoQ3hY1Ie0nWhF Xd3ILezKQERxl1dQ0xcrtWMMgpdr0Ihqq/nkkP1I= From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: linux-usb@vger.kernel.org, Dmitry Torokhov , Russell King , Dominik Brodowski , Alan Stern , kernel@pengutronix.de, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH] ARM: sa11111: make sa1111 bus's remove callback return void Message-ID: References: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de> <20201204200927.p354eli7uqr776sp@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201204200927.p354eli7uqr776sp@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Fri, Dec 04, 2020 at 09:09:27PM +0100, Uwe Kleine-König wrote: > Hey Greg, > > On Fri, Dec 04, 2020 at 03:58:17PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Nov 26, 2020 at 12:47:24PM +0100, Uwe Kleine-König wrote: > > > The driver core ignores the return value of struct device_driver::remove > > > because there is only little that can be done. To simplify the quest to > > > make this function return void, let struct sa1111_driver::remove return > > > void, too. All users already unconditionally return 0, this commit makes > > > it obvious that returning an error code is a bad idea and ensures future > > > users behave accordingly. > > > > > > Signed-off-by: Uwe Kleine-König > > > > Reviewed-by: Greg Kroah-Hartman > > Thanks, can I interpret this also as an Ack to take the change affecting > drivers/usb via Russell's tree? Sorry, yes, that is what I was implying here, I should have been more specific. thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24998C4361A for ; Sat, 5 Dec 2020 08:24:27 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD97522D2A for ; Sat, 5 Dec 2020 08:24:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD97522D2A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bbOhwfMhJrGhhF2gT8zlMIRnS5xCAvQbEWmPUsXA8dM=; b=KwTOLIvdrUv8yWlzWT2bbpPM1 6iXSGjTqlQsQ392lwb8ZoaM4KUAH4KEZM8bbcuoQjvVD5vkg5XDxa2awztr4wldEpQgtRnXqMxY5q g9DDyOIC+GlqR/DWpZbiujMfk3z2fll9Snsux8xhWLSHP5FD8BQW0GyzOiFU8nR56Q+WVv67uOKWE H7+oZYrztYVKZOSGpJDxUfQYI2xfxv7XhZ6d+OfzyK/wddTXaCzI8cfMfVxa8W2hneFNQUGmKkMFc WAJ+VuSnnX5qeh94iSQmRJoBhE4kGLM5pTiRDHak9W4DYrSnhhwdQje8do/jelHtX6teE1lcPhF3r +OsOMv7ug==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klSqZ-0006xq-3l; Sat, 05 Dec 2020 08:23:15 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klSqX-0006xV-1Y for linux-arm-kernel@lists.infradead.org; Sat, 05 Dec 2020 08:23:13 +0000 Date: Sat, 5 Dec 2020 09:23:06 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1607156590; bh=jj96Kcw+xXfcVwQbBF31tiFa7EGTlH/VyMukbQ2TMaY=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=1dgDBKOGb79bfGHXuCQiXheR07tYnIPb0e4AS0b2kZF/DSEG3AOBsA8UKFuo3zHlc O3Z7WKHWpck70ASSHP4Uys0NxuH5OxeixsYJ9L6xEZ4ODrakyraVcoQ3hY1Ie0nWhF Xd3ILezKQERxl1dQ0xcrtWMMgpdr0Ihqq/nkkP1I= From: Greg Kroah-Hartman To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH] ARM: sa11111: make sa1111 bus's remove callback return void Message-ID: References: <20201126114724.2028511-1-u.kleine-koenig@pengutronix.de> <20201204200927.p354eli7uqr776sp@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201204200927.p354eli7uqr776sp@pengutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201205_032313_159638_51B562F2 X-CRM114-Status: GOOD ( 14.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Dmitry Torokhov , linux-usb@vger.kernel.org, Russell King , Dominik Brodowski , Alan Stern , kernel@pengutronix.de, linux-input@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 04, 2020 at 09:09:27PM +0100, Uwe Kleine-K=F6nig wrote: > Hey Greg, > = > On Fri, Dec 04, 2020 at 03:58:17PM +0100, Greg Kroah-Hartman wrote: > > On Thu, Nov 26, 2020 at 12:47:24PM +0100, Uwe Kleine-K=F6nig wrote: > > > The driver core ignores the return value of struct device_driver::rem= ove > > > because there is only little that can be done. To simplify the quest = to > > > make this function return void, let struct sa1111_driver::remove retu= rn > > > void, too. All users already unconditionally return 0, this commit ma= kes > > > it obvious that returning an error code is a bad idea and ensures fut= ure > > > users behave accordingly. > > > = > > > Signed-off-by: Uwe Kleine-K=F6nig > > = > > Reviewed-by: Greg Kroah-Hartman > = > Thanks, can I interpret this also as an Ack to take the change affecting > drivers/usb via Russell's tree? Sorry, yes, that is what I was implying here, I should have been more specific. thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel