All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Biggers <ebiggers@kernel.org>
To: Ard Biesheuvel <ardb@kernel.org>
Cc: linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au
Subject: Re: [PATCH v2] crypto: arm/chacha-neon - add missing counter increment
Date: Sun, 13 Dec 2020 18:23:06 -0800	[thread overview]
Message-ID: <X9bMij4eGOXn2XJv@sol.localdomain> (raw)
In-Reply-To: <20201213143929.7088-1-ardb@kernel.org>

On Sun, Dec 13, 2020 at 03:39:29PM +0100, Ard Biesheuvel wrote:
> This violates the skcipher API, which requires that the output IV is suitable
> for handling more input as long as the preceding input has been presented in
> round multiples of the block size. 

This part doesn't seem to be true, since the chacha implementations don't
implement the "output IV" thing.  It's only cbc and ctr that do (or at least
those are the only algorithms it's tested for).

- Eric

  reply	other threads:[~2020-12-14  2:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-13 14:39 [PATCH v2] crypto: arm/chacha-neon - add missing counter increment Ard Biesheuvel
2020-12-14  2:23 ` Eric Biggers [this message]
2020-12-14  2:25   ` Herbert Xu
2020-12-14 20:39     ` Eric Biggers
2020-12-23  8:53       ` Herbert Xu
2021-01-02 22:06 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9bMij4eGOXn2XJv@sol.localdomain \
    --to=ebiggers@kernel.org \
    --cc=ardb@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.