From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC31AC61DA4 for ; Fri, 3 Feb 2023 14:36:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233086AbjBCOgq (ORCPT ); Fri, 3 Feb 2023 09:36:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232856AbjBCOgk (ORCPT ); Fri, 3 Feb 2023 09:36:40 -0500 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6823E28D05 for ; Fri, 3 Feb 2023 06:36:38 -0800 (PST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2DD554B3; Fri, 3 Feb 2023 06:37:20 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6A8F3F71E; Fri, 3 Feb 2023 06:36:36 -0800 (PST) Date: Fri, 3 Feb 2023 14:36:26 +0000 From: Cristian Marussi To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Wiklander , Sumit Garg , Sudeep Holla Subject: Re: [PATCH 2/2] firmware: arm_scmi: optee: use optee system invocation Message-ID: References: <20230130094157.1082712-1-etienne.carriere@linaro.org> <20230130094157.1082712-2-etienne.carriere@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230130094157.1082712-2-etienne.carriere@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 30, 2023 at 10:41:57AM +0100, Etienne Carriere wrote: > Changes SCMI optee transport to enable sys_service capability of > its tee context to leverage provisioned system resources in OP-TEE > preventing possible deadlock. > > Such deadlock could happen when many Linux clients invoke OP-TEE are > are all suspended waiting for an OP-TEE RPC request access an SCMI > resource through the SCMI OP-TEE PTA service. > > Signed-off-by: Etienne Carriere > --- > drivers/firmware/arm_scmi/optee.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > index 2a7aeab40e54..91840345e946 100644 > --- a/drivers/firmware/arm_scmi/optee.c > +++ b/drivers/firmware/arm_scmi/optee.c > @@ -559,6 +559,9 @@ static int scmi_optee_service_probe(struct device *dev) > if (IS_ERR(tee_ctx)) > return -ENODEV; > > + /* SCMI agent can used TEE system service resources */ > + tee_ctx->sys_service = true; > + > agent = devm_kzalloc(dev, sizeof(*agent), GFP_KERNEL); > if (!agent) { > ret = -ENOMEM; LGTM. I suppose you'll sync-up with Sudeep for how to queue this whole series. Thanks, Cristian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59B36C05027 for ; Fri, 3 Feb 2023 14:39:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=MxmrKiF+YoUnbZAka5cWcC7DH1fzG4RxUSoT3SuhJ5Y=; b=RHCG0aZU+yTKGa cL5pFwx7Nt9weKH4OerKrzaD9zeLO8/PnysTsfDYmDMsvhTp9xJsc76eBLgd97eyNWQnq1wOJ0cPW C6Y6jSa5W+xQu7OmAhdalQPwtRNeOUtf8aS462EfS7NuhUMw+7YTr/vjJC97VNWqZZ8doup3tikJb PoPul03khX4WhbjWumzJ1uTYWxlCHiZob4EvcYkni1siYCPpKGEO0mrQPkeU0aMgfNROknS8UDzre 6YxmDd4+nDKcrdrnfUM+DHJxNYIGtjuWuxdoq+Mwv9zM/zP6ZW5ISm3XDbyENBS5tVfhhi/AwiUkT ZG63hweyuubxQLpEuk3w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNxCe-002VLG-28; Fri, 03 Feb 2023 14:38:12 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pNxBD-002UiS-A9 for linux-arm-kernel@lists.infradead.org; Fri, 03 Feb 2023 14:36:44 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2DD554B3; Fri, 3 Feb 2023 06:37:20 -0800 (PST) Received: from pluto (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E6A8F3F71E; Fri, 3 Feb 2023 06:36:36 -0800 (PST) Date: Fri, 3 Feb 2023 14:36:26 +0000 From: Cristian Marussi To: Etienne Carriere Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Wiklander , Sumit Garg , Sudeep Holla Subject: Re: [PATCH 2/2] firmware: arm_scmi: optee: use optee system invocation Message-ID: References: <20230130094157.1082712-1-etienne.carriere@linaro.org> <20230130094157.1082712-2-etienne.carriere@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230130094157.1082712-2-etienne.carriere@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230203_063643_462344_4A8A5B54 X-CRM114-Status: GOOD ( 14.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jan 30, 2023 at 10:41:57AM +0100, Etienne Carriere wrote: > Changes SCMI optee transport to enable sys_service capability of > its tee context to leverage provisioned system resources in OP-TEE > preventing possible deadlock. > > Such deadlock could happen when many Linux clients invoke OP-TEE are > are all suspended waiting for an OP-TEE RPC request access an SCMI > resource through the SCMI OP-TEE PTA service. > > Signed-off-by: Etienne Carriere > --- > drivers/firmware/arm_scmi/optee.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > index 2a7aeab40e54..91840345e946 100644 > --- a/drivers/firmware/arm_scmi/optee.c > +++ b/drivers/firmware/arm_scmi/optee.c > @@ -559,6 +559,9 @@ static int scmi_optee_service_probe(struct device *dev) > if (IS_ERR(tee_ctx)) > return -ENODEV; > > + /* SCMI agent can used TEE system service resources */ > + tee_ctx->sys_service = true; > + > agent = devm_kzalloc(dev, sizeof(*agent), GFP_KERNEL); > if (!agent) { > ret = -ENOMEM; LGTM. I suppose you'll sync-up with Sudeep for how to queue this whole series. Thanks, Cristian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel