Re: [PATCH v2 3/3] gpio: xilinx: Utilize generic bitmap_get_value and _set_value

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, Feb 15, 2021 at 06:56:10PM +0530, Syed Nayyar Waris wrote:
> On Sun, Feb 14, 2021 at 10:11 AM kernel test robot <lkp@intel.com> wrote:
> >
> > Hi Syed,
> >
> > I love your patch! Yet something to improve:
> >
> > [auto build test ERROR on e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62]
> >
> > url:    https://github.com/0day-ci/linux/commits/Syed-Nayyar-Waris/Introduce-the-for_each_set_clump-macro/20210212-213005
> > base:   e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62
> > config: i386-randconfig-d002-20200329 (attached as .config)
> > compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
> > reproduce (this is a W=1 build):
> >         # https://github.com/0day-ci/linux/commit/d83196ca7a23f614773c049b69ce3896679cec61
> >         git remote add linux-review https://github.com/0day-ci/linux
> >         git fetch --no-tags linux-review Syed-Nayyar-Waris/Introduce-the-for_each_set_clump-macro/20210212-213005
> >         git checkout d83196ca7a23f614773c049b69ce3896679cec61
> >         # save the attached .config to linux build tree
> >         make W=1 ARCH=i386
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All errors (new ones prefixed by >>, old ones prefixed by <<):
> >
> > >> ERROR: modpost: "bitmap_get_value" [drivers/gpio/gpio-xilinx.ko] undefined!
> > >> ERROR: modpost: "bitmap_set_value" [drivers/gpio/gpio-xilinx.ko] undefined!
> >
> 
> Dear All,
> 
> I was able to reproduce the above 2 build errors with the config file
> provided and the build command mentioned in the above mail. But I need
> help to fix the build errors.
> 
> Scenario:
> Function 'bitmap_get_value()' is declared in 'gpiolib.h'. It is
> defined in 'gpiolib.c'. Function 'bitmap_get_value()'  is then being
> used in gpio-xilinx.c and the build error is thrown. Similar situation
> holds for the other function 'bitmap_set_value'.
> 
> How do I resolve the above build error?. Kindly illuminate. The full
> patchset can be found at:
> https://lore.kernel.org/patchwork/cover/1380056/

Missed EXPORT_SYMBOL_GPL() or so?


-- 
With Best Regards,
Andy Shevchenko