> On Sun, Mar 07, 2021 at 10:20:44PM +0100, Lorenzo Bianconi wrote:
> > Convert mt76 dts bindings from .txt to .yaml

[...]

Hi Rob,

thx for the review.

> > +  reg:
> > +    maxItems: 1
> > +    description:
> > +      Address and length of the register set for the device
> 
> That's every reg, drop.

ack, I will fix it in v2

> 
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +    description:
> > +      Main device interrupt
> 
> Are there others besides 'main'? If not, drop description.

right. I will fix it in v2

> 
> > +
> > +  power-domains:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> 
> Don't need a type for common properties.

ack,  I will fix it in v2

> 
> > +    description:
> > +      Phandle to the power domain that the WMAC is part of.
> 
> That's every 'power-domains'. Just need to define how many: 'maxItems: 1'

ack,  I will fix it in v2

> 
> > +      This property is MT7622 specific
> 
> This can be a schema.

Can you please specify what you mean here?

> 
> > +
> > +  mediatek,infracfg:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description:
> > +      Phandle to the infrastructure bus fabric syscon node.
> > +      This property is MT7622 specific
> > +
> > +  ieee80211-freq-limit:
> > +    maxItems: 1
> 
> Just make sure, only 1 freq supported?

here we can convert ieee80211.txt in ieee80211.yaml and just refer to it,
right?

> 
> > +    description:
> > +      List of supported frequency ranges in KHz
> > +
> > +  mediatek,mtd-eeprom:
> > +    $ref: /schemas/types.yaml#/definitions/phandle-array
> > +    description:
> > +      Phandle to a MTD partition + offset containing EEPROM data
> > +
> > +  big-endian:
> > +    type: boolean
> > +    description:
> > +      Specify if the radio eeprom partition is written in big-endian
> > +
> > +  mediatek,eeprom-merge-otp:
> > +    type: boolean
> > +    description:
> > +      Merge EEPROM data with OTP data. Can be used on boards where the flash
> > +      calibration data is generic and specific calibration data should be
> > +      pulled from the OTP ROM
> > +
> > +  led:
> > +    type: object
> > +    properties:
> > +      led-sources:
> > +        $ref: /schemas/types.yaml#/definitions/uint32-array
> 
> No constraints for how many array entries?

ack, I will fix in v2.

Regards,
Lorenzo

> 
> > +        description:
> > +          List of device current outputs the LED is connected to
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    pcie0 {
> > +      #address-cells = <3>;
> > +      #size-cells = <2>;
> > +      wifi@0,0 {
> > +        compatible = "mediatek,mt76";
> > +        reg = <0x0000 0 0 0 0>;
> > +        ieee80211-freq-limit = <5000000 6000000>;
> > +        mediatek,mtd-eeprom = <&factory 0x8000>;
> > +        big-endian;
> > +
> > +        led {
> > +          led-sources = <2>;
> > +        };
> > +      };
> > +    };
> > +
> > +  - |
> > +    wmac: wmac@10300000 {
> > +      compatible = "mediatek,mt7628-wmac";
> > +      reg = <0x10300000 0x100000>;
> > +
> > +      interrupt-parent = <&cpuintc>;
> > +      interrupts = <6>;
> > +
> > +      mediatek,mtd-eeprom = <&factory 0x0>;
> > +    };
> > +
> > +  - |
> > +    wlmac: wmac@18000000 {
> > +      compatible = "mediatek,mt7622-wmac";
> > +      reg = <0x10300000 0x100000>;
> > +      interrupts = <0 211 8>;
> > +
> > +      mediatek,infracfg = <&infracfg>;
> > +
> > +      power-domains = <&scpsys 3>;
> > +    };
> > -- 
> > 2.29.2
> >