From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06E68C433E0 for ; Wed, 10 Mar 2021 23:29:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BFA7E64DDA for ; Wed, 10 Mar 2021 23:29:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233699AbhCJX30 (ORCPT ); Wed, 10 Mar 2021 18:29:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233150AbhCJX2u (ORCPT ); Wed, 10 Mar 2021 18:28:50 -0500 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CECA6C061761 for ; Wed, 10 Mar 2021 15:28:49 -0800 (PST) Received: by mail-ot1-x329.google.com with SMTP id j8so18231399otc.0 for ; Wed, 10 Mar 2021 15:28:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CcpjnFhs+hD8NIsHxenerG7IM+48zY0/1AwqAoJFhWQ=; b=bKne5DjbZE9XY5B/uBertZFJs2UrcfISuG2Z5FAP3+P4BEi8k0hijfCeLcQT4EOmM3 hD0sukxdht/nOTSaCOmDUJ3aYZElo+UBaqA5JmmA76TDHs2O4fXRP5XaHNzYO2pocp8K cS2e4pHyf9tHqtF1OSQQTgBHvp/8UovsFmwXnK0Ob8+bO65/QhaII/fTFMK8e+SgeQPr hROoy/oKmFS/J6oFxe+Gu1CN8MaQdiKokHTgcw02pKhWGE4OK3hmvaVVPwhxBmQFodS9 uoYu0OOKh4XiHQPMXAOgbrGaK7hfd6ybeVDXmOkuQE+fjIUyfZnz9ArTIUtilhjl+BFJ j/Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CcpjnFhs+hD8NIsHxenerG7IM+48zY0/1AwqAoJFhWQ=; b=BjXrFGmM5MiOeILj7r9PwSDuUSN/zyL8yX9pEZKRLXtKbKD81SKQ60DcceP6y3l4zw XMBHn4CrDthk2OlCgc+DCR8QO/qtThjxL2JlSjJKGO6Y/oSqkLX4azYAK4Et1WgZLJl5 l872kfqM6Wad8Ko6tTizfZc72Lt2NWE1ZpLa3n9+2m5Z7TVpYGZnr2dCwnYja5t1Swu+ Levly7PATHjs0vxQGJiRNC2IHpl+tnpx1PzTdd99v6899vJl3IbugSyJIKck32sUgdp5 YecVk/bcWHlWXRwkoLIOszv7JfElQmHVYA3yZxLWuLzMZNj/ujIX095uL9ndd/A40dqW FwoA== X-Gm-Message-State: AOAM533I8rlx4RDfHQGwld+r6ZosAWcn7gY9Xiua8RhOYJ1Zsgt+4wT3 wY9QUYRZC4FUsTjkq0IQjWwaNQ== X-Google-Smtp-Source: ABdhPJz52c30YvfDi3Kw8yjoSTmqG5ij8W6ebHqwnKKKCm0AFJvEKyzkQvQrGgaK4stz861b2WS8KA== X-Received: by 2002:a9d:6a50:: with SMTP id h16mr4504158otn.67.1615418929055; Wed, 10 Mar 2021 15:28:49 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id g21sm183373ooa.15.2021.03.10.15.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 15:28:48 -0800 (PST) Date: Wed, 10 Mar 2021 17:28:46 -0600 From: Bjorn Andersson To: Souradeep Chowdhury Cc: Rob Herring , Andy Gross , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, sibis@codeaurora.org, saiprakash.ranjan@codeaurora.org, Rajendra Nayak , vkoul@kernel.org Subject: Re: [PATCH V1 4/6] DCC: Added the sysfs entries for DCC(Data Capture and Compare) driver Message-ID: References: <332477ea39088fca5879af1a5278c289e1602f6d.1615393454.git.schowdhu@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <332477ea39088fca5879af1a5278c289e1602f6d.1615393454.git.schowdhu@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed 10 Mar 10:46 CST 2021, Souradeep Chowdhury wrote: > The DCC is a DMA engine designed to store register values either in > case of a system crash or in case of software triggers manually done > by the user. Using DCC hardware and the sysfs interface of the driver > the user can exploit various functionalities of DCC. The user can specify > the register addresses, the values of which is stored by DCC in it's > dedicated SRAM. The register addresses can be used either to read from, > write to, first read and store value and then write or to loop. All these > options can be exploited using the sysfs interface given to the user. > Following are the sysfs interfaces exposed in DCC driver which are > documented > 1)trigger > 2)config > 3)config_write > 4)config_reset > 5)enable > 6)rd_mod_wr > 7)loop > > Signed-off-by: Souradeep Chowdhury > --- > Documentation/ABI/testing/sysfs-driver-dcc | 74 ++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-driver-dcc > > diff --git a/Documentation/ABI/testing/sysfs-driver-dcc b/Documentation/ABI/testing/sysfs-driver-dcc > new file mode 100644 > index 0000000..7a855ca > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-driver-dcc > @@ -0,0 +1,74 @@ > +What: /sys/bus/platform/devices/.../trigger > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file allows the software trigger to be enabled > + by the user through the sysfs interface.Through this > + interface the user can manually start a software trigger > + in dcc where by the dcc driver stores the current status > + of the specified registers in dcc sram. > + > +What: /sys/bus/platform/devices/.../enable > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file allows the user to manually enable or > + disable dcc driver.The dcc hardware needs to be > + enabled before use. > + > +What: /sys/bus/platform/devices/.../config > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file allows user to configure the register values > + along with addresses to the dcc driver.This register > + addresses are used to read from,write or loop through. > + To enable all these options separate sysfs files have > + are created. Please describe the expected content of this file. > + > +What: /sys/bus/platform/devices/.../config_write > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file allows user to write a value to the register > + address given as argument.The values are entered in the > + form of . So it's just a generic 'write some user defined data to some user defined register'? This doesn't sound like the typical way things are exposed in sysfs. > + > +What: /sys/bus/platform/devices/.../config_reset > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to reset the configuration of > + a dcc driver to the default configuration. > + > +What: /sys/bus/platform/devices/.../loop > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to enter the loop count as dcc > + driver gives the option to loop multiple times on > + the same register and store the values for each > + loop. > + > +What: /sys/bus/platform/devices/.../rd_mod_wr > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to read the value of the register > + and then write the value given as an argument to the > + register address in config.The address argument should > + be given of the form . > + > +What: /sys/bus/platform/devices/.../ready > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to check the status of the dcc > + hardware if it's ready to take the inputs. > + > +What: /sys/bus/platform/devices/.../curr_list > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to configure the linkedlist data > + to be used while configuring addresses. Please describe the format of this attr. Is it read/write? Regards, Bjorn > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BD525C433E6 for ; Wed, 10 Mar 2021 23:30:21 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 53DD264DDA for ; Wed, 10 Mar 2021 23:30:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53DD264DDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=mTfBbGncCTWZUdKcIbFhW+JcEBgcLiXUyCuKEJOqC44=; b=QDg89F3ZxVBCmZUryjft9lEEd 7YKTZQZQbSULx+VeUYu7uAkrALMGV29Qnm7QjyvJ3Z69xIhSn9lWmtn2FSwDSjXXBqa71UHwVnW0w 8icQDreD0NSe9AzEtM6RCGbtInd3TeWfDYKtYaKIgUkyhxCok6NIqPYDF7+ESw+OlbPj4l8EFTvOm 3zkL/xYugK4kmGsfFOY9PVjbN4GqmLd0t02JFtnyiua2w0xd/jVqgcGGa4UsEBWZ/4ReLc6DkEec8 LfKhcJDdOo4thagmqR5HR6FkfEiAbEaPBgEd4eG22O8Fs0FBmIKAvptufQR6WGRUCRJjVUxNDC9sP cf/LV+rNg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lK8G6-007zww-PN; Wed, 10 Mar 2021 23:28:55 +0000 Received: from mail-ot1-x336.google.com ([2607:f8b0:4864:20::336]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lK8G2-007zvS-C4 for linux-arm-kernel@lists.infradead.org; Wed, 10 Mar 2021 23:28:52 +0000 Received: by mail-ot1-x336.google.com with SMTP id x28so3444943otr.6 for ; Wed, 10 Mar 2021 15:28:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=CcpjnFhs+hD8NIsHxenerG7IM+48zY0/1AwqAoJFhWQ=; b=bKne5DjbZE9XY5B/uBertZFJs2UrcfISuG2Z5FAP3+P4BEi8k0hijfCeLcQT4EOmM3 hD0sukxdht/nOTSaCOmDUJ3aYZElo+UBaqA5JmmA76TDHs2O4fXRP5XaHNzYO2pocp8K cS2e4pHyf9tHqtF1OSQQTgBHvp/8UovsFmwXnK0Ob8+bO65/QhaII/fTFMK8e+SgeQPr hROoy/oKmFS/J6oFxe+Gu1CN8MaQdiKokHTgcw02pKhWGE4OK3hmvaVVPwhxBmQFodS9 uoYu0OOKh4XiHQPMXAOgbrGaK7hfd6ybeVDXmOkuQE+fjIUyfZnz9ArTIUtilhjl+BFJ j/Nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CcpjnFhs+hD8NIsHxenerG7IM+48zY0/1AwqAoJFhWQ=; b=EtOt8DLOIVc6p8TweATid8hL36126CmkurWO+kssL66ofUTwKxMDzsYQRPkSDM0yWn Zr+pO9B1J8hwqEpPk8QIgZrJ7xdDpD81Vr9+H+2fQ/VmRz5pG3QsmIbE2gdUHHSG0riO ATWmnkd27R9yU+eEx4MFPBMWBLbhjn+giZvoOsNCLnv94xF9m/eeHAkeyQBfUea0o42+ vgkmTjd0UW9SJkNp5pYgFX2ZP5X3bhXSbmE/X5kOvAx1KGmY7Xxkg65FDQAzKdCpnEmo aYreKKX4Rm1XkkqNM1rhbnjaNZaYtGBClET/ehTLzSwAv5I71aphfW8aagte0qq+aVhf GS6A== X-Gm-Message-State: AOAM5310O3zKwQH+4o8l5jGh0xj7w6UICsckPrAg72OnS1O0n2hmFLxo H0cNwruiKZyV2qxLP16ZvkhWdA== X-Google-Smtp-Source: ABdhPJz52c30YvfDi3Kw8yjoSTmqG5ij8W6ebHqwnKKKCm0AFJvEKyzkQvQrGgaK4stz861b2WS8KA== X-Received: by 2002:a9d:6a50:: with SMTP id h16mr4504158otn.67.1615418929055; Wed, 10 Mar 2021 15:28:49 -0800 (PST) Received: from builder.lan (104-57-184-186.lightspeed.austtx.sbcglobal.net. [104.57.184.186]) by smtp.gmail.com with ESMTPSA id g21sm183373ooa.15.2021.03.10.15.28.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 10 Mar 2021 15:28:48 -0800 (PST) Date: Wed, 10 Mar 2021 17:28:46 -0600 From: Bjorn Andersson To: Souradeep Chowdhury Cc: Rob Herring , Andy Gross , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, sibis@codeaurora.org, saiprakash.ranjan@codeaurora.org, Rajendra Nayak , vkoul@kernel.org Subject: Re: [PATCH V1 4/6] DCC: Added the sysfs entries for DCC(Data Capture and Compare) driver Message-ID: References: <332477ea39088fca5879af1a5278c289e1602f6d.1615393454.git.schowdhu@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <332477ea39088fca5879af1a5278c289e1602f6d.1615393454.git.schowdhu@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210310_232850_581052_F65E8415 X-CRM114-Status: GOOD ( 38.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed 10 Mar 10:46 CST 2021, Souradeep Chowdhury wrote: > The DCC is a DMA engine designed to store register values either in > case of a system crash or in case of software triggers manually done > by the user. Using DCC hardware and the sysfs interface of the driver > the user can exploit various functionalities of DCC. The user can specify > the register addresses, the values of which is stored by DCC in it's > dedicated SRAM. The register addresses can be used either to read from, > write to, first read and store value and then write or to loop. All these > options can be exploited using the sysfs interface given to the user. > Following are the sysfs interfaces exposed in DCC driver which are > documented > 1)trigger > 2)config > 3)config_write > 4)config_reset > 5)enable > 6)rd_mod_wr > 7)loop > > Signed-off-by: Souradeep Chowdhury > --- > Documentation/ABI/testing/sysfs-driver-dcc | 74 ++++++++++++++++++++++++++++++ > 1 file changed, 74 insertions(+) > create mode 100644 Documentation/ABI/testing/sysfs-driver-dcc > > diff --git a/Documentation/ABI/testing/sysfs-driver-dcc b/Documentation/ABI/testing/sysfs-driver-dcc > new file mode 100644 > index 0000000..7a855ca > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-driver-dcc > @@ -0,0 +1,74 @@ > +What: /sys/bus/platform/devices/.../trigger > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file allows the software trigger to be enabled > + by the user through the sysfs interface.Through this > + interface the user can manually start a software trigger > + in dcc where by the dcc driver stores the current status > + of the specified registers in dcc sram. > + > +What: /sys/bus/platform/devices/.../enable > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file allows the user to manually enable or > + disable dcc driver.The dcc hardware needs to be > + enabled before use. > + > +What: /sys/bus/platform/devices/.../config > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file allows user to configure the register values > + along with addresses to the dcc driver.This register > + addresses are used to read from,write or loop through. > + To enable all these options separate sysfs files have > + are created. Please describe the expected content of this file. > + > +What: /sys/bus/platform/devices/.../config_write > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file allows user to write a value to the register > + address given as argument.The values are entered in the > + form of . So it's just a generic 'write some user defined data to some user defined register'? This doesn't sound like the typical way things are exposed in sysfs. > + > +What: /sys/bus/platform/devices/.../config_reset > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to reset the configuration of > + a dcc driver to the default configuration. > + > +What: /sys/bus/platform/devices/.../loop > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to enter the loop count as dcc > + driver gives the option to loop multiple times on > + the same register and store the values for each > + loop. > + > +What: /sys/bus/platform/devices/.../rd_mod_wr > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to read the value of the register > + and then write the value given as an argument to the > + register address in config.The address argument should > + be given of the form . > + > +What: /sys/bus/platform/devices/.../ready > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to check the status of the dcc > + hardware if it's ready to take the inputs. > + > +What: /sys/bus/platform/devices/.../curr_list > +Date: February 2021 > +Contact: Souradeep Chowdhury > +Description: > + This file is used to configure the linkedlist data > + to be used while configuring addresses. Please describe the format of this attr. Is it read/write? Regards, Bjorn > -- > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member > of Code Aurora Forum, hosted by The Linux Foundation > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel