From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Paul Cercueil <paul@crapouillou.net>
Cc: od@zcrc.me, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/3] input: gpio-keys: Use hrtimer for release timer
Date: Tue, 23 Mar 2021 14:33:36 -0700 [thread overview]
Message-ID: <YFpesNC3mjqqLf8v@google.com> (raw)
In-Reply-To: <20210307222240.380583-2-paul@crapouillou.net>
On Sun, Mar 07, 2021 at 10:22:39PM +0000, Paul Cercueil wrote:
> Dealing with input, timing is important; if the button should be
> released in one millisecond, then it should be done in one millisecond
> and not a hundred milliseconds.
>
> Therefore, the standard timer API is not really suitable for this task.
>
> Convert the gpio-keys driver to use a hrtimer instead of the standard
> timer to address this issue.
>
> Note that by using a hard IRQ for the hrtimer callback, we can get rid
> of the spin_lock_irqsave() and spin_unlock_irqrestore().
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Applied, thank you.
--
Dmitry
next prev parent reply other threads:[~2021-03-23 21:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-07 22:22 [PATCH v3 1/3] input: gpio-keys: Remove extra call to input_sync Paul Cercueil
2021-03-07 22:22 ` [PATCH v3 2/3] input: gpio-keys: Use hrtimer for release timer Paul Cercueil
2021-03-23 21:33 ` Dmitry Torokhov [this message]
2021-03-07 22:22 ` [PATCH v3 3/3] input: gpio-keys: Use hrtimer for software debounce, if possible Paul Cercueil
2021-03-23 21:34 ` Dmitry Torokhov
2021-04-06 8:37 ` Tony Lindgren
2021-04-07 4:34 ` Dmitry Torokhov
2021-03-23 21:33 ` [PATCH v3 1/3] input: gpio-keys: Remove extra call to input_sync Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YFpesNC3mjqqLf8v@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=od@zcrc.me \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.