Re: [Intel-gfx] [PATCH] drm/i915/pm: Make the wm parameter of print_wm_latency a pointer

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Tue, Apr 13, 2021 at 12:32:59PM -0500, Jason Ekstrand wrote:
> This fixes the following build error with GCC 11:
> 
>     In function ‘snb_wm_latency_quirk’,
>         inlined from ‘ilk_setup_wm_latency’ at drivers/gpu/drm/i915/intel_pm.c:3109:3,
>         inlined from ‘intel_init_pm’ at drivers/gpu/drm/i915/intel_pm.c:7695:3:
>     drivers/gpu/drm/i915/intel_pm.c:3058:9: error: ‘intel_print_wm_latency’ reading 16 bytes from a region of size 10 [-Werror=stringop-overread]
>      3058 |         intel_print_wm_latency(dev_priv, "Primary", dev_priv->wm.pri_latency);
>           |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>     drivers/gpu/drm/i915/intel_pm.c: In function ‘intel_init_pm’:
>     drivers/gpu/drm/i915/intel_pm.c:3058:9: note: referencing argument 3 of type ‘const u16 *’ {aka ‘const short unsigned int *’}
>     drivers/gpu/drm/i915/intel_pm.c:2995:13: note: in a call to function ‘intel_print_wm_latency’
>      2995 | static void intel_print_wm_latency(struct drm_i915_private *dev_priv,
>           |             ^~~~~~~~~~~~~~~~~~~~~~
> 
> As far as I can tell, we don't actually need 8 elements except on SKL
> and that uses dev_priv->wm.skl_latency which has enough.
> 
> Signed-off-by: Jason Ekstrand <jason@jlekstrand.net>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

and pushed. Thanks for the patch.

> ---
>  drivers/gpu/drm/i915/intel_pm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
> index 3f6d8b502a619..59498794ac4ea 100644
> --- a/drivers/gpu/drm/i915/intel_pm.c
> +++ b/drivers/gpu/drm/i915/intel_pm.c
> @@ -2994,7 +2994,7 @@ int ilk_wm_max_level(const struct drm_i915_private *dev_priv)
>  
>  static void intel_print_wm_latency(struct drm_i915_private *dev_priv,
>  				   const char *name,
> -				   const u16 wm[8])
> +				   const u16 *wm)
>  {
>  	int level, max_level = ilk_wm_max_level(dev_priv);
>  
> -- 
> 2.31.1
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx