All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jerry Hoemann <jerry.hoemann@hpe.com>
To: Randy Wright <rwright@hpe.com>
Cc: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
	gustavoars@kernel.org, geert+renesas@glider.be, u74147@gmail.com,
	tobiasdiedrich@gmail.com, jirislaby@kernel.org,
	gregkh@linuxfoundation.org, toshi.kani@hpe.com
Subject: Re: [PATCH] Add support for new HPE serial device
Date: Fri, 14 May 2021 11:09:14 -0600	[thread overview]
Message-ID: <YJ6uuqggRTJ4DVCW@anatevka.americas.hpqcorp.net> (raw)
In-Reply-To: <1621009614-28836-1-git-send-email-rwright@hpe.com>

On Fri, May 14, 2021 at 10:26:54AM -0600, Randy Wright wrote:
> Add support for new HPE serial device.  It is MSI enabled,
> but otherwise similar to legacy HP server serial devices.
> 
> Signed-off-by: Randy Wright <rwright@hpe.com>


Tested-by: Jerry Hoemann <jerry.hoemann@hpe.com>


> ---
>  drivers/tty/serial/8250/8250_pci.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/tty/serial/8250/8250_pci.c b/drivers/tty/serial/8250/8250_pci.c
> index 689d822..04fe424 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -56,6 +56,8 @@ struct serial_private {
>  	int			line[];
>  };
>  
> +#define PCI_DEVICE_ID_HPE_PCI_SERIAL	0x37e
> +
>  static const struct pci_device_id pci_use_msi[] = {
>  	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9900,
>  			 0xA000, 0x1000) },
> @@ -63,6 +65,8 @@ struct serial_private {
>  			 0xA000, 0x1000) },
>  	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_NETMOS, PCI_DEVICE_ID_NETMOS_9922,
>  			 0xA000, 0x1000) },
> +	{ PCI_DEVICE_SUB(PCI_VENDOR_ID_HP_3PAR, PCI_DEVICE_ID_HPE_PCI_SERIAL,
> +			 PCI_ANY_ID, PCI_ANY_ID) },
>  	{ }
>  };
>  
> @@ -1998,6 +2002,16 @@ static void pci_wch_ch38x_exit(struct pci_dev *dev)
>  		.setup		= pci_hp_diva_setup,
>  	},
>  	/*
> +	 * HPE PCI serial device
> +	 */
> +	{
> +		.vendor         = PCI_VENDOR_ID_HP_3PAR,
> +		.device         = PCI_DEVICE_ID_HPE_PCI_SERIAL,
> +		.subvendor      = PCI_ANY_ID,
> +		.subdevice      = PCI_ANY_ID,
> +		.setup		= pci_hp_diva_setup,
> +	},
> +	/*
>  	 * Intel
>  	 */
>  	{
> @@ -4973,6 +4987,10 @@ static SIMPLE_DEV_PM_OPS(pciserial_pm_ops, pciserial_suspend_one,
>  	{	PCI_VENDOR_ID_HP, PCI_DEVICE_ID_HP_DIVA_AUX,
>  		PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>  		pbn_b2_1_115200 },
> +	/* HPE PCI serial device */
> +	{	PCI_VENDOR_ID_HP_3PAR, PCI_DEVICE_ID_HPE_PCI_SERIAL,
> +		PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> +		pbn_b1_1_115200 },
>  
>  	{	PCI_VENDOR_ID_DCI, PCI_DEVICE_ID_DCI_PCCOM2,
>  		PCI_ANY_ID, PCI_ANY_ID, 0, 0,
> -- 
> 1.8.3.1

-- 

-----------------------------------------------------------------------------
Jerry Hoemann                  Software Engineer   Hewlett Packard Enterprise
-----------------------------------------------------------------------------

      reply	other threads:[~2021-05-14 17:09 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 16:26 [PATCH] Add support for new HPE serial device Randy Wright
2021-05-14 17:09 ` Jerry Hoemann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YJ6uuqggRTJ4DVCW@anatevka.americas.hpqcorp.net \
    --to=jerry.hoemann@hpe.com \
    --cc=geert+renesas@glider.be \
    --cc=gregkh@linuxfoundation.org \
    --cc=gustavoars@kernel.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=rwright@hpe.com \
    --cc=tobiasdiedrich@gmail.com \
    --cc=toshi.kani@hpe.com \
    --cc=u74147@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.