From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83425C433B4 for ; Sat, 8 May 2021 14:41:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 525DC61057 for ; Sat, 8 May 2021 14:41:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229523AbhEHOmp (ORCPT ); Sat, 8 May 2021 10:42:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:44872 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229497AbhEHOmo (ORCPT ); Sat, 8 May 2021 10:42:44 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8E02861057; Sat, 8 May 2021 14:41:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1620484902; bh=BfD8EGeWghfBZ+pVItr/slgBUaFTI6OrxXcMxGIcHrQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SznXgKwsVmqPZEIcEW0BAOPYRWlZUTiONIkf5Fa2NmvS/8rUNbrzu+VdJgw51oNP1 Z7HSO7ivW8eMc2mfKoapv7G5v8XuiRQejDxJ6kQViA3JZl3A6dGn5k+qi+TgUV48PL zxorbNNRyZZDs6vvY55CeIuqJNJmfdm+nGh39PypO+pdU10KJ+hpiCMwsJikgfHFgT +qtlHmd/H7x4SjdgYzbSuRYjE8/wLWnJAF1XjlxwZh9EkBudZzRfWF/KSg1/oFgn4b YSSfLuc+dQZTSwXePH8SKCaRLzaBDV2KqG/FgehlrIyXW7bANUqzgsY0BL1PJxVsVE WCtLYn741jhOg== Received: by quaco.ghostprotocols.net (Postfix, from userid 1000) id C208C4034C; Sat, 8 May 2021 11:41:39 -0300 (-03) Date: Sat, 8 May 2021 11:41:39 -0300 From: Arnaldo Carvalho de Melo To: Jiri Olsa Cc: Martin KaFai Lau , dwarves@vger.kernel.org, bpf@vger.kernel.org, Jiri Slaby , kernel-team@fb.com, Andrii Nakryiko , Jiri Olsa Subject: Re: [PATCH v2 dwarves] btf: Remove ftrace filter Message-ID: References: <20210506205622.3663956-1-kafai@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Url: http://acmel.wordpress.com Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org Em Fri, May 07, 2021 at 12:39:52PM +0200, Jiri Olsa escreveu: > On Thu, May 06, 2021 at 01:56:22PM -0700, Martin KaFai Lau wrote: > > BTF is currently generated for functions that are in ftrace list > > or extern. > > > > A recent use case also needs BTF generated for functions included in > > allowlist. In particular, the kernel > > commit e78aea8b2170 ("bpf: tcp: Put some tcp cong functions in allowlist for bpf-tcp-cc") > > allows bpf program to directly call a few tcp cc kernel functions. Those > > kernel functions are currently allowed only if CONFIG_DYNAMIC_FTRACE > > is set to ensure they are in the ftrace list but this kconfig dependency > > is unnecessary. > > > > Those kernel functions are specified under an ELF section .BTF_ids. > > There was an earlier attempt [0] to add another filter for the functions in > > the .BTF_ids section. That discussion concluded that the ftrace filter > > should be removed instead. > > > > This patch is to remove the ftrace filter and its related functions. > > > > Number of BTF FUNC with and without is_ftrace_func(): > > My kconfig in x86: 40643 vs 46225 > > Jiri reported on arm: 25022 vs 55812 > > > > [0]: https://lore.kernel.org/dwarves/20210423213728.3538141-1-kafai@fb.com/ > > > > Cc: Andrii Nakryiko > > Cc: Jiri Olsa > > Signed-off-by: Martin KaFai Lau > > --- > > v2: Remove sym_sec_idx, last_idx, and sh. (Jiri Olsa) > > Acked-by: Jiri Olsa Thanks, applied. - Arnaldo