Re: [PATCH] hw/nvme/ctrl: fix functions style

From: Klaus Jensen <its@irrelevant.dk>
To: Gollu Appalanaidu <anaidu.gollu@samsung.com>
Cc: fam@euphon.net, kwolf@redhat.com, qemu-block@nongnu.org,
	qemu-devel@nongnu.org, mreitz@redhat.com, stefanha@redhat.com,
	kbusch@kernel.org
Subject: Re: [PATCH] hw/nvme/ctrl: fix functions style
Date: Fri, 21 May 2021 09:13:51 +0200	[thread overview]
Message-ID: <YKddr8UDZhPzK0Yr@apples.localdomain> (raw)
In-Reply-To: <20210521060842.25516-1-anaidu.gollu@samsung.com>

[-- Attachment #1: Type: text/plain, Size: 1540 bytes --]

On May 21 11:38, Gollu Appalanaidu wrote:
>Identify command related functions style fix.
>
>Signed-off-by: Gollu Appalanaidu <anaidu.gollu@samsung.com>
>---
> hw/nvme/ctrl.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c
>index 0bcaf7192f..40a7efcea9 100644
>--- a/hw/nvme/ctrl.c
>+++ b/hw/nvme/ctrl.c
>@@ -4291,7 +4291,7 @@ static uint16_t nvme_identify_ns_attached_list(NvmeCtrl *n, NvmeRequest *req)
> }
>
> static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                     bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>@@ -4326,7 +4326,7 @@ static uint16_t nvme_identify_ns_csi(NvmeCtrl *n, NvmeRequest *req,
> }
>
> static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                     bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>@@ -4373,7 +4373,7 @@ static uint16_t nvme_identify_nslist(NvmeCtrl *n, NvmeRequest *req,
> }
>
> static uint16_t nvme_identify_nslist_csi(NvmeCtrl *n, NvmeRequest *req,
>-        bool active)
>+                                         bool active)
> {
>     NvmeNamespace *ns;
>     NvmeIdentify *c = (NvmeIdentify *)&req->cmd;
>-- 
>2.17.1
>
>

Thanks, applied to nvme-next.

Please just use 'hw/nvme:' in the commit title, we don't need to specify 
the sub-subsystem ;)

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]