From: Greg KH <gregkh@linuxfoundation.org>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: arnd@arndb.de, mihai.carabas@oracle.com,
andriy.shevchenko@linux.intel.com, pizhenwei@bytedance.com,
pbonzini@redhat.com, linqiheng@huawei.com,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()'
Date: Fri, 21 May 2021 15:15:32 +0200 [thread overview]
Message-ID: <YKeydEDcqgiAYGgT@kroah.com> (raw)
In-Reply-To: <694c162e-cbd4-5c51-9b20-b66006594d75@wanadoo.fr>
On Fri, May 21, 2021 at 02:41:16PM +0200, Christophe JAILLET wrote:
> Le 21/05/2021 à 14:36, Greg KH a écrit :
> > On Sun, May 16, 2021 at 04:36:55PM +0200, Christophe JAILLET wrote:
> > > There is no error handling path in the probe function.
> > > Switch to managed resource so that errors in the probe are handled easily
> > > and simplify the remove function accordingly.
> > >
> > > Fixes: db3a4f0abefd ("misc/pvpanic: add PCI driver")
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > > ---
> > > drivers/misc/pvpanic/pvpanic-pci.c | 9 +++------
> > > 1 file changed, 3 insertions(+), 6 deletions(-)
> >
> > I see two different series for these patches, so I don't know which to
> > take :(
> >
> > Please fix up and send a v2 series so that I have a clue...
> >
> > thanks,
> >
> > greg k-h
> >
>
> Both have to be taken. One is for -pci.c and one is for -mmio.c.
Ah, I totally missed that :(
> I'll resend both with a more complete subject and will include Andy
> Shevchenko's comments.
Wonderful, thanks for doing that.
greg k-h
prev parent reply other threads:[~2021-05-21 13:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-16 14:36 [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()' Christophe JAILLET
2021-05-16 14:37 ` [PATCH 2/2] misc/pvpanic: Use GFP_KERNEL instead of GFP_ATOMIC Christophe JAILLET
2021-05-17 8:01 ` [PATCH 1/2] misc/pvpanic: Fix error handling in 'pvpanic_pci_probe()' Andy Shevchenko
2021-05-17 10:02 ` Christophe JAILLET
2021-05-17 10:34 ` Andy Shevchenko
2021-05-17 11:24 ` Christophe JAILLET
2021-05-21 12:36 ` Greg KH
2021-05-21 12:41 ` Christophe JAILLET
2021-05-21 13:15 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YKeydEDcqgiAYGgT@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linqiheng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mihai.carabas@oracle.com \
--cc=pbonzini@redhat.com \
--cc=pizhenwei@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.