From: Vinod Koul <vkoul@kernel.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
linux-kernel@vger.kernel.org, Stefan Roese <sr@denx.de>,
dmaengine@vger.kernel.org, Sinan Kaya <okaya@codeaurora.org>,
Green Wan <green.wan@sifive.com>,
Hyun Kwon <hyun.kwon@xilinx.com>,
Tejas Upadhyay <tejasu@xilinx.com>,
Michal Simek <michal.simek@xilinx.com>,
kernel test robot <lkp@intel.com>
Subject: Re: [PATCH 4/4] DMA: XILINX_ZYNQMP_DPDMA depends on HAS_IOMEM
Date: Mon, 31 May 2021 09:42:19 +0530 [thread overview]
Message-ID: <YLRiIyy9un3i+1x+@vkoul-mobl.Dlink> (raw)
In-Reply-To: <93da0e86-dbef-432d-20db-c2eda03f0071@infradead.org>
On 23-05-21, 12:08, Randy Dunlap wrote:
> On 5/23/21 11:53 AM, Laurent Pinchart wrote:
> > Hi Randy,
> >
> > On Sat, May 22, 2021 at 06:07:01PM -0700, Randy Dunlap wrote:
> >> On 5/22/21 5:20 PM, Laurent Pinchart wrote:
> >>> On Fri, May 21, 2021 at 07:13:13PM -0700, Randy Dunlap wrote:
> >>>> When CONFIG_HAS_IOMEM is not set/enabled, most iomap() family
> >>>> functions [including ioremap(), devm_ioremap(), etc.] are not
> >>>> available.
> >>>> Drivers that use these functions should depend on HAS_IOMEM so that
> >>>> they do not cause build errors.
> >>>>
> >>>> Cures this build error:
> >>>> s390-linux-ld: drivers/dma/xilinx/xilinx_dpdma.o: in function `xilinx_dpdma_probe':
> >>>> xilinx_dpdma.c:(.text+0x336a): undefined reference to `devm_platform_ioremap_resource'
> >>>
> >>> I've previously posted
> >>> https://lore.kernel.org/dmaengine/20210520152420.23986-2-laurent.pinchart@ideasonboard.com/T/#u
> >>> which fixes the same issue (plus an additional one).
> >>
> >> Hi Laurent,
> >>
> >> I didn't add a dependency on OF because OF header files _mostly_
> >> have stubs so that they work when OF is enabled or disabled.
> >>
> >> I did find a problem in <linux/of_address.h> where it could end up
> >> without having a stub. I will post a patch for that soon.
> >> I'm currently doing lots of randconfig builds on it.
> >
> > I'm fine with eithe approach, but the patch you've posted to address the
> > of_address.h issue has an issue itself.
>
> I'm also fine with either patch.
> I'm reworking the of_address.h patch now.
Back from vacation and clearing inbox... I have already applied Laurents
patch for this...
Thanks
--
~Vinod
next prev parent reply other threads:[~2021-05-31 4:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 2:13 [PATCH 0/4] DMA: several drivers depend on HAS_IOMEM Randy Dunlap
2021-05-22 2:13 ` [PATCH 1/4] DMA: ALTERA_MSGDMA depends " Randy Dunlap
2021-05-22 7:21 ` Stefan Roese
2021-05-22 2:13 ` [PATCH 2/4] DMA: QCOM_HIDMA_MGMT " Randy Dunlap
2021-05-22 2:13 ` [PATCH 3/4] DMA: SF_PDMA " Randy Dunlap
2021-05-22 2:13 ` [PATCH 4/4] DMA: XILINX_ZYNQMP_DPDMA " Randy Dunlap
2021-05-23 0:20 ` Laurent Pinchart
2021-05-23 1:07 ` Randy Dunlap
2021-05-23 18:53 ` Laurent Pinchart
2021-05-23 19:08 ` Randy Dunlap
2021-05-31 4:12 ` Vinod Koul [this message]
2021-05-31 4:14 ` [PATCH 0/4] DMA: several drivers depend " Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLRiIyy9un3i+1x+@vkoul-mobl.Dlink \
--to=vkoul@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=green.wan@sifive.com \
--cc=hyun.kwon@xilinx.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=michal.simek@xilinx.com \
--cc=okaya@codeaurora.org \
--cc=rdunlap@infradead.org \
--cc=sr@denx.de \
--cc=tejasu@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.