From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8211EC47096 for ; Thu, 3 Jun 2021 15:40:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 58FAE61208 for ; Thu, 3 Jun 2021 15:40:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229888AbhFCPmO (ORCPT ); Thu, 3 Jun 2021 11:42:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:53290 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbhFCPmK (ORCPT ); Thu, 3 Jun 2021 11:42:10 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id B4F50611ED; Thu, 3 Jun 2021 15:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622734826; bh=mFAhNgmUD+wtIhwDrs/ENUxcjRAmrenuOPwzcjPUBhE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ki8nDtgjf9jwCjL2WGcL99KCyzystjkusR4WvwQzMFYK5PnVnLQoUkUJBT2nP57B+ e3qgJjXtUWbjITUVd0T7cNiVvBL+KA4KS7wEfZKT/4Hsg3HxUmvfWMpUavO9GpcMb2 KqDhVPCAAQCCdU0pFU1iWNclAyfWxlfH0gkfdTor3lWQ1DDfaBPZAWYZLsoSX/wjSZ SeMJd17P8brabyO8/W3NeFScwHTimO6tHXX5c5tb5S8i/cFYUh2KpC0Ou1DHEQgZFy Ss4VE2QlwyGVg0thG1u0fdcCP2kj6WWtw0c9EiNiuuuUWwx4ZgWA82C+Vsm0BbajFq z6j5l6F77w91A== Date: Thu, 3 Jun 2021 08:40:24 -0700 From: Jaegeuk Kim To: Greg KH Cc: Daniel Rosenberg , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi , kernel-team@android.com, stable@vger.kernel.org Subject: Re: [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs Message-ID: References: <20210603095038.314949-1-drosen@google.com> <20210603095038.314949-3-drosen@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/03, Greg KH wrote: > On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: > > Older kernels don't support encryption with casefolding. This adds > > the sysfs entry encrypted_casefold to show support for those combined > > features. Support for this feature was originally added by > > commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > > > Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > Cc: stable@vger.kernel.org # v5.11+ > > Signed-off-by: Daniel Rosenberg > > --- > > fs/f2fs/sysfs.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > index 09e3f258eb52..6604291a3cdf 100644 > > --- a/fs/f2fs/sysfs.c > > +++ b/fs/f2fs/sysfs.c > > @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, > > if (f2fs_sb_has_compression(sbi)) > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > len ? ", " : "", "compression"); > > + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) > > + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > + len ? ", " : "", "encrypted_casefold"); > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > len ? ", " : "", "pin_file"); > > len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); > > This is a HUGE abuse of sysfs and should not be encouraged and added to. This feature entry was originally added in 2017. Let me try to clean this up after merging this. > > Please make these "one value per file" and do not keep growing a single > file that has to be parsed otherwise you will break userspace tools. > > And I don't see a Documentation/ABI/ entry for this either :( There is in Documentation/ABI/testing/sysfs-fs-f2fs. > > not good... > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 63FB6C47098 for ; Thu, 3 Jun 2021 15:40:44 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C3256100B for ; Thu, 3 Jun 2021 15:40:44 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C3256100B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1lopSc-0004Kr-4Y; Thu, 03 Jun 2021 15:40:42 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lopSa-0004Kc-Ft for linux-f2fs-devel@lists.sourceforge.net; Thu, 03 Jun 2021 15:40:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=In-Reply-To:Content-Type:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=oaFDhBDWYyknvmxveNHsCnIkDPK+/AGq57BXmyV5qnQ=; b=LiIaH/bp4JzS312kzjbO8wbQOB +5+9HLDCgav/BuTTDQaaEmzVE32aiLw+LVi7mmpaXR1fAMMD5dBpqLNqq1dkpUOErGXs0sSOR4jfz 9vzMVJ1LbF3OWCXIxhxygo2IKsza1zekgLKguWRIaD/KmTqGDObiT8TRtQ+63ghooByU=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To :From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=oaFDhBDWYyknvmxveNHsCnIkDPK+/AGq57BXmyV5qnQ=; b=LulDA7xL6sCQ2TsUuJY0zGnE6F S4lfKfi1odFX8mrU26liEwrLPO33SOKcJFDqdg8jblPhkuKwIhuiSTdXpcZasxK5ls/u4841t5a27 jQbkJzn+UrPhKCJhkFjiEm3rv7qvDAG8TOBykX2Jmzvuob8CIEihMoYXkaNqFbuiflcc=; Received: from mail.kernel.org ([198.145.29.99]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.92.3) id 1lopSS-0098SZ-7F for linux-f2fs-devel@lists.sourceforge.net; Thu, 03 Jun 2021 15:40:41 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id B4F50611ED; Thu, 3 Jun 2021 15:40:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1622734826; bh=mFAhNgmUD+wtIhwDrs/ENUxcjRAmrenuOPwzcjPUBhE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Ki8nDtgjf9jwCjL2WGcL99KCyzystjkusR4WvwQzMFYK5PnVnLQoUkUJBT2nP57B+ e3qgJjXtUWbjITUVd0T7cNiVvBL+KA4KS7wEfZKT/4Hsg3HxUmvfWMpUavO9GpcMb2 KqDhVPCAAQCCdU0pFU1iWNclAyfWxlfH0gkfdTor3lWQ1DDfaBPZAWYZLsoSX/wjSZ SeMJd17P8brabyO8/W3NeFScwHTimO6tHXX5c5tb5S8i/cFYUh2KpC0Ou1DHEQgZFy Ss4VE2QlwyGVg0thG1u0fdcCP2kj6WWtw0c9EiNiuuuUWwx4ZgWA82C+Vsm0BbajFq z6j5l6F77w91A== Date: Thu, 3 Jun 2021 08:40:24 -0700 From: Jaegeuk Kim To: Greg KH Message-ID: References: <20210603095038.314949-1-drosen@google.com> <20210603095038.314949-3-drosen@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Headers-End: 1lopSS-0098SZ-7F Subject: Re: [f2fs-dev] [PATCH v2 2/2] f2fs: Advertise encrypted casefolding in sysfs X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Rosenberg , kernel-team@android.com, linux-kernel@vger.kernel.org, stable@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, Gabriel Krisman Bertazi Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 06/03, Greg KH wrote: > On Thu, Jun 03, 2021 at 09:50:38AM +0000, Daniel Rosenberg wrote: > > Older kernels don't support encryption with casefolding. This adds > > the sysfs entry encrypted_casefold to show support for those combined > > features. Support for this feature was originally added by > > commit 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > > > Fixes: 7ad08a58bf67 ("f2fs: Handle casefolding with Encryption") > > Cc: stable@vger.kernel.org # v5.11+ > > Signed-off-by: Daniel Rosenberg > > --- > > fs/f2fs/sysfs.c | 15 +++++++++++++-- > > 1 file changed, 13 insertions(+), 2 deletions(-) > > > > diff --git a/fs/f2fs/sysfs.c b/fs/f2fs/sysfs.c > > index 09e3f258eb52..6604291a3cdf 100644 > > --- a/fs/f2fs/sysfs.c > > +++ b/fs/f2fs/sysfs.c > > @@ -161,6 +161,9 @@ static ssize_t features_show(struct f2fs_attr *a, > > if (f2fs_sb_has_compression(sbi)) > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > len ? ", " : "", "compression"); > > + if (f2fs_sb_has_casefold(sbi) && f2fs_sb_has_encrypt(sbi)) > > + len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > + len ? ", " : "", "encrypted_casefold"); > > len += scnprintf(buf + len, PAGE_SIZE - len, "%s%s", > > len ? ", " : "", "pin_file"); > > len += scnprintf(buf + len, PAGE_SIZE - len, "\n"); > > This is a HUGE abuse of sysfs and should not be encouraged and added to. This feature entry was originally added in 2017. Let me try to clean this up after merging this. > > Please make these "one value per file" and do not keep growing a single > file that has to be parsed otherwise you will break userspace tools. > > And I don't see a Documentation/ABI/ entry for this either :( There is in Documentation/ABI/testing/sysfs-fs-f2fs. > > not good... > > greg k-h _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel