From: Thierry Reding <treding@nvidia.com>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the tegra tree
Date: Thu, 3 Jun 2021 14:18:49 +0200 [thread overview]
Message-ID: <YLjIqfeiaJqeJQtw@orome.fritz.box> (raw)
In-Reply-To: <8d8f947e-2ba4-f7b8-cb85-dcee940c96b4@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]
On Thu, Jun 03, 2021 at 05:01:48AM +0300, Dmitry Osipenko wrote:
> 03.06.2021 03:35, Stephen Rothwell пишет:
> > Hi all,
> >
> > After merging the tegra tree, today's linux-next build (x86_64
> > allmodconfig) produced this warning:
> >
> > WARNING: unmet direct dependencies detected for TEGRA210_EMC_TABLE
> > Depends on [n]: MEMORY [=y] && TEGRA_MC [=y] && ARCH_TEGRA_210_SOC [=n]
> > Selected by [m]:
> > - TEGRA210_EMC [=m] && MEMORY [=y] && TEGRA_MC [=y] && (ARCH_TEGRA_210_SOC [=n] || COMPILE_TEST [=y])
> >
> > Probably introduced by commit
> >
> > 08decdd5b448 ("memory: tegra: Enable compile testing for all drivers")
> >
>
> Thank you. This is a new warning to me, apparently this case wasn't previously tested by kernel build bot.
>
> Perhaps this should fix it:
>
> diff --git a/drivers/memory/tegra/Kconfig b/drivers/memory/tegra/Kconfig
> index 71bba2345bce..3f2fa7750118 100644
> --- a/drivers/memory/tegra/Kconfig
> +++ b/drivers/memory/tegra/Kconfig
> @@ -47,7 +47,6 @@ config TEGRA124_EMC
>
> config TEGRA210_EMC_TABLE
> bool
> - depends on ARCH_TEGRA_210_SOC
Why not just add a || COMPILE_TEST like we do for TEGRA210_EMC? Because
TEGRA210_EMC being pulled in under COMPILE_TEST (and then pulling in
TEGRA210_EMC_TABLE which is missing the alternative path) seems to be
the root cause for this.
Thierry
>
> config TEGRA210_EMC
> tristate "NVIDIA Tegra210 External Memory Controller driver"
>
>
> Thierry, please squash this change into the original patch if it looks good to you.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2021-06-03 12:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-03 0:35 linux-next: build warning after merge of the tegra tree Stephen Rothwell
2021-06-03 2:01 ` Dmitry Osipenko
2021-06-03 12:18 ` Thierry Reding [this message]
2021-06-03 14:03 ` Dmitry Osipenko
2021-06-03 14:35 ` Thierry Reding
2021-06-03 14:37 ` Dmitry Osipenko
-- strict thread matches above, loose matches on Subject: below --
2023-07-21 3:07 Stephen Rothwell
2022-06-26 23:15 Stephen Rothwell
2022-06-27 11:53 ` Jon Hunter
2015-05-07 4:06 Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YLjIqfeiaJqeJQtw@orome.fritz.box \
--to=treding@nvidia.com \
--cc=ccross@android.com \
--cc=digetx@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.