Re: [PATCH] perf symbol-elf: fix memory leak: free sdt_note.args

From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>
Cc: Riccardo Mancini <rickyman7@gmail.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@redhat.com>, Fabian Hemmer <copy@copy.sh>,
	Remi Bernon <rbernon@codeweavers.com>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-perf-users <linux-perf-users@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf symbol-elf: fix memory leak: free sdt_note.args
Date: Fri, 4 Jun 2021 10:00:52 -0300	[thread overview]
Message-ID: <YLokBBmh2+vd9E9d@kernel.org> (raw)
In-Reply-To: <CAP-5=fVp4xGd8wxLc1eFfTUPn3Urp23RmHBha2kgiJGvfysgZg@mail.gmail.com>

Em Thu, Jun 03, 2021 at 09:08:46PM -0700, Ian Rogers escreveu:
> On Wed, Jun 2, 2021 at 3:12 PM Riccardo Mancini <rickyman7@gmail.com> wrote:
> >
> > Reported by ASan.
> 
> Did you have a reproducer for getting this to fail?
> 
> > Signed-off-by: Riccardo Mancini <rickyman7@gmail.com>
> 
> Acked-by: Ian Rogers <irogers@google.com>

Thanks, applied.

- Arnaldo

> Thanks,
> Ian
> 
> > ---
> >  tools/perf/util/symbol-elf.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/tools/perf/util/symbol-elf.c b/tools/perf/util/symbol-elf.c
> > index 4c56aa8374344..a73345730ba90 100644
> > --- a/tools/perf/util/symbol-elf.c
> > +++ b/tools/perf/util/symbol-elf.c
> > @@ -2412,6 +2412,7 @@ int cleanup_sdt_note_list(struct list_head *sdt_notes)
> >
> >         list_for_each_entry_safe(pos, tmp, sdt_notes, note_list) {
> >                 list_del_init(&pos->note_list);
> > +               zfree(&pos->args);
> >                 zfree(&pos->name);
> >                 zfree(&pos->provider);
> >                 free(pos);
> > --
> > 2.31.1
> >

-- 

- Arnaldo