All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Jarkko Nikula <jarkko.nikula@bitmer.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: Regression with 6cfcd5563b4f on BeagleBoard Rev C2
Date: Sat, 5 Jun 2021 08:13:34 +0300	[thread overview]
Message-ID: <YLsH/l7G/LcHGcje@atomide.com> (raw)
In-Reply-To: <3d73f5b4-dfb3-682e-e1dc-cf5feba69121@bitmer.com>

* Jarkko Nikula <jarkko.nikula@bitmer.com> [210604 15:41]:
> On 4.6.2021 9.35, Tony Lindgren wrote:
> > Hi,
> > 
> > * Jarkko Nikula <jarkko.nikula@bitmer.com> [210602 18:21]:
> >> Hi
> >>
> >> On 6/2/21 8:30 AM, Tony Lindgren wrote:
> >>> Sounds like the beagleboard timer errata handling is either picking
> >>> a wrong clockevent timer, or later on ti-sysc misdetects the active
> >>> timer for clockevent and idles it.
> >>>
> >>> What does dmesg say in the beginning for clockevent and clocksource
> >>> timers?
> >>>
> >> I attached logs from commit 6cfcd5563b4f and commit 30c66fc30ee7 before
> >> it. Perhaps this is relevant difference between them?
> >>
> >> +ti-sysc: probe of 49032000.target-module failed with error -16
> >> +ti-sysc: probe of 48304000.target-module failed with error -16
> > 
> > Yeah so it seems. We now attempt to ignore the system timer instances
> > while it seems we need also block idling at least for timer12 that is
> > used for the beagle timer.
> > 
> > Can you test the following patch and see if it helps?
> > 
> It works! I tested on top of both regressing commit and the most recent one:
> 6cfcd5563b4f ("clocksource/drivers/timer-ti-dm: Fix suspend and resume
> for am3 and am4")
> and
> f88cd3fb9df2 ("Merge tag 'vfio-v5.13-rc5' of
> git://github.com/awilliam/linux-vfio")
> 
> You may add:
> Tested-by: Jarkko Nikula <jarkko.nikula@bitmer.com>

OK good to hear, I'll send out a fix with a proper description.

Regards,

Tony

      reply	other threads:[~2021-06-05  5:13 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-28 13:56 Regression with 6cfcd5563b4f on BeagleBoard Rev C2 Jarkko Nikula
2021-06-02  5:30 ` Tony Lindgren
2021-06-02 18:21   ` Jarkko Nikula
2021-06-04  6:35     ` Tony Lindgren
2021-06-04 15:41       ` Jarkko Nikula
2021-06-05  5:13         ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YLsH/l7G/LcHGcje@atomide.com \
    --to=tony@atomide.com \
    --cc=jarkko.nikula@bitmer.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.