From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 203B9C48BDF for ; Tue, 15 Jun 2021 04:54:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D8E9261410 for ; Tue, 15 Jun 2021 04:54:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbhFOE4I (ORCPT ); Tue, 15 Jun 2021 00:56:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:47878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229463AbhFOE4H (ORCPT ); Tue, 15 Jun 2021 00:56:07 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 72E33613DA; Tue, 15 Jun 2021 04:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732843; bh=fOIVqueeSvIwOOwxymxG8iFOWHtHfToeXH/xfzZ28uI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UKGeezVAF9k1Qj+Q3biPH7GSCVfzDL8wL13gj2j8wghAeH385rdx3gaG4E8l1gH6I s97LAabbdqXs5+f/l3HOOG7jiEISmdDKud1DuuyxK0fXVM9LeN9RYxVyQHJ8r+hjBC nUyapEZd9oaIzfTMamNpmLT14P+9YsS8sY7CK7cQ= Date: Tue, 15 Jun 2021 06:54:00 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 1/4] remoteproc: core: Move cdev add before device add Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-2-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623723671-5517-2-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, Jun 14, 2021 at 07:21:08PM -0700, Siddharth Gupta wrote: > When cdev_add is called after device_add has been called there is no > way for the userspace to know about the addition of a cdev as cdev_add > itself doesn't trigger a uevent notification, or for the kernel to > know about the change to devt. This results in two problems: > - mknod is never called for the cdev and hence no cdev appears on > devtmpfs. > - sysfs links to the new cdev are not established. > > The cdev needs to be added and devt assigned before device_add() is > called in order for the relevant sysfs and devtmpfs entries to be > created and the uevent to be properly populated. > > Signed-off-by: Siddharth Gupta > Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/remoteproc_core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95F57C48BE5 for ; Tue, 15 Jun 2021 16:04:58 +0000 (UTC) Received: from bombadil.infradead.org (unknown [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 561D461458 for ; Tue, 15 Jun 2021 16:04:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 561D461458 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aqM3PAOxjMgj6hixWnH+8U7mc8bHzP8NArFCRxsKChU=; b=dGaW3OAv1X+Yho ECviGpjPP7xycBEtVU+IFc7U33ehpk+JBnvL0KcP0tv52WtM2dtPXCOwHUykJufWHraiP0c97A3HS +dyuUy5G+sk7a0a9EGP9CLO1+YDqFroTgoUajTU4SDkMw2BZy1Kg25UEsdYQLS5MSQrBRyoet+qdp DkCj5lYbvS6uf1Mn+fh9sItF6AzFYvALaSYAn/8psbE0L2dLETPolwewbIqRy4NZaorPlswK08lU0 9RpaFWr8F1D/40zI5F/K0/YmJ7NqLpDtchSSW5uyonjrxNNKiwXeU1u+gqC0xDvpqzMw7Srcb41oF yolE8zjoSgEZUYiN1U6w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltBRp-001AGA-Ue; Tue, 15 Jun 2021 15:57:54 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt9N1-000E8e-MR for linux-arm-kernel@bombadil.infradead.org; Tue, 15 Jun 2021 13:44:48 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=N5q11scYHwf0QRFWjOZh8dOa0hkPtTQAHqhvc5sDQbY=; b=q99QVmN6B/8PSa4/3/kGKKbRCZ 2ek0rwXSGypfYl7EHaCH9G4LVBnE1A2HW8Ym354VL2TrjWQ7ryXSaipj34aQQESwLgQBW5lzfR608 MYUAWfRPv+BGW6VdbprE/+LWFK40UoyM96AsnnRA4r42SNljefwFcFDjNrrGkHPI9fv4GQSc6YHpW v/1WYl8419Q3st3n2Gb7tyWMxsS6qN0Ky62YqexYk/HCih8Qg7NIqGxaxiPjvVj3Uyu3wFWY/RJPP h+OfD8TLyrTlfg6s8ICjcTbN/mvsgwC55pBoOAlxAX9UNYO+ucqrVEozXVetLzo2ORUDyjvO5MYfw DRmJLX4Q==; Received: from mail.kernel.org ([198.145.29.99]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lt15M-007LbU-Qp for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 04:54:09 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 72E33613DA; Tue, 15 Jun 2021 04:54:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1623732843; bh=fOIVqueeSvIwOOwxymxG8iFOWHtHfToeXH/xfzZ28uI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=UKGeezVAF9k1Qj+Q3biPH7GSCVfzDL8wL13gj2j8wghAeH385rdx3gaG4E8l1gH6I s97LAabbdqXs5+f/l3HOOG7jiEISmdDKud1DuuyxK0fXVM9LeN9RYxVyQHJ8r+hjBC nUyapEZd9oaIzfTMamNpmLT14P+9YsS8sY7CK7cQ= Date: Tue, 15 Jun 2021 06:54:00 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v3 1/4] remoteproc: core: Move cdev add before device add Message-ID: References: <1623723671-5517-1-git-send-email-sidgup@codeaurora.org> <1623723671-5517-2-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1623723671-5517-2-git-send-email-sidgup@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_055407_890877_52B69FDB X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Jun 14, 2021 at 07:21:08PM -0700, Siddharth Gupta wrote: > When cdev_add is called after device_add has been called there is no > way for the userspace to know about the addition of a cdev as cdev_add > itself doesn't trigger a uevent notification, or for the kernel to > know about the change to devt. This results in two problems: > - mknod is never called for the cdev and hence no cdev appears on > devtmpfs. > - sysfs links to the new cdev are not established. > > The cdev needs to be added and devt assigned before device_add() is > called in order for the relevant sysfs and devtmpfs entries to be > created and the uevent to be properly populated. > > Signed-off-by: Siddharth Gupta > Reviewed-by: Bjorn Andersson > --- > drivers/remoteproc/remoteproc_core.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) This is not the correct way to submit patches for inclusion in the stable kernel tree. Please read: https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html for how to do this properly. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel