From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 902D7C48BE5 for ; Tue, 15 Jun 2021 19:06:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B81B610EA for ; Tue, 15 Jun 2021 19:06:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231518AbhFOTIl (ORCPT ); Tue, 15 Jun 2021 15:08:41 -0400 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]:43793 "EHLO wnew4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229749AbhFOTIk (ORCPT ); Tue, 15 Jun 2021 15:08:40 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 97CD216D6; Tue, 15 Jun 2021 15:06:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 15 Jun 2021 15:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=/2BblplUVZDT58n4HQMdwC2devr kLIjTioetJuumzdM=; b=gvA+vmNTW6SQ/yRcCeCc8RnklKzplFOAIG8fNSzh9L+ 8XtSYhIxME9ZU1GuXL/KHiSeVQPIOGSQ0ed0sBOlOsZSwOl9uVyPHZ+lD/EX/nZ+ ooio3NmE0fOAXIliC8eBH69p8USXauj3RKx0faQqosQ6/ajh5gWC+KE2qfcKvVHb /i4oYHcBu/is6SbpcEEILMzp/fDrH9q8uFdsGsBHCkAl8LE9TLfchjH1PeEpy0Q/ wR+WpuJCovcZKV8LrVNe4plvaXmxpGqdgIouRDwtEN4W6/7sPvLJYO6LFa9WnxZD sO0Wus8l10f/V5JlI+HMFZPQOaAoGKwWRvUq0V1LR0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/2Bblp lUVZDT58n4HQMdwC2devrkLIjTioetJuumzdM=; b=nIWXQWhS4GKFXNzjNSdEBA RFicbQJhGGgswI/uVrquDNEWqbEwzQPmVmcJpaa8MtPa8K8zgWDRm53KcP31D0xl uJ0jLzHtsUqLXdr36C7189126kHKtEsbLkz8EPaDu040brcWDIROmh0mJg2agXPH mks9/jhHyV+n7WCZUyqvJC15jRL8npdobd8ZMag1mvlMAz3PAh4K3DLSoI8vMeQj O/MrTPeI5xZwZkfpUSsjO7gPt8z8D3wX9WAY6x5476FmxF59yFYEYhv3xSqGoHXv zvv/2nY6KGLj6vPUuf9j33oTzn9eDKiDaK9DEzq/kPUjZffuqVYBHbDQN8HDKanw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvjedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Jun 2021 15:06:33 -0400 (EDT) Date: Tue, 15 Jun 2021 21:06:31 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v4 4/4] remoteproc: core: Cleanup device in case of failure Message-ID: References: <1623783824-13395-1-git-send-email-sidgup@codeaurora.org> <1623783824-13395-5-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1623783824-13395-5-git-send-email-sidgup@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, Jun 15, 2021 at 12:03:44PM -0700, Siddharth Gupta wrote: > When a failure occurs in rproc_add() it returns an error, but does > not cleanup after itself. This change adds the failure path in such > cases. > > Signed-off-by: Siddharth Gupta > Cc: stable@vger.kernel.org > --- > drivers/remoteproc/remoteproc_core.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) Why is this needed for stable kernels? And again, a Fixes: tag? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A15EC48BE5 for ; Tue, 15 Jun 2021 22:06:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC94B61166 for ; Tue, 15 Jun 2021 22:06:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC94B61166 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kroah.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BldxdKA4AEYbz42IY66skDen4LLvCuLeC00Q3dBMxOk=; b=je12OaEeswVxbk 6pFl+j2D3XjQHWPiob0zlTsgE6tTqRqa9bH2RgR7gQmsJhLKL+jQSMglGPL9iYUeGQTXQWsT4NQzf r1LY5mBYW+hDkqTI+MvBkfNEU3IH5Zh/zUkzt8KoLEI38TScNZ2haMFrJ4IpagN2lmEkOJSpo/RPp e2kSovU1CsI1uOcagbeuusH8ib6E5tQcS+MpJOBUxE9so7YC80Ak19ztaxtNPaIpsmVTA1wYdRvwO Oloi4McMDqqZJDOkakDC/87Z2c4Vt17KGi2rnxGp50E3Numq4qdKSHdR5lcin6Co1rdiyGrNSnU4i mD5+UAys5iBH0hRiV4mw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltHAC-003Pbe-H4; Tue, 15 Jun 2021 22:04:05 +0000 Received: from wnew4-smtp.messagingengine.com ([64.147.123.18]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ltEOS-002K51-5O for linux-arm-kernel@lists.infradead.org; Tue, 15 Jun 2021 19:06:37 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 97CD216D6; Tue, 15 Jun 2021 15:06:34 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Tue, 15 Jun 2021 15:06:35 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kroah.com; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm1; bh=/2BblplUVZDT58n4HQMdwC2devr kLIjTioetJuumzdM=; b=gvA+vmNTW6SQ/yRcCeCc8RnklKzplFOAIG8fNSzh9L+ 8XtSYhIxME9ZU1GuXL/KHiSeVQPIOGSQ0ed0sBOlOsZSwOl9uVyPHZ+lD/EX/nZ+ ooio3NmE0fOAXIliC8eBH69p8USXauj3RKx0faQqosQ6/ajh5gWC+KE2qfcKvVHb /i4oYHcBu/is6SbpcEEILMzp/fDrH9q8uFdsGsBHCkAl8LE9TLfchjH1PeEpy0Q/ wR+WpuJCovcZKV8LrVNe4plvaXmxpGqdgIouRDwtEN4W6/7sPvLJYO6LFa9WnxZD sO0Wus8l10f/V5JlI+HMFZPQOaAoGKwWRvUq0V1LR0g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=/2Bblp lUVZDT58n4HQMdwC2devrkLIjTioetJuumzdM=; b=nIWXQWhS4GKFXNzjNSdEBA RFicbQJhGGgswI/uVrquDNEWqbEwzQPmVmcJpaa8MtPa8K8zgWDRm53KcP31D0xl uJ0jLzHtsUqLXdr36C7189126kHKtEsbLkz8EPaDu040brcWDIROmh0mJg2agXPH mks9/jhHyV+n7WCZUyqvJC15jRL8npdobd8ZMag1mvlMAz3PAh4K3DLSoI8vMeQj O/MrTPeI5xZwZkfpUSsjO7gPt8z8D3wX9WAY6x5476FmxF59yFYEYhv3xSqGoHXv zvv/2nY6KGLj6vPUuf9j33oTzn9eDKiDaK9DEzq/kPUjZffuqVYBHbDQN8HDKanw == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfedvjedgudefgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepifhrvghg ucfmjfcuoehgrhgvgheskhhrohgrhhdrtghomheqnecuggftrfgrthhtvghrnhepveeuhe ejgfffgfeivddukedvkedtleelleeghfeljeeiueeggeevueduudekvdetnecuvehluhhs thgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepghhrvghgsehkrhhorg hhrdgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 15 Jun 2021 15:06:33 -0400 (EDT) Date: Tue, 15 Jun 2021 21:06:31 +0200 From: Greg KH To: Siddharth Gupta Cc: bjorn.andersson@linaro.org, ohad@wizery.com, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, psodagud@codeaurora.org, stable@vger.kernel.org Subject: Re: [PATCH v4 4/4] remoteproc: core: Cleanup device in case of failure Message-ID: References: <1623783824-13395-1-git-send-email-sidgup@codeaurora.org> <1623783824-13395-5-git-send-email-sidgup@codeaurora.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1623783824-13395-5-git-send-email-sidgup@codeaurora.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210615_120636_304343_618143ED X-CRM114-Status: GOOD ( 11.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 15, 2021 at 12:03:44PM -0700, Siddharth Gupta wrote: > When a failure occurs in rproc_add() it returns an error, but does > not cleanup after itself. This change adds the failure path in such > cases. > > Signed-off-by: Siddharth Gupta > Cc: stable@vger.kernel.org > --- > drivers/remoteproc/remoteproc_core.c | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) Why is this needed for stable kernels? And again, a Fixes: tag? _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel