From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
martin.botka@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] arm64: dts: qcom: sm8250: Commonize PCIe pins
Date: Tue, 15 Jun 2021 21:41:07 -0500 [thread overview]
Message-ID: <YMlkwzxR20p7GI7g@builder.lan> (raw)
In-Reply-To: <20210616005843.79579-2-konrad.dybcio@somainline.org>
On Tue 15 Jun 19:58 CDT 2021, Konrad Dybcio wrote:
[..]
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
[..]
> @@ -3490,6 +3508,89 @@ data {
> bias-pull-up;
> };
> };
> +
> + pcie0_default_state: pcie0-default {
I thought I answered the other way around (that it should be in the
board file), that said I don't think these are moving much, so I'm not
against keeping them here.
> + pcie0_perst_default: perst {
> + pins = "gpio79";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-down;
> + };
> +
> + clkreq {
> + pins = "gpio80";
> + function = "pci_e0";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + wake {
> + pins = "gpio81";
> + function = "gpio";
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> + };
[..]
> +
> + mdm2ap_default: mdm2ap-default {
These however are presumably only present on devices with SDX55, so
please move these two to your board file.
Thanks,
Bjorn
next prev parent reply other threads:[~2021-06-16 2:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-16 0:58 [PATCH 1/6] arm64: dts: qcom: sm8250-edo: Add hardware keys Konrad Dybcio
2021-06-16 0:58 ` [PATCH 2/6] arm64: dts: qcom: sm8250: Commonize PCIe pins Konrad Dybcio
2021-06-16 2:41 ` Bjorn Andersson [this message]
2021-06-16 0:58 ` [PATCH 3/6] arm64: dts: qcom: sm8250-edo: Enable PCIe Konrad Dybcio
2021-06-16 0:58 ` [PATCH 4/6] arm64: dts: qcom: sm8250-edo: Enable ADSP/CDSP/SLPI Konrad Dybcio
2021-06-16 2:44 ` Bjorn Andersson
2021-06-16 12:18 ` Konrad Dybcio
2021-06-16 0:58 ` [PATCH 5/6] arm64: dts: qcom: sm8250-edo: Enable GPI DMA Konrad Dybcio
2021-06-16 0:58 ` [PATCH 6/6] arm64: dts: qcom: sm8250-edo: Add Samsung touchscreen Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YMlkwzxR20p7GI7g@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=devicetree@vger.kernel.org \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=martin.botka@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.