From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Kishon Vijay Abraham I <kishon@ti.com>
Cc: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Lorenzo Pieralisi" <lorenzo.pieralisi@arm.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
linux-pci@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH] PCI: endpoint: Make struct pci_epf_driver::remove return void
Date: Tue, 22 Jun 2021 12:10:28 +0200 [thread overview]
Message-ID: <YNG3FKD+OUBbsD7e@kroah.com> (raw)
In-Reply-To: <2a12ff97-a916-d70e-9e5b-b796e9c58288@ti.com>
On Tue, Jun 22, 2021 at 03:29:27PM +0530, Kishon Vijay Abraham I wrote:
>
>
> On 23/02/21 2:37 pm, Uwe Kleine-König wrote:
> > The driver core ignores the return value of pci_epf_device_remove()
> > (because there is only little it can do when a device disappears) and
> > there are no pci_epf_drivers with a remove callback.
> >
> > So make it impossible for future drivers to return an unused error code
> > by changing the remove prototype to return void.
> >
> > The real motivation for this change is the quest to make struct
> > bus_type::remove return void, too.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Fine with this change!
>
> FWIW:
> Acked-by: Kishon Vijay Abraham I <kishon@ti.com>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
next prev parent reply other threads:[~2021-06-22 10:10 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-23 9:07 [PATCH] PCI: endpoint: Make struct pci_epf_driver::remove return void Uwe Kleine-König
2021-05-05 19:53 ` Uwe Kleine-König
2021-05-10 19:26 ` Uwe Kleine-König
2021-06-22 8:02 ` Uwe Kleine-König
2021-06-22 9:59 ` Kishon Vijay Abraham I
2021-06-22 10:10 ` Greg Kroah-Hartman [this message]
2021-07-05 15:46 ` Uwe Kleine-König
2021-07-08 9:23 ` Uwe Kleine-König
2021-07-08 10:15 ` Kishon Vijay Abraham I
2021-07-12 20:51 ` Bjorn Helgaas
2021-07-13 6:16 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNG3FKD+OUBbsD7e@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bhelgaas@google.com \
--cc=kernel@pengutronix.de \
--cc=kishon@ti.com \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.