From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Andi Kleen <ak@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Namhyung Kim <namhyung@kernel.org>, Leo Yan <leo.yan@linaro.org>,
Kan Liang <kan.liang@linux.intel.com>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC 01/11] perf script: Move filter_cpu() earlier
Date: Tue, 22 Jun 2021 15:16:35 -0300 [thread overview]
Message-ID: <YNIpAzBWoY8n9Z1g@kernel.org> (raw)
In-Reply-To: <20210621150514.32159-2-adrian.hunter@intel.com>
Em Mon, Jun 21, 2021 at 06:05:04PM +0300, Adrian Hunter escreveu:
> Generally, it should be more efficient if filter_cpu() comes before
> machine__resolve() because filter_cpu() is much less code than
> machine__resolve().
Simple patch, I like it, applied.
- Arnaldo
> Example:
>
> $ perf record --sample-cpu -- make -C tools/perf >/dev/null
>
> Before:
>
> $ perf stat -- perf script -C 0 >/dev/null
>
> Performance counter stats for 'perf script -C 0':
>
> 116.94 msec task-clock # 0.992 CPUs utilized
> 2 context-switches # 17.103 /sec
> 0 cpu-migrations # 0.000 /sec
> 8,187 page-faults # 70.011 K/sec
> 478,351,812 cycles # 4.091 GHz
> 564,785,464 instructions # 1.18 insn per cycle
> 114,341,105 branches # 977.789 M/sec
> 2,615,495 branch-misses # 2.29% of all branches
>
> 0.117840576 seconds time elapsed
>
> 0.085040000 seconds user
> 0.032396000 seconds sys
>
> After:
>
> $ perf stat -- perf script -C 0 >/dev/null
>
> Performance counter stats for 'perf script -C 0':
>
> 107.45 msec task-clock # 0.992 CPUs utilized
> 3 context-switches # 27.919 /sec
> 0 cpu-migrations # 0.000 /sec
> 7,964 page-faults # 74.117 K/sec
> 438,417,260 cycles # 4.080 GHz
> 522,571,855 instructions # 1.19 insn per cycle
> 105,187,488 branches # 978.921 M/sec
> 2,356,261 branch-misses # 2.24% of all branches
>
> 0.108282546 seconds time elapsed
>
> 0.095935000 seconds user
> 0.011991000 seconds sys
>
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> tools/perf/builtin-script.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
> index 57488d60b64a..08a2b5d51018 100644
> --- a/tools/perf/builtin-script.c
> +++ b/tools/perf/builtin-script.c
> @@ -2191,6 +2191,9 @@ static int process_sample_event(struct perf_tool *tool,
> return 0;
> }
>
> + if (filter_cpu(sample))
> + return 0;
> +
> if (machine__resolve(machine, &al, sample) < 0) {
> pr_err("problem processing %d event, skipping it.\n",
> event->header.type);
> @@ -2200,9 +2203,6 @@ static int process_sample_event(struct perf_tool *tool,
> if (al.filtered)
> goto out_put;
>
> - if (filter_cpu(sample))
> - goto out_put;
> -
> if (scripting_ops) {
> struct addr_location *addr_al_ptr = NULL;
> struct addr_location addr_al;
> --
> 2.17.1
>
--
- Arnaldo
next prev parent reply other threads:[~2021-06-22 18:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-21 15:05 [PATCH RFC 00/11] perf script: Add API for filtering via dynamically loaded shared object Adrian Hunter
2021-06-21 15:05 ` [PATCH RFC 01/11] perf script: Move filter_cpu() earlier Adrian Hunter
2021-06-22 18:16 ` Arnaldo Carvalho de Melo [this message]
2021-06-21 15:05 ` [PATCH RFC 02/11] perf script: Move filtering before scripting Adrian Hunter
2021-06-22 18:18 ` Arnaldo Carvalho de Melo
2021-06-21 15:05 ` [PATCH RFC 03/11] perf script: Share addr_al between functions Adrian Hunter
2021-06-22 18:21 ` Arnaldo Carvalho de Melo
2021-06-21 15:05 ` [PATCH RFC 04/11] perf script: Add API for filtering via dynamically loaded shared object Adrian Hunter
2021-06-22 18:32 ` Arnaldo Carvalho de Melo
2021-06-23 9:25 ` Adrian Hunter
2021-06-21 15:05 ` [PATCH RFC 05/11] perf script: Add dlfilter__filter_event_early() Adrian Hunter
2021-06-21 15:05 ` [PATCH RFC 06/11] perf build: Install perf_dlfilter.h Adrian Hunter
2021-06-21 15:05 ` [PATCH RFC 07/11] perf dlfilter: Add resolve_address() to perf_dlfilter_fns Adrian Hunter
2021-06-21 15:05 ` [PATCH RFC 08/11] perf dlfilter: Add insn() " Adrian Hunter
2021-06-21 15:05 ` [PATCH RFC 09/11] perf dlfilter: Add srcline() " Adrian Hunter
2021-06-21 15:05 ` [PATCH RFC 10/11] perf dlfilter: Add attr() " Adrian Hunter
2021-06-21 15:05 ` [PATCH RFC 11/11] perf dlfilter: Add object_code() " Adrian Hunter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YNIpAzBWoY8n9Z1g@kernel.org \
--to=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=ak@linux.intel.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=leo.yan@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.