From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B659C48BDF for ; Wed, 23 Jun 2021 02:16:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6EBE161375 for ; Wed, 23 Jun 2021 02:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbhFWCSz (ORCPT ); Tue, 22 Jun 2021 22:18:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbhFWCSz (ORCPT ); Tue, 22 Jun 2021 22:18:55 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EF79C061574; Tue, 22 Jun 2021 19:16:38 -0700 (PDT) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BF1C39B1; Wed, 23 Jun 2021 04:16:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624414596; bh=Ss37APFi5E/zsBkC1jBYgb6kPSCoHe1wPht/2aZWDYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CgOU45H8fNZdAwFw4vKR9CYETeh3YZdO4TlIq9SJ/8Nvr/cBUfDO3ATYBTsNeVdsi y28C+/cIiTNHcKLt1r8BlQSF5Ga9Ue8Hf1aWdf2g1XpXTNC1gDcI3lFBOg125TBM8y ffsteQXKJ3eMGUsN3twBr7uC+t8Wgyi+XPK3XAJg= Date: Wed, 23 Jun 2021 05:16:08 +0300 From: Laurent Pinchart To: Kieran Bingham Cc: Kieran Bingham , David Airlie , Daniel Vetter , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" , open list Subject: Re: [PATCH 2/3] drm: rcar-du: Only initialise TVM_TVSYNC mode when supported Message-ID: References: <20210622232024.3215248-1-kieran.bingham@ideasonboard.com> <20210622232024.3215248-3-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210622232024.3215248-3-kieran.bingham@ideasonboard.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kieran, Thank you for the patch. On Wed, Jun 23, 2021 at 12:20:23AM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > The R-Car DU as found on the D3, E3, and V3U do not have support > for an external synchronisation method. > > In these cases, the dsysr cached register should not be initialised > in DSYSR_TVM_TVSYNC, but instead should be left clear to configure as > DSYSR_TVM_MASTER by default. > > Signed-off-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > index ea7e39d03545..cff0d82b9491 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -1243,7 +1243,10 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int swindex, > rcrtc->group = rgrp; > rcrtc->mmio_offset = mmio_offsets[hwindex]; > rcrtc->index = hwindex; > - rcrtc->dsysr = (rcrtc->index % 2 ? 0 : DSYSR_DRES) | DSYSR_TVM_TVSYNC; > + rcrtc->dsysr = (rcrtc->index % 2 ? 0 : DSYSR_DRES); You can drop the parentheses. Reviewed-by: Laurent Pinchart > + > + if (rcar_du_has(rcdu, RCAR_DU_FEATURE_TVM_SYNC)) > + rcrtc->dsysr |= DSYSR_TVM_TVSYNC; > > if (rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE)) > primary = &rcrtc->vsp->planes[rcrtc->vsp_pipe].plane; -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C50EDC49EA4 for ; Wed, 23 Jun 2021 02:16:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A63B610F7 for ; Wed, 23 Jun 2021 02:16:40 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A63B610F7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 93E726E87F; Wed, 23 Jun 2021 02:16:39 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6590E6E87F for ; Wed, 23 Jun 2021 02:16:38 +0000 (UTC) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id BF1C39B1; Wed, 23 Jun 2021 04:16:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1624414596; bh=Ss37APFi5E/zsBkC1jBYgb6kPSCoHe1wPht/2aZWDYw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CgOU45H8fNZdAwFw4vKR9CYETeh3YZdO4TlIq9SJ/8Nvr/cBUfDO3ATYBTsNeVdsi y28C+/cIiTNHcKLt1r8BlQSF5Ga9Ue8Hf1aWdf2g1XpXTNC1gDcI3lFBOg125TBM8y ffsteQXKJ3eMGUsN3twBr7uC+t8Wgyi+XPK3XAJg= Date: Wed, 23 Jun 2021 05:16:08 +0300 From: Laurent Pinchart To: Kieran Bingham Subject: Re: [PATCH 2/3] drm: rcar-du: Only initialise TVM_TVSYNC mode when supported Message-ID: References: <20210622232024.3215248-1-kieran.bingham@ideasonboard.com> <20210622232024.3215248-3-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210622232024.3215248-3-kieran.bingham@ideasonboard.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , open list , "open list:DRM DRIVERS FOR RENESAS" , "open list:DRM DRIVERS FOR RENESAS" , Kieran Bingham Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Kieran, Thank you for the patch. On Wed, Jun 23, 2021 at 12:20:23AM +0100, Kieran Bingham wrote: > From: Kieran Bingham > > The R-Car DU as found on the D3, E3, and V3U do not have support > for an external synchronisation method. > > In these cases, the dsysr cached register should not be initialised > in DSYSR_TVM_TVSYNC, but instead should be left clear to configure as > DSYSR_TVM_MASTER by default. > > Signed-off-by: Kieran Bingham > --- > drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > index ea7e39d03545..cff0d82b9491 100644 > --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c > @@ -1243,7 +1243,10 @@ int rcar_du_crtc_create(struct rcar_du_group *rgrp, unsigned int swindex, > rcrtc->group = rgrp; > rcrtc->mmio_offset = mmio_offsets[hwindex]; > rcrtc->index = hwindex; > - rcrtc->dsysr = (rcrtc->index % 2 ? 0 : DSYSR_DRES) | DSYSR_TVM_TVSYNC; > + rcrtc->dsysr = (rcrtc->index % 2 ? 0 : DSYSR_DRES); You can drop the parentheses. Reviewed-by: Laurent Pinchart > + > + if (rcar_du_has(rcdu, RCAR_DU_FEATURE_TVM_SYNC)) > + rcrtc->dsysr |= DSYSR_TVM_TVSYNC; > > if (rcar_du_has(rcdu, RCAR_DU_FEATURE_VSP1_SOURCE)) > primary = &rcrtc->vsp->planes[rcrtc->vsp_pipe].plane; -- Regards, Laurent Pinchart