All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Zhenguo Zhao <zhenguo6858@gmail.com>
Cc: jirislaby@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] tty: n_gsm: CR bit value should be 0 when config "initiator=0"
Date: Thu, 24 Jun 2021 14:58:14 +0200	[thread overview]
Message-ID: <YNSBZs9OXTfhGfF3@kroah.com> (raw)
In-Reply-To: <1623844402-4731-1-git-send-email-zhenguo6858@gmail.com>

On Wed, Jun 16, 2021 at 07:53:22PM +0800, Zhenguo Zhao wrote:
> From: Zhenguo Zhao <zhenguo.zhao1@unisoc.com>
> 
> config "initiator=0",gsmld will receives dlci SABM/DISC control command
> frame,as slaver,the CR bit value check should be 1.

I am really sorry, but I do not understand this changelog comment.  Can
you try rewriting it again?

> 
> if check "cr == 0",it will goto invalid,so it can't send UA response
> frame and open slaver dlci.

Same here, I do not understand.

thanks,

greg k-h

  reply	other threads:[~2021-06-24 12:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-16 11:53 [PATCH v2] tty: n_gsm: CR bit value should be 0 when config "initiator=0" Zhenguo Zhao
2021-06-24 12:58 ` Greg KH [this message]
     [not found] ` <CAGGV+3LgLdohhYhH+qJTokeNU_WdV9oRNHMc9a_5YTTVA3U8ow@mail.gmail.com>
2021-07-07  6:08   ` 赵振国
2021-07-07  6:10   ` Greg KH
2021-07-07  6:12 ` 赵振国
2021-07-15  2:29   ` 赵振国

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YNSBZs9OXTfhGfF3@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zhenguo6858@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.