From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.4 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F17E2C07E96 for ; Tue, 13 Jul 2021 18:00:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D223561363 for ; Tue, 13 Jul 2021 18:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233384AbhGMSDD (ORCPT ); Tue, 13 Jul 2021 14:03:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36778 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229478AbhGMSDA (ORCPT ); Tue, 13 Jul 2021 14:03:00 -0400 Received: from mail-pg1-x530.google.com (mail-pg1-x530.google.com [IPv6:2607:f8b0:4864:20::530]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 293A1C0613DD for ; Tue, 13 Jul 2021 11:00:10 -0700 (PDT) Received: by mail-pg1-x530.google.com with SMTP id t9so22297846pgn.4 for ; Tue, 13 Jul 2021 11:00:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=aUnwvzo3iJx64EYOs36puVhqp9GJq4422krM2Lg28ME=; b=pjVheK0zx5si1i4Eb9s5pegJG0OMW2zAHJpyCgDLb3LtX1Y7fa51g9Hemt6Z6DEA5B /v76+1atkf1zQ5aFPBUpsRPz4HjJE18d79Q9YlRKj+0UqcQZGM03XgHRrRVstC4n+XGK peZGo/WocfT+2+8SfvpxTmo0BK7901uovyMvl6KIoctAtLEwmSpwggDxYZB/t5AVbTl+ E3DdQVUj6GjNNZv/AQv/mAKC9HxWGhq05FTWUtldVgs0FJcRm6GnPuC3x74hJINiQ1PY 3mKUU2TNNxzBC3hfT8L+AZiQNftgYjcHD2fpY/H9+04lDIbk7rS3HLa8DSoPWZFDOEjv Nzaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aUnwvzo3iJx64EYOs36puVhqp9GJq4422krM2Lg28ME=; b=oRlvCB5et1xm6cALZHyTfTcuKiG5w+aKodwyaTKY1ntIBgyMIEcTrCl/g7UEvpFFkB IfXZ3sUQeki9LlSUFXEeq8ek346FxEmGPf/HtbJ5N5GqOWnfJyVsMvO18UyXe3UJZqVb qf0+mFctJEUVpvePWnI8YEYiEDdOHcfuIiZ76t/ddSrS7hIB3t2qM3vGEkskzbCALo0S KSBsjXfwXKvNhaGPgHSG46Flc/sI/UvAq9tRId1QSp2rxoWXzHt0GpEAUomv6KZ9e3j4 EEybrE92VLMoH9eHVP3FGZfQ7onF4U6zFqp1lX2NuF6FiOx0wuPU0Vf6LFyI7zGSmGoz q1Eg== X-Gm-Message-State: AOAM531JnL1nm9CvZEKdzhld7ZKrHou9lF+YCnvgj9cb117rVT+/c2K0 8JBfl7lET8m9sxs0d9EGWe0WhA== X-Google-Smtp-Source: ABdhPJxaQxbHMgMZVyJ0E5PG31fBCaX18MkwNLy14FTMd4q9lNqBvbMwHOSOurSVNYYmXu/IIpynaA== X-Received: by 2002:a62:3045:0:b029:32b:880f:c03a with SMTP id w66-20020a6230450000b029032b880fc03amr5884323pfw.22.1626199209362; Tue, 13 Jul 2021 11:00:09 -0700 (PDT) Received: from google.com (157.214.185.35.bc.googleusercontent.com. [35.185.214.157]) by smtp.gmail.com with ESMTPSA id 133sm21494711pfx.39.2021.07.13.11.00.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jul 2021 11:00:08 -0700 (PDT) Date: Tue, 13 Jul 2021 18:00:05 +0000 From: Sean Christopherson To: isaku.yamahata@intel.com Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H . Peter Anvin" , Paolo Bonzini , Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , erdemaktas@google.com, Connor Kuehl , x86@kernel.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, isaku.yamahata@gmail.com Subject: Re: [RFC PATCH v2 03/69] KVM: X86: move out the definition vmcs_hdr/vmcs from kvm to x86 Message-ID: References: <62b61eb968f867518aedd98a0753b7fd29958efb.1625186503.git.isaku.yamahata@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <62b61eb968f867518aedd98a0753b7fd29958efb.1625186503.git.isaku.yamahata@intel.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 02, 2021, isaku.yamahata@intel.com wrote: > From: Isaku Yamahata > > This is preparation for TDX support. > > Because SEAMCALL instruction requires VMX enabled, it needs to initialize > struct vmcs and load it before SEAMCALL instruction.[1] [2] Move out the > definition of vmcs into a common x86 header, arch/x86/include/asm/vmx.h, so > that seamloader code can share the same definition. ^^^^^^^^^^ SEAMLDR? I don't have a strong preference on what we call it, but we should be consistent in our usage. Same comments as the first two patches, without seeing the actual SEAMLDR code it's impossible review this patch. I certainly have no objection to splitting up this behemoth, but the series should be self contained (within reason).