From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93B49C11F67 for ; Wed, 14 Jul 2021 09:17:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D87161369 for ; Wed, 14 Jul 2021 09:17:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238473AbhGNJUJ (ORCPT ); Wed, 14 Jul 2021 05:20:09 -0400 Received: from mga11.intel.com ([192.55.52.93]:62308 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238179AbhGNJUI (ORCPT ); Wed, 14 Jul 2021 05:20:08 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10044"; a="207296715" X-IronPort-AV: E=Sophos;i="5.84,238,1620716400"; d="scan'208";a="207296715" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 02:17:17 -0700 X-IronPort-AV: E=Sophos;i="5.84,238,1620716400"; d="scan'208";a="494122677" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Jul 2021 02:17:13 -0700 Received: from andy by smile with local (Exim 4.94.2) (envelope-from ) id 1m3b0s-00DFlH-HQ; Wed, 14 Jul 2021 12:17:06 +0300 Date: Wed, 14 Jul 2021 12:17:06 +0300 From: Andy Shevchenko To: Justin He Cc: Petr Mladek , Steven Rostedt , Sergey Senozhatsky , Rasmus Villemoes , Jonathan Corbet , Alexander Viro , Linus Torvalds , "Peter Zijlstra (Intel)" , Eric Biggers , "Ahmed S. Darwish" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" , Matthew Wilcox , Christoph Hellwig , nd Subject: Re: [PATCH v2 1/4] fs: introduce helper d_path_unsafe() Message-ID: References: <20210623055011.22916-1-justin.he@arm.com> <20210623055011.22916-2-justin.he@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 14, 2021 at 08:33:10AM +0000, Justin He wrote: > > From: Justin He > > Sent: Thursday, June 24, 2021 1:49 PM > > > From: Andy Shevchenko > > > Sent: Wednesday, June 23, 2021 5:11 PM > > > On Wed, Jun 23, 2021 at 01:50:08PM +0800, Jia He wrote: ... > > > > + const char *dname = smp_load_acquire(&name->name); /* ^^^ */ > > > > > > I have commented on the comment here. What does it mean for mere reader? > > > > > > > Do you suggest making the comment "/* ^^^ */" more clear? Yes. > > It is detailed already in prepend_name_with_len()'s comments: > > > * Load acquire is needed to make sure that we see that terminating NUL, > > > * which is similar to prepend_name(). -- With Best Regards, Andy Shevchenko