From: Jeff King <peff@peff.net>
To: Elijah Newren <newren@gmail.com>
Cc: "Elijah Newren via GitGitGadget" <gitgitgadget@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>,
"Bagas Sanjaya" <bagasdotme@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Derrick Stolee" <stolee@gmail.com>,
"Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2 4/4] Bump rename limit defaults (yet again)
Date: Wed, 14 Jul 2021 13:57:21 -0400 [thread overview]
Message-ID: <YO8lgYa5/RlL1zGp@coredump.intra.peff.net> (raw)
In-Reply-To: <CABPp-BG7T2QP+6uP57NuE1Htr-vBzozL-aDxU4FsyQO+ELQ9Uw@mail.gmail.com>
On Wed, Jul 14, 2021 at 10:32:56AM -0700, Elijah Newren wrote:
> > It's slightly sad that we only got a 30% CPU improvement in the past 10
> > years. Are you just counting clock speed as a short-hand here? I think
> > that doesn't tell the whole story. But all of this is a side-note
> > anyway. What I care about is your actual timings. :)
>
> I'm using shorthand when discussing file sizes above (though I used
> actual measurements when picking new values below). But the 30% came
> from measuring the timings with the exact same sample file as you and
> using a lightly modified version of your original script (tweaked to
> also change file basenames) on an AWS c5xlarge instance. My timings
> showed they were only about 30% faster than what you got when you last
> bumped the limits.
Interesting. My timings are much faster. With a 20k file, I get (on my
laptop, which is an i9-9880H):
N CPU (2008) CPU (now)
10 0.43s 0.007s
100 0.44s 0.071s
200 1.40s 0.226s
400 4.87s 0.788s
800 18.08s 2.887s
1000 27.82s 4.431s
The 2008 timings are from the old email you linked in your commit
message, and the new one is from running the revised script you showed.
The savings seem like more than 30%. I don't know if that's all CPU or
if something changed in the code.
Using a 3k file (the median for ls-tree), numbers are similar, but a
little smaller (my n=1300 is about 1.4s). So I think we're both in the
same ballpark (and certainly an AWS machine is a perfectly fine
representative sample of where people might run Git).
-Peff
next prev parent reply other threads:[~2021-07-14 17:57 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-11 0:46 [PATCH 0/3] Improve the documentation and warnings dealing with rename/copy limits Elijah Newren via GitGitGadget
2021-07-11 0:46 ` [PATCH 1/3] doc: clarify documentation for " Elijah Newren via GitGitGadget
2021-07-11 4:37 ` Bagas Sanjaya
2021-07-11 4:52 ` Elijah Newren
2021-07-12 15:03 ` Derrick Stolee
2021-07-12 21:27 ` Junio C Hamano
2021-07-11 0:46 ` [PATCH 2/3] doc: document the special handling of -l0 Elijah Newren via GitGitGadget
2021-07-11 4:54 ` Eric Sunshine
2021-07-11 4:54 ` Elijah Newren
2021-07-11 0:46 ` [PATCH 3/3] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-12 15:09 ` Derrick Stolee
2021-07-12 18:13 ` Elijah Newren
2021-07-14 0:47 ` Junio C Hamano
2021-07-14 1:06 ` Elijah Newren
2021-07-14 1:10 ` Junio C Hamano
2021-07-14 1:22 ` Elijah Newren
2021-07-14 5:17 ` Junio C Hamano
2021-07-14 15:09 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 0/4] Rename/copy limits -- docs, warnings, and new defaults Elijah Newren via GitGitGadget
2021-07-14 1:12 ` [PATCH v2 1/4] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-14 1:12 ` [PATCH v2 2/4] doc: clarify documentation for rename/copy limits Elijah Newren via GitGitGadget
2021-07-14 7:37 ` Ævar Arnfjörð Bjarmason
2021-07-14 16:30 ` Elijah Newren
2021-07-14 22:08 ` Ævar Arnfjörð Bjarmason
2021-07-14 22:56 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 3/4] doc: document the special handling of -l0 Elijah Newren via GitGitGadget
2021-07-14 16:45 ` Jeff King
2021-07-14 17:17 ` Elijah Newren
2021-07-14 17:33 ` Jeff King
2021-07-14 19:32 ` Elijah Newren
2021-07-14 1:12 ` [PATCH v2 4/4] Bump rename limit defaults (yet again) Elijah Newren via GitGitGadget
2021-07-14 16:43 ` Jeff King
2021-07-14 17:32 ` Elijah Newren
2021-07-14 17:57 ` Jeff King [this message]
2021-07-14 20:03 ` Elijah Newren
2021-07-14 20:47 ` Jeff King
2021-07-15 0:45 ` [PATCH v3 0/4] Rename/copy limits -- docs, warnings, and new defaults Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 1/4] diff: correct warning message when renameLimit exceeded Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 2/4] doc: clarify documentation for rename/copy limits Elijah Newren via GitGitGadget
2021-07-15 0:45 ` [PATCH v3 3/4] diffcore-rename: treat a rename_limit of 0 as unlimited Elijah Newren via GitGitGadget
2021-07-15 23:17 ` Junio C Hamano
2021-07-15 0:45 ` [PATCH v3 4/4] Bump rename limit defaults (yet again) Elijah Newren via GitGitGadget
2021-07-15 13:36 ` [PATCH v3 0/4] Rename/copy limits -- docs, warnings, and new defaults Derrick Stolee
2021-07-15 23:20 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YO8lgYa5/RlL1zGp@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=avarab@gmail.com \
--cc=bagasdotme@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=newren@gmail.com \
--cc=stolee@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.