Re: [PATCH] driver core: Make probe_type of driver accessible via sysfs - Greg Kroah-Hartman

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Wenchao Hao <haowenchao@huawei.com>
Cc: "Rafael J . Wysocki" <rafael@kernel.org>,
	linux-kernel@vger.kernel.org, linfeilong@huawei.com,
	Wu Bo <wubo40@huawei.com>,
	Zhiqiang Liu <liuzhiqiang26@huawei.com>
Subject: Re: [PATCH] driver core: Make probe_type of driver accessible via sysfs
Date: Thu, 8 Jul 2021 17:53:59 +0200	[thread overview]
Message-ID: <YOcfl0DcPAy9wohy@kroah.com> (raw)
In-Reply-To: <d2a5f7f3-f68f-9420-b7ee-43102adf514f@huawei.com>

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Thu, Jul 08, 2021 at 08:49:31PM +0800, Wenchao Hao wrote:
> In some scenarios, you need to know whether the probe() callback in struct
> driver which triggered by device_add() or driver_register() is called
> synchronous or not, and modify this mode according to user requirements.

Who needs to know this?  What can you modify that will change anything?
What will you do to change it that will solve a problem that just fixing
the driver would not solve instead?

And what are these magic numbers that probe_type is?  If they are
exported to userspace, shouldn't they be a string instead?

> While kernel now does not open an interface for users to query or
> modify, so I add this interface.

You need to really document this in the changelog text, and in the abi
documentation, otherwise we have no idea what this for.

thanks,

greg k-h