All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Olaf Hering <olaf@aepfle.de>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
	Juan Quintela <quintela@redhat.com>
Subject: Re: [PATCH v1] migration: fix typo in mig_throttle_guest_down comment
Date: Thu, 8 Jul 2021 17:36:50 +0100	[thread overview]
Message-ID: <YOcpogHz4GMigdwp@work-vm> (raw)
In-Reply-To: <20210708162159.18045-1-olaf@aepfle.de>

* Olaf Hering (olaf@aepfle.de) wrote:
> Fixes commit 3d0684b2ad82a5dde68e3f08b0d7786dccaf619c ("ram: Update
> all functions comments")
> 
> Signed-off-by: Olaf Hering <olaf@aepfle.de>
> ---
>  migration/ram.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/migration/ram.c b/migration/ram.c
> index 723af67c2e..88ff34f574 100644
> --- a/migration/ram.c
> +++ b/migration/ram.c
> @@ -600,7 +600,7 @@ static size_t save_page_header(RAMState *rs, QEMUFile *f,  RAMBlock *block,
>  }
>  
>  /**
> - * mig_throttle_guest_down: throotle down the guest
> + * mig_throttle_guest_down: throttle down the guest

Ah yes, Juan frequently throotles.


Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>

>   *
>   * Reduce amount of guest cpu execution to hopefully slow down memory
>   * writes. If guest dirty memory rate is reduced below the rate at
> 
-- 
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK



  reply	other threads:[~2021-07-08 17:04 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-08 16:21 [PATCH v1] migration: fix typo in mig_throttle_guest_down comment Olaf Hering
2021-07-08 16:36 ` Dr. David Alan Gilbert [this message]
2021-07-08 17:07   ` Philippe Mathieu-Daudé
2021-07-09  9:14 ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOcpogHz4GMigdwp@work-vm \
    --to=dgilbert@redhat.com \
    --cc=olaf@aepfle.de \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.