From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Subject: Re: [PATCH] contrib: add udev qemu-guest-agent.rules
Date: Thu, 8 Jul 2021 17:36:54 +0100 [thread overview]
Message-ID: <YOcppnC8l29plH3t@redhat.com> (raw)
In-Reply-To: <316d1414d0af33f22fff24d16ad953629e7416bb.1625758833.git.crobinso@redhat.com>
On Thu, Jul 08, 2021 at 11:40:33AM -0400, Cole Robinson wrote:
> Fedora/RHEL and Debian have shipped an identical file for years.
> This pairs with contrib/systemd/qemu-guest-agent.service
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> contrib/systemd/qemu-guest-agent.rules | 2 ++
> 1 file changed, 2 insertions(+)
> create mode 100644 contrib/systemd/qemu-guest-agent.rules
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
> diff --git a/contrib/systemd/qemu-guest-agent.rules b/contrib/systemd/qemu-guest-agent.rules
> new file mode 100644
> index 0000000000..8a290abbd3
> --- /dev/null
> +++ b/contrib/systemd/qemu-guest-agent.rules
> @@ -0,0 +1,2 @@
> +SUBSYSTEM=="virtio-ports", ATTR{name}=="org.qemu.guest_agent.0", \
> + TAG+="systemd" ENV{SYSTEMD_WANTS}="qemu-guest-agent.service"
If you fancy doing more work on top, I'd suggest we wire things
up so that 'make install' will install both this new file and
the .service file, with 'meson' detecting whether we're on a
systemd enabled OS </handwaving> libvirt has some meson rules
you can crib for this purpose.
Not a blocker for merging this particular patch though.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
prev parent reply other threads:[~2021-07-08 16:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-08 15:40 [PATCH] contrib: add udev qemu-guest-agent.rules Cole Robinson
2021-07-08 16:36 ` Daniel P. Berrangé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOcppnC8l29plH3t@redhat.com \
--to=berrange@redhat.com \
--cc=crobinso@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.