All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergey Senozhatsky <senozhatsky@chromium.org>
To: Minchan Kim <minchan@kernel.org>,
	Huangzhaoyang <huangzhaoyang@gmail.com>
Cc: Zhaoyang Huang <zhaoyang.huang@unisoc.com>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Nitin Gupta <ngupta@vflare.org>,
	Sergey Senozhatsky <senozhatsky@chromium.org>
Subject: Re: [PATCH] driver: zram: fix wrong counting on pages_store
Date: Mon, 26 Jul 2021 10:27:40 +0900	[thread overview]
Message-ID: <YP4PjMnw1OZtARQC@google.com> (raw)
In-Reply-To: <1626763658-27748-1-git-send-email-huangzhaoyang@gmail.com>

On (21/07/20 14:47), Huangzhaoyang wrote:
> It makes the statistic confused when counting pages_store in during writeback.
> pages_store should just reflect the swapped pages on ZRAM, while bd_writes be
> responsible for writeback things.
> 
> Signed-off-by: Zhaoyang Huang <zhaoyang.huang@unisoc.com>
> ---
>  drivers/block/zram/zram_drv.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index cf8deec..6bdaa9d 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -765,7 +765,6 @@ static ssize_t writeback_store(struct device *dev,
>  		zram_set_flag(zram, index, ZRAM_WB);
>  		zram_set_element(zram, index, blk_idx);
>  		blk_idx = 0;
> -		atomic64_inc(&zram->stats.pages_stored);

Yeah, I think we don't need it here.

Minchan, what do you think?

  parent reply	other threads:[~2021-07-26  1:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-20  6:47 [PATCH] driver: zram: fix wrong counting on pages_store Huangzhaoyang
2021-07-25  1:19 ` [Resend PATCH] " Zhaoyang Huang
2021-07-25  1:19   ` Zhaoyang Huang
2021-07-26  1:27 ` Sergey Senozhatsky [this message]
2021-07-26 17:53   ` [PATCH] " Minchan Kim
2021-07-27  1:32     ` Zhaoyang Huang
2021-07-27  1:32       ` Zhaoyang Huang
2021-07-27  5:45       ` Zhaoyang Huang
2021-07-27  5:45         ` Zhaoyang Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YP4PjMnw1OZtARQC@google.com \
    --to=senozhatsky@chromium.org \
    --cc=huangzhaoyang@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=minchan@kernel.org \
    --cc=ngupta@vflare.org \
    --cc=zhaoyang.huang@unisoc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.